All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	tredaelli@redhat.com
Subject: Re: [PATCH] build: create relative symlinks for PMDs in libdir
Date: Mon, 17 Sep 2018 13:38:21 +0200	[thread overview]
Message-ID: <3796332.J9Jhy0mxQi@xps> (raw)
In-Reply-To: <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com>

13/09/2018 11:11, Bruce Richardson:
> On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote:
> > Add -r option to ln, otherwise the link will be absolute and contain
> > the build path and break packaging among other things:
> > 
> > lrwxrwxrwx 1 bluca bluca     99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
> >   -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> >      drivers/librte_mempool_dpaa.so.1.1
> > 
> > With -r:
> > 
> > lrwxrwxrwx 1 bluca bluca     35 Sep 12 18:13 librte_pmd_zlib.so.1.1
> >   -> dpdk/drivers/librte_pmd_zlib.so.1.1
> > 
> > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  buildtools/symlink-drivers-solibs.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh
> > index 803dfec491..9826c6ae37 100644
> > --- a/buildtools/symlink-drivers-solibs.sh
> > +++ b/buildtools/symlink-drivers-solibs.sh
> > @@ -9,4 +9,4 @@
> >  # parameters to script are paths relative to install prefix:
> >  # 1. directory containing driver files e.g. lib64/dpdk/drivers
> >  # 2. directory for installed regular libs e.g. lib64
> > -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> > +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

      reply	other threads:[~2018-09-17 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 17:21 [PATCH] build: create relative symlinks for PMDs in libdir Luca Boccassi
2018-09-12 17:39 ` Timothy Redaelli
2018-09-13  9:11 ` Bruce Richardson
2018-09-17 11:38   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3796332.J9Jhy0mxQi@xps \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.