* [PATCH -next] mailbox: fix invalid use of sizeof in mailbox_msg_send()
@ 2013-03-22 13:22 Wei Yongjun
2013-03-23 3:24 ` Anna, Suman
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-22 13:22 UTC (permalink / raw)
To: s-anna, linus.walleij, loic.pallardy, omar.ramirez, lugo.fernando
Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
sizeof() when applied to a pointer typed expression gives the
size of the pointer, not that of the pointed data.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mailbox/mailbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
index 5fea5c2..e011a75 100644
--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -93,8 +93,8 @@ int mailbox_msg_send(struct mailbox *mbox, struct mailbox_msg *msg)
goto out;
}
- len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(msg));
- WARN_ON(len != sizeof(msg));
+ len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(*msg));
+ WARN_ON(len != sizeof(*msg));
if (msg->size && msg->pdata) {
len = kfifo_in(&mq->fifo, (unsigned char *)msg->pdata,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH -next] mailbox: fix invalid use of sizeof in mailbox_msg_send()
2013-03-22 13:22 [PATCH -next] mailbox: fix invalid use of sizeof in mailbox_msg_send() Wei Yongjun
@ 2013-03-23 3:24 ` Anna, Suman
0 siblings, 0 replies; 2+ messages in thread
From: Anna, Suman @ 2013-03-23 3:24 UTC (permalink / raw)
To: Wei Yongjun, linus.walleij, loic.pallardy, omar.ramirez, lugo.fernando
Cc: yongjun_wei, linux-kernel
>
> sizeof() when applied to a pointer typed expression gives the size of the pointer,
> not that of the pointed data.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mailbox/mailbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index
> 5fea5c2..e011a75 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -93,8 +93,8 @@ int mailbox_msg_send(struct mailbox *mbox, struct
> mailbox_msg *msg)
> goto out;
> }
>
> - len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(msg));
> - WARN_ON(len != sizeof(msg));
> + len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(*msg));
> + WARN_ON(len != sizeof(*msg));
Thanks Wei, missed this one. In this same function, there is one more similar occurrence, which needs fixing as well.
--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -83,7 +83,7 @@ int mailbox_msg_send(struct mailbox *mbox, struct mailbox_msg
mutex_lock(&mq->mlock);
- if (kfifo_avail(&mq->fifo) < (sizeof(msg) + msg->size)) {
+ if (kfifo_avail(&mq->fifo) < (sizeof(*msg) + msg->size)) {
ret = -ENOMEM;
goto out;
}
Regards
Suman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-23 3:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-22 13:22 [PATCH -next] mailbox: fix invalid use of sizeof in mailbox_msg_send() Wei Yongjun
2013-03-23 3:24 ` Anna, Suman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.