Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Use kmalloc_array instead of kmalloc

[Janani Ravichandran <janani.rvchndrn@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2776 bytes --]



On Tuesday, 9 February 2016 17:01:18 UTC-5, Julia Lawall wrote:
>
>
>
> On Tue, 9 Feb 2016, Janani Ravichandran wrote: 
>
> > Use kmalloc_array instead of kmalloc for arrays. Coccinelle patch used: 
> > 
> > @@ 
> > expression E, F; 
> > constant FLAG; 
> > @@ 
> > 
> > - kmalloc(E*F, FLAG) 
> > + kmalloc_array(E, F, FLAG) 
>
> Actually, your patch doesn't do exactly this.  Your patch (correctly) has 
> E and F switched in the call to kmalloc_array. 
>
I actually used the semantic patch to find instances where the conversion 
could be applied, 
then looked at the declaration of kmalloc_array to determine the correct 
order of 
arguments and did the change manually to make sure the number of elements 
was the 
first argument and the size of the element was the second argument.

Please let me know if I should change anything here. Thank you!

Janani

>
> > 
> > Signed-off-by: Janani Ravichandran <janani....@gmail.com <javascript:>> 
> > --- 
> > Changes since v1: 
> >  * Corrected an error in commit message. 
>
> "an error" is not very explicit. 
>
> julia 
>
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++-- 
> >  1 file changed, 2 insertions(+), 2 deletions(-) 
> > 
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 
> > index 28ad63a..fb344d1 100644 
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 
> > @@ -601,8 +601,8 @@ static void RxReorderIndicatePacket(struct 
> ieee80211_device *ieee, 
> >          bool                        bMatchWinStart = false, bPktInBuf = 
> false; 
> >          IEEE80211_DEBUG(IEEE80211_DL_REORDER,"%s(): Seq is 
> %d,pTS->RxIndicateSeq is %d, WinSize is 
> %d\n",__func__,SeqNum,pTS->RxIndicateSeq,WinSize); 
> >   
> > -        prxbIndicateArray = kmalloc(sizeof(struct ieee80211_rxb *) * 
> > -                        REORDER_WIN_SIZE, GFP_KERNEL); 
> > +        prxbIndicateArray = kmalloc_array(RECORDER_WIN_SIZE, 
> > +                        sizeof(struct ieee80211_rxb *), GFP_KERNEL); 
> >          if (!prxbIndicateArray) 
> >                  return; 
> >   
> > -- 
> > 2.5.0 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20160210013122.GA12148%40janani-Inspiron-3521. 
>
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 4835 bytes --]