From: Julia Lawall <julia.lawall@lip6.fr>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Use kmalloc_array instead of kmalloc
Date: Tue, 9 Feb 2016 23:01:17 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1602092300180.2066@localhost6.localdomain6> (raw)
In-Reply-To: <20160210013122.GA12148@janani-Inspiron-3521>
On Tue, 9 Feb 2016, Janani Ravichandran wrote:
> Use kmalloc_array instead of kmalloc for arrays. Coccinelle patch used:
>
> @@
> expression E, F;
> constant FLAG;
> @@
>
> - kmalloc(E*F, FLAG)
> + kmalloc_array(E, F, FLAG)
Actually, your patch doesn't do exactly this. Your patch (correctly) has
E and F switched in the call to kmalloc_array.
>
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
> Changes since v1:
> * Corrected an error in commit message.
"an error" is not very explicit.
julia
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 28ad63a..fb344d1 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -601,8 +601,8 @@ static void RxReorderIndicatePacket(struct ieee80211_device *ieee,
> bool bMatchWinStart = false, bPktInBuf = false;
> IEEE80211_DEBUG(IEEE80211_DL_REORDER,"%s(): Seq is %d,pTS->RxIndicateSeq is %d, WinSize is %d\n",__func__,SeqNum,pTS->RxIndicateSeq,WinSize);
>
> - prxbIndicateArray = kmalloc(sizeof(struct ieee80211_rxb *) *
> - REORDER_WIN_SIZE, GFP_KERNEL);
> + prxbIndicateArray = kmalloc_array(RECORDER_WIN_SIZE,
> + sizeof(struct ieee80211_rxb *), GFP_KERNEL);
> if (!prxbIndicateArray)
> return;
>
> --
> 2.5.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160210013122.GA12148%40janani-Inspiron-3521.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2016-02-09 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 1:31 [PATCH v2] staging: rtl8192u: Use kmalloc_array instead of kmalloc Janani Ravichandran
2016-02-09 22:01 ` Julia Lawall [this message]
2016-02-09 22:20 ` [Outreachy kernel] " Janani Ravichandran
2016-02-09 22:35 ` Julia Lawall
2016-02-09 22:40 ` Janani Ravichandran
2016-02-10 6:19 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1602092300180.2066@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=janani.rvchndrn@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.