From: Arnout Vandecappelle <arnout@mind.be>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Michael Walle <michael@walle.cc>
Cc: "Jagan Teki" <jagan@amarulasolutions.com>,
"Michał Łyszczek" <michal.lyszczek@bofc.pl>,
buildroot@buildroot.org, "Luca Ceresoli" <luca@lucaceresoli.net>,
"Heiko Thiery" <heiko.thiery@gmail.com>,
"Giulio Benetti" <giulio.benetti@benettiengineering.com>
Subject: Re: [Buildroot] [PATCH 7/7] board/kontron/smarc-sal28/genimage.cfg: fix option suffix
Date: Tue, 9 Nov 2021 10:23:27 +0100 [thread overview]
Message-ID: <37a68082-d058-73d4-6b15-9a3129a672d7@mind.be> (raw)
In-Reply-To: <20211109085032.GF680793@scaer>
On 09/11/2021 09:50, Yann E. MORIN wrote:
> Michael, All,
>
> On 2021-11-09 09:04 +0100, Michael Walle spake thusly:
>> Am 2021-11-09 00:05, schrieb Giulio Benetti:
>>> Option 'offset = 4k' must be 'option = 4K'.
>> Why is this is a 'must'? Apparently it works, no? So if anything
>> it is for unifying; but even then it's moving in the wrong
>> direction. There is no "K" prefix in si units. Stictly speaking
>> there is no "KB"; there is a "kB" or a "KiB".
>
> This SI reference was also my comment on the preceding series, but
> unfortunately, that ship has sailed now that the series has been
> applied...
What has been applied is uppercase K everywhere. Lowercase k looks like a SI
unit, i.e. 1000, so I think uppercase is a little better. To be fully correct,
we should use KiB instead (which apparently works since genimage apparently
ignores everything after the first letter). But as you say, that ship has sailed...
Anyway, this stuff is never going to be fully accurate, so anything is OK in
my book, as long as it's consistent.
Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-11-09 9:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 23:05 [Buildroot] [PATCH 0/7] Post genimage.cfg beautify Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 1/7] board/olimex/a20_olinuxino/genimage.cfg: fix build failure due to wrong offset value suffix Giulio Benetti
2021-11-09 9:01 ` Luca Ceresoli
2021-11-09 9:16 ` Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 2/7] board/altera/socrates_cyclone5/genimage.cfg: fix offset suffix Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 3/7] board/friendlyarm/nanopi-neo2/genimage.cfg: fix comment Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 4/7] board/orangepi/orangepi-pc2/genimage.cfg: " Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 5/7] board/minnowboard/genimage.cfg: fix option assignment spaces Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 6/7] board/kontron/pitx-imx8m/genimage.cfg: fix option suffix Giulio Benetti
2021-11-09 7:37 ` Heiko Thiery
2021-11-09 7:49 ` Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 7/7] board/kontron/smarc-sal28/genimage.cfg: " Giulio Benetti
2021-11-09 8:04 ` Michael Walle
2021-11-09 8:26 ` Edgar Bonet
2021-11-09 8:49 ` Giulio Benetti
2021-11-09 8:38 ` Giulio Benetti
2021-11-09 8:50 ` Michael Walle
2021-11-09 8:50 ` Yann E. MORIN
2021-11-09 9:23 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a68082-d058-73d4-6b15-9a3129a672d7@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=heiko.thiery@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=luca@lucaceresoli.net \
--cc=michael@walle.cc \
--cc=michal.lyszczek@bofc.pl \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.