All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Michael Walle <michael@walle.cc>
Cc: "Jagan Teki" <jagan@amarulasolutions.com>,
	"Michał Łyszczek" <michal.lyszczek@bofc.pl>,
	buildroot@buildroot.org, "Luca Ceresoli" <luca@lucaceresoli.net>,
	"Heiko Thiery" <heiko.thiery@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH 7/7] board/kontron/smarc-sal28/genimage.cfg: fix option suffix
Date: Tue, 9 Nov 2021 09:38:54 +0100	[thread overview]
Message-ID: <B4721363-6522-40D2-AA25-B015E2BD5C43@benettiengineering.com> (raw)
In-Reply-To: <eea83befc9a6f40dad4efa7a4ae019de@walle.cc>


[-- Attachment #1.1: Type: text/plain, Size: 1426 bytes --]

Hi Michael, All,

> Il giorno 9 nov 2021, alle ore 09:05, Michael Walle <michael@walle.cc> ha scritto:
> 
> Am 2021-11-09 00:05, schrieb Giulio Benetti:
>> Option 'offset = 4k' must be 'option = 4K'.
> 
> Why is this is a 'must'? Apparently it works, no?

This is a standard I’ve proposed and it’s been accepted by committing all the 102 patches.
There is not an existing standard and I’ve created one, that’s all.

> So if anything
> it is for unifying; but even then it's moving in the wrong
> direction. There is no "K" prefix in si units. Stictly speaking
> there is no "KB"; there is a "kB" or a "KiB".

Here we had 2 choices using genimage “K” or “k”. I went for “K” since the most of the files had “K”.
And anyway both “K” and “k” are not that good, but it’s not our fault, it depends on genimage input format.

Yann already explained the differences between notations here:
https://lists.buildroot.org/pipermail/buildroot/2021-November/627885.html

You can follow-up the thread and the motivations on such thing.

Feel free to propose a modification on this topic since it’s “fresh”. I have to integrate a bit the manual and write a Linter for this kind of files so it’s better I know it early.

Thank you
Best regards
Giulio Benetti
Benetti Engineering sas

> 
> Anyway. I'll let the buildroot maintainers decide on this.
> 
> -michael

[-- Attachment #1.2: Type: text/html, Size: 2252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2021-11-09  8:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 23:05 [Buildroot] [PATCH 0/7] Post genimage.cfg beautify Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 1/7] board/olimex/a20_olinuxino/genimage.cfg: fix build failure due to wrong offset value suffix Giulio Benetti
2021-11-09  9:01   ` Luca Ceresoli
2021-11-09  9:16     ` Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 2/7] board/altera/socrates_cyclone5/genimage.cfg: fix offset suffix Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 3/7] board/friendlyarm/nanopi-neo2/genimage.cfg: fix comment Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 4/7] board/orangepi/orangepi-pc2/genimage.cfg: " Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 5/7] board/minnowboard/genimage.cfg: fix option assignment spaces Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 6/7] board/kontron/pitx-imx8m/genimage.cfg: fix option suffix Giulio Benetti
2021-11-09  7:37   ` Heiko Thiery
2021-11-09  7:49     ` Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 7/7] board/kontron/smarc-sal28/genimage.cfg: " Giulio Benetti
2021-11-09  8:04   ` Michael Walle
2021-11-09  8:26     ` Edgar Bonet
2021-11-09  8:49       ` Giulio Benetti
2021-11-09  8:38     ` Giulio Benetti [this message]
2021-11-09  8:50       ` Michael Walle
2021-11-09  8:50     ` Yann E. MORIN
2021-11-09  9:23       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B4721363-6522-40D2-AA25-B015E2BD5C43@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=buildroot@buildroot.org \
    --cc=heiko.thiery@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=luca@lucaceresoli.net \
    --cc=michael@walle.cc \
    --cc=michal.lyszczek@bofc.pl \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.