All of lore.kernel.org
 help / color / mirror / Atom feed
From: chenbaodong <chenbaodong@mxnavi.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen: cpu: change 'cpu_hotplug_[begin|done]' to inline function
Date: Mon, 3 Jun 2019 09:56:01 +0800	[thread overview]
Message-ID: <37db96f6-09bb-7731-5117-7b3d2af8f934@mxnavi.com> (raw)
In-Reply-To: <5CF1104A0200007800233FB2@prv1-mh.provo.novell.com>


On 5/31/19 19:30, Jan Beulich wrote:
>>>> On 31.05.19 at 12:55, <julien.grall@arm.com> wrote:
>> On 5/31/19 3:46 AM, Baodong Chen wrote:
>>> --- a/xen/include/xen/cpu.h
>>> +++ b/xen/include/xen/cpu.h
>>> @@ -10,8 +10,8 @@ bool_t get_cpu_maps(void);
>>>    void put_cpu_maps(void);
>>>    
>>>    /* Safely perform CPU hotplug and update cpu_online_map, etc. */
>>> -bool_t cpu_hotplug_begin(void);
>>> -void cpu_hotplug_done(void);
>>> +static inline bool_t cpu_hotplug_begin(void) { return get_cpu_maps(); }
>>> +static inline void cpu_hotplug_done(void) { put_cpu_maps(); }
> Plus please switch to bool at the same time.

Yes, types like boot_t or u32 are getting rid of, so should Not be used.

Will be fixed.

>
> Jan
>
>
> .
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: chenbaodong <chenbaodong@mxnavi.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen: cpu: change 'cpu_hotplug_[begin|done]' to inline function
Date: Mon, 3 Jun 2019 09:56:01 +0800	[thread overview]
Message-ID: <37db96f6-09bb-7731-5117-7b3d2af8f934@mxnavi.com> (raw)
Message-ID: <20190603015601.o4Sin1NI6FraNMKjxC8BXzHCpJi--SqsgJyzJ4GXjq0@z> (raw)
In-Reply-To: <5CF1104A0200007800233FB2@prv1-mh.provo.novell.com>


On 5/31/19 19:30, Jan Beulich wrote:
>>>> On 31.05.19 at 12:55, <julien.grall@arm.com> wrote:
>> On 5/31/19 3:46 AM, Baodong Chen wrote:
>>> --- a/xen/include/xen/cpu.h
>>> +++ b/xen/include/xen/cpu.h
>>> @@ -10,8 +10,8 @@ bool_t get_cpu_maps(void);
>>>    void put_cpu_maps(void);
>>>    
>>>    /* Safely perform CPU hotplug and update cpu_online_map, etc. */
>>> -bool_t cpu_hotplug_begin(void);
>>> -void cpu_hotplug_done(void);
>>> +static inline bool_t cpu_hotplug_begin(void) { return get_cpu_maps(); }
>>> +static inline void cpu_hotplug_done(void) { put_cpu_maps(); }
> Plus please switch to bool at the same time.

Yes, types like boot_t or u32 are getting rid of, so should Not be used.

Will be fixed.

>
> Jan
>
>
> .
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-06-03  1:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  2:46 [PATCH] xen: cpu: change 'cpu_hotplug_[begin|done]' to inline function Baodong Chen
2019-05-31  2:46 ` [Xen-devel] " Baodong Chen
2019-05-31 10:55 ` Julien Grall
2019-05-31 10:55   ` [Xen-devel] " Julien Grall
2019-05-31 11:30   ` Jan Beulich
2019-05-31 11:30     ` [Xen-devel] " Jan Beulich
2019-06-03  1:56     ` chenbaodong [this message]
2019-06-03  1:56       ` chenbaodong
2019-06-03  1:52   ` chenbaodong
2019-06-03  1:52     ` [Xen-devel] " chenbaodong
2019-06-03  9:37     ` Julien Grall
2019-06-03  9:37       ` [Xen-devel] " Julien Grall
2019-06-03 10:22       ` chenbaodong
2019-06-03 10:22         ` [Xen-devel] " chenbaodong
2019-06-03 10:40         ` Julien Grall
2019-06-03 10:40           ` [Xen-devel] " Julien Grall
2019-06-03 11:00           ` chenbaodong
2019-06-03 11:00             ` [Xen-devel] " chenbaodong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37db96f6-09bb-7731-5117-7b3d2af8f934@mxnavi.com \
    --to=chenbaodong@mxnavi.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.