[PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Peter Jones]

This was sort of annoying me:

random:~$ dmesg | tail -1
[523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
random:~$ dmesg | grep -c "Reducing the compressed"
47

This patch makes it DRM_INFO_ONCE() just like the similar message
farther down in that function is pr_info_once().

Signed-off-by: Peter Jones <pjones@redhat.com>
---
 drivers/gpu/drm/i915/intel_fbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index b431b6733cc..88b013758da 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
 	if (!ret)
 		goto err_llb;
 	else if (ret > 1) {
-		DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
+		DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
 
 	}
 
-- 
2.17.1

[PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Peter Jones]

This was sort of annoying me:

random:~$ dmesg | tail -1
[523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
random:~$ dmesg | grep -c "Reducing the compressed"
47

This patch makes it DRM_INFO_ONCE() just like the similar message
farther down in that function is pr_info_once().

Signed-off-by: Peter Jones <pjones@redhat.com>
---
 drivers/gpu/drm/i915/intel_fbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index b431b6733cc..88b013758da 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
 	if (!ret)
 		goto err_llb;
 	else if (ret > 1) {
-		DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
+		DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
 
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

✓ Fi.CI.BAT: success for Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Patchwork]

== Series Details ==

Series: Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
URL   : https://patchwork.freedesktop.org/series/46092/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4448 -> Patchwork_9577 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46092/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9577 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      fi-skl-guc:         NOTRUN -> FAIL (fdo#103167)

    
    ==== Possible fixes ====

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      DMESG-WARN (fdo#105998) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#106103, fdo#102614) -> PASS

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103


== Participating hosts (46 -> 42) ==

  Additional (1): fi-skl-guc 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4448 -> Patchwork_9577

  CI_DRM_4448: e094950bd5b5767bab1d2a5c259635dc6091f8cc @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9577: db1271a678bb745e2471c020f79a0a38a7a24f91 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

db1271a678bb Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9577/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Rodrigo Vivi]

On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote:
> This was sort of annoying me:
> 
> random:~$ dmesg | tail -1
> [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
> random:~$ dmesg | grep -c "Reducing the compressed"
> 47
> 
> This patch makes it DRM_INFO_ONCE() just like the similar message
> farther down in that function is pr_info_once().
> 
> Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
>  drivers/gpu/drm/i915/intel_fbc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> index b431b6733cc..88b013758da 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
>  	if (!ret)
>  		goto err_llb;
>  	else if (ret > 1) {
> -		DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
> +		DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");

I know the feeling of seeing a message over and over again when you are already aware of that.
Specially something that tells you to change BIOS configuration...
for this reason I think it makes sense, so:

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

I will just wait for CI and give a couple days to someone else to challenge.
If I end up forgetting to push it please ping me...

>  
>  	}
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

✓ Fi.CI.IGT: success for Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Patchwork]

== Series Details ==

Series: Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
URL   : https://patchwork.freedesktop.org/series/46092/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4448_full -> Patchwork_9577_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9577_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9577_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9577_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          SKIP -> PASS +1

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in Patchwork_9577_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_workarounds@suspend-resume-context:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          PASS -> FAIL (fdo#103355)

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822) +1

    
    ==== Possible fixes ====

    igt@kms_busy@extended-pageflip-hang-oldfb-render-a:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_flip@2x-blocking-wf_vblank:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4448 -> Patchwork_9577

  CI_DRM_4448: e094950bd5b5767bab1d2a5c259635dc6091f8cc @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9577: db1271a678bb745e2471c020f79a0a38a7a24f91 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9577/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Jiri Slaby]

On 06. 07. 18, 22:30, Rodrigo Vivi wrote:
> On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote:
>> This was sort of annoying me:
>>
>> random:~$ dmesg | tail -1
>> [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
>> random:~$ dmesg | grep -c "Reducing the compressed"
>> 47
>>
>> This patch makes it DRM_INFO_ONCE() just like the similar message
>> farther down in that function is pr_info_once().
>>
>> Signed-off-by: Peter Jones <pjones@redhat.com>
>> ---
>>  drivers/gpu/drm/i915/intel_fbc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
>> index b431b6733cc..88b013758da 100644
>> --- a/drivers/gpu/drm/i915/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/intel_fbc.c
>> @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
>>  	if (!ret)
>>  		goto err_llb;
>>  	else if (ret > 1) {
>> -		DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
>> +		DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
> 
> I know the feeling of seeing a message over and over again when you are already aware of that.
> Specially something that tells you to change BIOS configuration...
> for this reason I think it makes sense, so:
> 
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> I will just wait for CI and give a couple days to someone else to challenge.
> If I end up forgetting to push it please ping me...

After almost two years, ping :).

> 
>>  
>>  	}
>>  
>> -- 
>> 2.17.1

thanks,
-- 
js

Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Jiri Slaby]

On 06. 07. 18, 22:30, Rodrigo Vivi wrote:
> On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote:
>> This was sort of annoying me:
>>
>> random:~$ dmesg | tail -1
>> [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
>> random:~$ dmesg | grep -c "Reducing the compressed"
>> 47
>>
>> This patch makes it DRM_INFO_ONCE() just like the similar message
>> farther down in that function is pr_info_once().
>>
>> Signed-off-by: Peter Jones <pjones@redhat.com>
>> ---
>>  drivers/gpu/drm/i915/intel_fbc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
>> index b431b6733cc..88b013758da 100644
>> --- a/drivers/gpu/drm/i915/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/intel_fbc.c
>> @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
>>  	if (!ret)
>>  		goto err_llb;
>>  	else if (ret > 1) {
>> -		DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
>> +		DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
> 
> I know the feeling of seeing a message over and over again when you are already aware of that.
> Specially something that tells you to change BIOS configuration...
> for this reason I think it makes sense, so:
> 
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> I will just wait for CI and give a couple days to someone else to challenge.
> If I end up forgetting to push it please ping me...

After almost two years, ping :).

> 
>>  
>>  	}
>>  
>> -- 
>> 2.17.1

thanks,
-- 
js
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

[Jiri Slaby]

On 06. 07. 18, 22:30, Rodrigo Vivi wrote:
> On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote:
>> This was sort of annoying me:
>>
>> random:~$ dmesg | tail -1
>> [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
>> random:~$ dmesg | grep -c "Reducing the compressed"
>> 47
>>
>> This patch makes it DRM_INFO_ONCE() just like the similar message
>> farther down in that function is pr_info_once().
>>
>> Signed-off-by: Peter Jones <pjones@redhat.com>
>> ---
>>  drivers/gpu/drm/i915/intel_fbc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
>> index b431b6733cc..88b013758da 100644
>> --- a/drivers/gpu/drm/i915/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/intel_fbc.c
>> @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
>>  	if (!ret)
>>  		goto err_llb;
>>  	else if (ret > 1) {
>> -		DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
>> +		DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
> 
> I know the feeling of seeing a message over and over again when you are already aware of that.
> Specially something that tells you to change BIOS configuration...
> for this reason I think it makes sense, so:
> 
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> I will just wait for CI and give a couple days to someone else to challenge.
> If I end up forgetting to push it please ping me...

After almost two years, ping :).

> 
>>  
>>  	}
>>  
>> -- 
>> 2.17.1

thanks,
-- 
js
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx