All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: haibo.chen@nxp.com, peng.fan@nxp.com, jh80.chung@samsung.com,
	festevam@gmail.com, sean.anderson@seco.com, u-boot@lists.denx.de,
	aford173@gmail.com, tharvey@gateworks.com,
	andrey.zhizhikin@leica-geosystems.com
Cc: uboot-imx@nxp.com
Subject: Re: [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary
Date: Sun, 13 Feb 2022 22:52:30 +0100	[thread overview]
Message-ID: <37f43a37-4286-1a74-b99b-d6dbb489ec99@denx.de> (raw)
In-Reply-To: <1644578217-8947-1-git-send-email-haibo.chen@nxp.com>

On 2/11/22 12:16, haibo.chen@nxp.com wrote:

Hi,

[...]

> @@ -897,6 +900,11 @@ static int fsl_esdhc_execute_tuning(struct udevice *dev, uint32_t opcode)
>   
>   	esdhc_stop_tuning(mmc);
>   
> +	/* change to default setting, let host control the card clock */
> +	esdhc_clrbits32(&regs->vendorspec, VENDORSPEC_FRC_SDCLK_ON);
> +	if (readx_poll_timeout(esdhc_read32, &regs->prsstat, tmp, tmp & PRSSTAT_SDOFF, 100))

Please propagate the error in both cases:

ret = readx_poll..();
if (ret)
   dev_warn(...);

return ret;

> +		pr_warn("fsl_esdhc_imx: card clock not gate off as expect.\n");

btw. s@gate@gated@ , s@expect@expected@ (past tense)

With those small details fixed:

Reviewed-by: Marek Vasut <marex@denx.de>

  parent reply	other threads:[~2022-02-13 21:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 11:16 [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary haibo.chen
2022-02-11 11:16 ` [PATCH 2/3] mmc: fsl_esdhc_imx: remove redundant ARCH_MXC haibo.chen
2022-02-13 21:53   ` Marek Vasut
2022-02-19 13:07   ` sbabic
2022-02-11 11:16 ` [PATCH 3/3] mmc: fsl_esdhc_imx: correct the actual card clock haibo.chen
2022-02-13 21:54   ` Marek Vasut
2022-02-19 13:08   ` sbabic
2022-07-23  2:23   ` Tim Harvey
2022-07-27 12:44     ` Bough Chen
2022-02-13 21:52 ` Marek Vasut [this message]
2022-02-14  2:58   ` [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary Bough Chen
2022-02-17  0:15     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37f43a37-4286-1a74-b99b-d6dbb489ec99@denx.de \
    --to=marex@denx.de \
    --cc=aford173@gmail.com \
    --cc=andrey.zhizhikin@leica-geosystems.com \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=sean.anderson@seco.com \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.