All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Martin Lau <kafai@fb.com>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH net] route: Avoid crash from dereferencing NULL rt->from
Date: Mon, 15 Apr 2019 13:16:00 -0600	[thread overview]
Message-ID: <37ff4eb2-d791-a0f8-0196-a99b4f232f63@gmail.com> (raw)
In-Reply-To: <20190415161741.wcczleioxzauz266@kafai-mbp.dhcp.thefacebook.com>

On 4/15/19 10:17 AM, Martin Lau wrote:
> Hi David,  is similar check also needed in rt6_do_redirect() and
> inet6_rtm_getroute()?

good question. I think both could be returning an rt6_info from the
exception cache so yes they should have a similar check.


  reply	other threads:[~2019-04-15 19:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 21:21 [PATCH net] route: Avoid crash from dereferencing NULL rt->from Jonathan Lemon
2019-04-14 22:29 ` Eric Dumazet
2019-04-15 16:17   ` Martin Lau
2019-04-15 19:16     ` David Ahern [this message]
2019-04-15  0:38 ` David Ahern
2019-04-15 15:36 ` Martin Lau
2019-04-15 20:35 ` David Miller
2019-04-22  0:17 ` [route] 3be5fb4873: INFO:rcu_sched_self-detected_stall_on_CPU kernel test robot
2019-04-22  0:17   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37ff4eb2-d791-a0f8-0196-a99b4f232f63@gmail.com \
    --to=dsahern@gmail.com \
    --cc=Kernel-team@fb.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.