All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Move target_signal.h generic definitions to generic/signal.h
@ 2021-11-26  2:23 Song Gao
  2021-11-26  2:23 ` [PATCH v2 1/3] linux-user: " Song Gao
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Song Gao @ 2021-11-26  2:23 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.bennee, richard.henderson, laurent, f4bug

Hi all,

This seris:
 - Move target_signal.h generic defintions to generic/signal.h, 
 - target_syscall.h remove TARGET_MINSIGSTKSZ
 - Remove unused definitions TARGET_SIGSTKSZ.

Song Gao (3):
  linux-user: Move target_signal.h generic definitions to
    generic/signal.h
  linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ
  linux-user: Remove TARGET_SIGSTKSZ

 linux-user/aarch64/target_signal.h     | 18 ------------------
 linux-user/aarch64/target_syscall.h    |  1 -
 linux-user/alpha/target_signal.h       |  1 -
 linux-user/alpha/target_syscall.h      |  1 -
 linux-user/arm/target_signal.h         | 18 ------------------
 linux-user/arm/target_syscall.h        |  1 -
 linux-user/cris/target_signal.h        | 18 ------------------
 linux-user/cris/target_syscall.h       |  1 -
 linux-user/generic/signal.h            | 15 +++++++++++++++
 linux-user/hexagon/target_signal.h     | 11 -----------
 linux-user/hppa/target_signal.h        |  1 -
 linux-user/hppa/target_syscall.h       |  1 -
 linux-user/i386/target_signal.h        | 18 ------------------
 linux-user/i386/target_syscall.h       |  1 -
 linux-user/m68k/target_signal.h        | 18 ------------------
 linux-user/m68k/target_syscall.h       |  1 -
 linux-user/microblaze/target_signal.h  | 18 ------------------
 linux-user/microblaze/target_syscall.h |  1 -
 linux-user/mips/target_signal.h        |  1 -
 linux-user/mips/target_syscall.h       |  1 -
 linux-user/mips64/target_signal.h      |  1 -
 linux-user/mips64/target_syscall.h     |  1 -
 linux-user/nios2/target_signal.h       | 16 ----------------
 linux-user/nios2/target_syscall.h      |  1 -
 linux-user/openrisc/target_signal.h    | 23 -----------------------
 linux-user/openrisc/target_syscall.h   |  1 -
 linux-user/ppc/target_signal.h         | 18 ------------------
 linux-user/ppc/target_syscall.h        |  1 -
 linux-user/riscv/target_signal.h       | 12 ------------
 linux-user/riscv/target_syscall.h      |  1 -
 linux-user/s390x/target_signal.h       | 15 ---------------
 linux-user/s390x/target_syscall.h      |  1 -
 linux-user/sh4/target_signal.h         | 18 ------------------
 linux-user/sh4/target_syscall.h        |  1 -
 linux-user/sparc/target_signal.h       |  1 -
 linux-user/sparc/target_syscall.h      |  1 -
 linux-user/x86_64/target_signal.h      | 18 ------------------
 linux-user/x86_64/target_syscall.h     |  1 -
 linux-user/xtensa/target_signal.h      | 17 -----------------
 39 files changed, 15 insertions(+), 279 deletions(-)

-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/3] linux-user: Move target_signal.h generic definitions to generic/signal.h
  2021-11-26  2:23 [PATCH v2 0/3] Move target_signal.h generic definitions to generic/signal.h Song Gao
@ 2021-11-26  2:23 ` Song Gao
  2021-11-26 10:47   ` Richard Henderson
  2021-12-20 15:56   ` Laurent Vivier
  2021-11-26  2:23 ` [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ Song Gao
  2021-11-26  2:23 ` [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ Song Gao
  2 siblings, 2 replies; 10+ messages in thread
From: Song Gao @ 2021-11-26  2:23 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.bennee, richard.henderson, laurent, f4bug

No code change

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Song Gao <gaosong@loongson.cn>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/aarch64/target_signal.h    | 18 ------------------
 linux-user/arm/target_signal.h        | 18 ------------------
 linux-user/cris/target_signal.h       | 18 ------------------
 linux-user/generic/signal.h           | 16 ++++++++++++++++
 linux-user/hexagon/target_signal.h    | 11 -----------
 linux-user/i386/target_signal.h       | 18 ------------------
 linux-user/m68k/target_signal.h       | 18 ------------------
 linux-user/microblaze/target_signal.h | 18 ------------------
 linux-user/nios2/target_signal.h      | 16 ----------------
 linux-user/openrisc/target_signal.h   | 23 -----------------------
 linux-user/ppc/target_signal.h        | 18 ------------------
 linux-user/riscv/target_signal.h      | 12 ------------
 linux-user/s390x/target_signal.h      | 15 ---------------
 linux-user/sh4/target_signal.h        | 18 ------------------
 linux-user/x86_64/target_signal.h     | 18 ------------------
 linux-user/xtensa/target_signal.h     | 17 -----------------
 16 files changed, 16 insertions(+), 256 deletions(-)

diff --git a/linux-user/aarch64/target_signal.h b/linux-user/aarch64/target_signal.h
index 7580d99..40e399d 100644
--- a/linux-user/aarch64/target_signal.h
+++ b/linux-user/aarch64/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef AARCH64_TARGET_SIGNAL_H
 #define AARCH64_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK 1
-#define TARGET_SS_DISABLE 2
-
-#define TARGET_MINSIGSTKSZ 2048
-#define TARGET_SIGSTKSZ 8192
-
 #include "../generic/signal.h"
 
 #define TARGET_SEGV_MTEAERR  8  /* Asynchronous ARM MTE error */
diff --git a/linux-user/arm/target_signal.h b/linux-user/arm/target_signal.h
index 1e7fb0c..0e6351d 100644
--- a/linux-user/arm/target_signal.h
+++ b/linux-user/arm/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef ARM_TARGET_SIGNAL_H
 #define ARM_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK	1
-#define TARGET_SS_DISABLE	2
-
-#define TARGET_MINSIGSTKSZ	2048
-#define TARGET_SIGSTKSZ		8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/cris/target_signal.h b/linux-user/cris/target_signal.h
index 83a5155..ab0653f 100644
--- a/linux-user/cris/target_signal.h
+++ b/linux-user/cris/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef CRIS_TARGET_SIGNAL_H
 #define CRIS_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/generic/signal.h b/linux-user/generic/signal.h
index 943bc1a..ceaf8a8 100644
--- a/linux-user/generic/signal.h
+++ b/linux-user/generic/signal.h
@@ -55,6 +55,22 @@
 #define TARGET_SIG_UNBLOCK        1    /* for unblocking signals */
 #define TARGET_SIG_SETMASK        2    /* for setting the signal mask */
 
+/* this struct defines a stack used during syscall handling */
+typedef struct target_sigaltstack {
+    abi_ulong ss_sp;
+    abi_int ss_flags;
+    abi_ulong ss_size;
+} target_stack_t;
+
+/*
+ * sigaltstack controls
+ */
+#define TARGET_SS_ONSTACK 1
+#define TARGET_SS_DISABLE 2
+
+#define TARGET_MINSIGSTKSZ     2048
+#define TARGET_SIGSTKSZ        8192
+
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
 /* mask for all SS_xxx flags */
diff --git a/linux-user/hexagon/target_signal.h b/linux-user/hexagon/target_signal.h
index 9e0223d..193abac 100644
--- a/linux-user/hexagon/target_signal.h
+++ b/linux-user/hexagon/target_signal.h
@@ -18,17 +18,6 @@
 #ifndef HEXAGON_TARGET_SIGNAL_H
 #define HEXAGON_TARGET_SIGNAL_H
 
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-#define TARGET_SS_ONSTACK 1
-#define TARGET_SS_DISABLE 2
-
-#define TARGET_MINSIGSTKSZ 2048
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
diff --git a/linux-user/i386/target_signal.h b/linux-user/i386/target_signal.h
index 64d09f2..9315cba 100644
--- a/linux-user/i386/target_signal.h
+++ b/linux-user/i386/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef I386_TARGET_SIGNAL_H
 #define I386_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK	1
-#define TARGET_SS_DISABLE	2
-
-#define TARGET_MINSIGSTKSZ	2048
-#define TARGET_SIGSTKSZ		8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/m68k/target_signal.h b/linux-user/m68k/target_signal.h
index 94157bf..6e0f4b7 100644
--- a/linux-user/m68k/target_signal.h
+++ b/linux-user/m68k/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef M68K_TARGET_SIGNAL_H
 #define M68K_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK	1
-#define TARGET_SS_DISABLE	2
-
-#define TARGET_MINSIGSTKSZ	2048
-#define TARGET_SIGSTKSZ	8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/microblaze/target_signal.h b/linux-user/microblaze/target_signal.h
index e8b510f..7dc5c45 100644
--- a/linux-user/microblaze/target_signal.h
+++ b/linux-user/microblaze/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef MICROBLAZE_TARGET_SIGNAL_H
 #define MICROBLAZE_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
diff --git a/linux-user/nios2/target_signal.h b/linux-user/nios2/target_signal.h
index fe266c4..46ca594 100644
--- a/linux-user/nios2/target_signal.h
+++ b/linux-user/nios2/target_signal.h
@@ -1,22 +1,6 @@
 #ifndef NIOS2_TARGET_SIGNAL_H
 #define NIOS2_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/* sigaltstack controls  */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 /* Nios2 uses a fixed address on the kuser page for sigreturn. */
diff --git a/linux-user/openrisc/target_signal.h b/linux-user/openrisc/target_signal.h
index 077ec3d..5b9d409 100644
--- a/linux-user/openrisc/target_signal.h
+++ b/linux-user/openrisc/target_signal.h
@@ -1,29 +1,6 @@
 #ifndef OPENRISC_TARGET_SIGNAL_H
 #define OPENRISC_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_long ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-/* sigaltstack controls  */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_SA_NOCLDSTOP    0x00000001
-#define TARGET_SA_NOCLDWAIT    0x00000002
-#define TARGET_SA_SIGINFO      0x00000004
-#define TARGET_SA_ONSTACK      0x08000000
-#define TARGET_SA_RESTART      0x10000000
-#define TARGET_SA_NODEFER      0x40000000
-#define TARGET_SA_RESETHAND    0x80000000
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
diff --git a/linux-user/ppc/target_signal.h b/linux-user/ppc/target_signal.h
index 82184ab..5be24e1 100644
--- a/linux-user/ppc/target_signal.h
+++ b/linux-user/ppc/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef PPC_TARGET_SIGNAL_H
 #define PPC_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 #if !defined(TARGET_PPC64)
diff --git a/linux-user/riscv/target_signal.h b/linux-user/riscv/target_signal.h
index 3e36fdd..6c0470f 100644
--- a/linux-user/riscv/target_signal.h
+++ b/linux-user/riscv/target_signal.h
@@ -1,18 +1,6 @@
 #ifndef RISCV_TARGET_SIGNAL_H
 #define RISCV_TARGET_SIGNAL_H
 
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-#define TARGET_SS_ONSTACK 1
-#define TARGET_SS_DISABLE 2
-
-#define TARGET_MINSIGSTKSZ 2048
-#define TARGET_SIGSTKSZ 8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
diff --git a/linux-user/s390x/target_signal.h b/linux-user/s390x/target_signal.h
index 64f5f42..41e0e34 100644
--- a/linux-user/s390x/target_signal.h
+++ b/linux-user/s390x/target_signal.h
@@ -1,21 +1,6 @@
 #ifndef S390X_TARGET_SIGNAL_H
 #define S390X_TARGET_SIGNAL_H
 
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK      1
-#define TARGET_SS_DISABLE      2
-
-#define TARGET_MINSIGSTKSZ     2048
-#define TARGET_SIGSTKSZ        8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/sh4/target_signal.h b/linux-user/sh4/target_signal.h
index 04069cb..eee6a1a 100644
--- a/linux-user/sh4/target_signal.h
+++ b/linux-user/sh4/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef SH4_TARGET_SIGNAL_H
 #define SH4_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/x86_64/target_signal.h b/linux-user/x86_64/target_signal.h
index 4673c5a..9d97174 100644
--- a/linux-user/x86_64/target_signal.h
+++ b/linux-user/x86_64/target_signal.h
@@ -1,24 +1,6 @@
 #ifndef X86_64_TARGET_SIGNAL_H
 #define X86_64_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK	1
-#define TARGET_SS_DISABLE	2
-
-#define TARGET_MINSIGSTKSZ	2048
-#define TARGET_SIGSTKSZ		8192
-
 #include "../generic/signal.h"
 
 /* For x86_64, use of SA_RESTORER is mandatory. */
diff --git a/linux-user/xtensa/target_signal.h b/linux-user/xtensa/target_signal.h
index 1c7ee73..e4b1bea 100644
--- a/linux-user/xtensa/target_signal.h
+++ b/linux-user/xtensa/target_signal.h
@@ -1,23 +1,6 @@
 #ifndef XTENSA_TARGET_SIGNAL_H
 #define XTENSA_TARGET_SIGNAL_H
 
-/* this struct defines a stack used during syscall handling */
-
-typedef struct target_sigaltstack {
-    abi_ulong ss_sp;
-    abi_int ss_flags;
-    abi_ulong ss_size;
-} target_stack_t;
-
-/*
- * sigaltstack controls
- */
-#define TARGET_SS_ONSTACK     1
-#define TARGET_SS_DISABLE     2
-
-#define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
-
 #include "../generic/signal.h"
 
 #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ
  2021-11-26  2:23 [PATCH v2 0/3] Move target_signal.h generic definitions to generic/signal.h Song Gao
  2021-11-26  2:23 ` [PATCH v2 1/3] linux-user: " Song Gao
@ 2021-11-26  2:23 ` Song Gao
  2021-11-26 10:48   ` Richard Henderson
  2021-12-20 15:56   ` Laurent Vivier
  2021-11-26  2:23 ` [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ Song Gao
  2 siblings, 2 replies; 10+ messages in thread
From: Song Gao @ 2021-11-26  2:23 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.bennee, richard.henderson, laurent, f4bug

TARGET_MINSIGSTKSZ has been defined in generic/signal.h
or target_signal.h, We don't need to define it again.

Signed-off-by: Song Gao <gaosong@loongson.cn>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 linux-user/aarch64/target_syscall.h    | 1 -
 linux-user/alpha/target_syscall.h      | 1 -
 linux-user/arm/target_syscall.h        | 1 -
 linux-user/cris/target_syscall.h       | 1 -
 linux-user/hppa/target_syscall.h       | 1 -
 linux-user/i386/target_syscall.h       | 1 -
 linux-user/m68k/target_syscall.h       | 1 -
 linux-user/microblaze/target_syscall.h | 1 -
 linux-user/mips/target_syscall.h       | 1 -
 linux-user/mips64/target_syscall.h     | 1 -
 linux-user/nios2/target_syscall.h      | 1 -
 linux-user/openrisc/target_syscall.h   | 1 -
 linux-user/ppc/target_syscall.h        | 1 -
 linux-user/riscv/target_syscall.h      | 1 -
 linux-user/s390x/target_syscall.h      | 1 -
 linux-user/sh4/target_syscall.h        | 1 -
 linux-user/sparc/target_syscall.h      | 1 -
 linux-user/x86_64/target_syscall.h     | 1 -
 18 files changed, 18 deletions(-)

diff --git a/linux-user/aarch64/target_syscall.h b/linux-user/aarch64/target_syscall.h
index 76f6c33..508219d 100644
--- a/linux-user/aarch64/target_syscall.h
+++ b/linux-user/aarch64/target_syscall.h
@@ -15,7 +15,6 @@ struct target_pt_regs {
 #endif
 #define UNAME_MINIMUM_RELEASE "3.8.0"
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ       2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/alpha/target_syscall.h b/linux-user/alpha/target_syscall.h
index 03091bf..fda3a49 100644
--- a/linux-user/alpha/target_syscall.h
+++ b/linux-user/alpha/target_syscall.h
@@ -63,7 +63,6 @@ struct target_pt_regs {
 #define TARGET_UAC_NOPRINT		1
 #define TARGET_UAC_NOFIX		2
 #define TARGET_UAC_SIGBUS		4
-#define TARGET_MINSIGSTKSZ              4096
 #define TARGET_MCL_CURRENT     0x2000
 #define TARGET_MCL_FUTURE      0x4000
 #define TARGET_MCL_ONFAULT     0x8000
diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h
index e870ed7..f04f9c9 100644
--- a/linux-user/arm/target_syscall.h
+++ b/linux-user/arm/target_syscall.h
@@ -27,7 +27,6 @@ struct target_pt_regs {
 
 #define TARGET_CLONE_BACKWARDS
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/cris/target_syscall.h b/linux-user/cris/target_syscall.h
index 19e1281..0b5ebf1 100644
--- a/linux-user/cris/target_syscall.h
+++ b/linux-user/cris/target_syscall.h
@@ -39,7 +39,6 @@ struct target_pt_regs {
 };
 
 #define TARGET_CLONE_BACKWARDS2
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/hppa/target_syscall.h b/linux-user/hppa/target_syscall.h
index 0018bcb..4b382c1 100644
--- a/linux-user/hppa/target_syscall.h
+++ b/linux-user/hppa/target_syscall.h
@@ -22,7 +22,6 @@ struct target_pt_regs {
 #define UNAME_MACHINE "parisc"
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ       2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/i386/target_syscall.h b/linux-user/i386/target_syscall.h
index ed356b3..aaade06 100644
--- a/linux-user/i386/target_syscall.h
+++ b/linux-user/i386/target_syscall.h
@@ -150,7 +150,6 @@ struct target_vm86plus_struct {
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/m68k/target_syscall.h b/linux-user/m68k/target_syscall.h
index 23359a6..8d4ddbd 100644
--- a/linux-user/m68k/target_syscall.h
+++ b/linux-user/m68k/target_syscall.h
@@ -20,7 +20,6 @@ struct target_pt_regs {
 #define UNAME_MACHINE "m68k"
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/microblaze/target_syscall.h b/linux-user/microblaze/target_syscall.h
index 7f653db..43362a1 100644
--- a/linux-user/microblaze/target_syscall.h
+++ b/linux-user/microblaze/target_syscall.h
@@ -49,7 +49,6 @@ struct target_pt_regs {
 };
 
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ      2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/mips/target_syscall.h b/linux-user/mips/target_syscall.h
index f590574..7a82661 100644
--- a/linux-user/mips/target_syscall.h
+++ b/linux-user/mips/target_syscall.h
@@ -24,7 +24,6 @@ struct target_pt_regs {
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/mips64/target_syscall.h b/linux-user/mips64/target_syscall.h
index cd1e1b4..2c7a881 100644
--- a/linux-user/mips64/target_syscall.h
+++ b/linux-user/mips64/target_syscall.h
@@ -21,7 +21,6 @@ struct target_pt_regs {
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ      2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/nios2/target_syscall.h b/linux-user/nios2/target_syscall.h
index 78006c2..561b28d 100644
--- a/linux-user/nios2/target_syscall.h
+++ b/linux-user/nios2/target_syscall.h
@@ -30,7 +30,6 @@ struct target_pt_regs {
     unsigned long  orig_r7;
 };
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/openrisc/target_syscall.h b/linux-user/openrisc/target_syscall.h
index ef0d89a..7fe5b73 100644
--- a/linux-user/openrisc/target_syscall.h
+++ b/linux-user/openrisc/target_syscall.h
@@ -15,7 +15,6 @@ struct target_pt_regs {
 #define UNAME_MACHINE "openrisc"
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/ppc/target_syscall.h b/linux-user/ppc/target_syscall.h
index b9c4b81..8b36469 100644
--- a/linux-user/ppc/target_syscall.h
+++ b/linux-user/ppc/target_syscall.h
@@ -71,7 +71,6 @@ struct target_revectored_struct {
 
 #define TARGET_CLONE_BACKWARDS
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 0x2000
 #define TARGET_MCL_FUTURE  0x4000
 #define TARGET_MCL_ONFAULT 0x8000
diff --git a/linux-user/riscv/target_syscall.h b/linux-user/riscv/target_syscall.h
index dc597c8..8d4b372 100644
--- a/linux-user/riscv/target_syscall.h
+++ b/linux-user/riscv/target_syscall.h
@@ -50,7 +50,6 @@ struct target_pt_regs {
 #endif
 #define UNAME_MINIMUM_RELEASE "4.15.0"
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/s390x/target_syscall.h b/linux-user/s390x/target_syscall.h
index 94f8417..4018988 100644
--- a/linux-user/s390x/target_syscall.h
+++ b/linux-user/s390x/target_syscall.h
@@ -27,7 +27,6 @@ struct target_pt_regs {
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
 #define TARGET_CLONE_BACKWARDS2
-#define TARGET_MINSIGSTKSZ        2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/sh4/target_syscall.h b/linux-user/sh4/target_syscall.h
index c1437ad..1483988 100644
--- a/linux-user/sh4/target_syscall.h
+++ b/linux-user/sh4/target_syscall.h
@@ -15,7 +15,6 @@ struct target_pt_regs {
 #define UNAME_MACHINE "sh4"
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
diff --git a/linux-user/sparc/target_syscall.h b/linux-user/sparc/target_syscall.h
index 087b39d..be77e44 100644
--- a/linux-user/sparc/target_syscall.h
+++ b/linux-user/sparc/target_syscall.h
@@ -34,7 +34,6 @@ struct target_pt_regs {
  * and copy_thread().
  */
 #define TARGET_CLONE_BACKWARDS
-#define TARGET_MINSIGSTKSZ      4096
 #define TARGET_MCL_CURRENT 0x2000
 #define TARGET_MCL_FUTURE  0x4000
 #define TARGET_MCL_ONFAULT 0x8000
diff --git a/linux-user/x86_64/target_syscall.h b/linux-user/x86_64/target_syscall.h
index 3ecccb7..fb55834 100644
--- a/linux-user/x86_64/target_syscall.h
+++ b/linux-user/x86_64/target_syscall.h
@@ -100,7 +100,6 @@ struct target_msqid64_ds {
 #define TARGET_ARCH_SET_FS 0x1002
 #define TARGET_ARCH_GET_FS 0x1003
 #define TARGET_ARCH_GET_GS 0x1004
-#define TARGET_MINSIGSTKSZ 2048
 #define TARGET_MCL_CURRENT 1
 #define TARGET_MCL_FUTURE  2
 #define TARGET_MCL_ONFAULT 4
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ
  2021-11-26  2:23 [PATCH v2 0/3] Move target_signal.h generic definitions to generic/signal.h Song Gao
  2021-11-26  2:23 ` [PATCH v2 1/3] linux-user: " Song Gao
  2021-11-26  2:23 ` [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ Song Gao
@ 2021-11-26  2:23 ` Song Gao
  2021-11-26 10:48   ` Richard Henderson
  2021-12-20 15:56   ` Laurent Vivier
  2 siblings, 2 replies; 10+ messages in thread
From: Song Gao @ 2021-11-26  2:23 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.bennee, richard.henderson, laurent, f4bug

TARGET_SIGSTKSZ is not used, we should remove it.

Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 linux-user/alpha/target_signal.h  | 1 -
 linux-user/generic/signal.h       | 1 -
 linux-user/hppa/target_signal.h   | 1 -
 linux-user/mips/target_signal.h   | 1 -
 linux-user/mips64/target_signal.h | 1 -
 linux-user/sparc/target_signal.h  | 1 -
 6 files changed, 6 deletions(-)

diff --git a/linux-user/alpha/target_signal.h b/linux-user/alpha/target_signal.h
index 0b6a39d..bbb06e5 100644
--- a/linux-user/alpha/target_signal.h
+++ b/linux-user/alpha/target_signal.h
@@ -62,7 +62,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_SIGINFO       0x00000040
 
 #define TARGET_MINSIGSTKSZ	4096
-#define TARGET_SIGSTKSZ		16384
 
 /* From <asm/gentrap.h>.  */
 #define TARGET_GEN_INTOVF      -1      /* integer overflow */
diff --git a/linux-user/generic/signal.h b/linux-user/generic/signal.h
index ceaf8a8..6fd05b7 100644
--- a/linux-user/generic/signal.h
+++ b/linux-user/generic/signal.h
@@ -69,7 +69,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SS_DISABLE 2
 
 #define TARGET_MINSIGSTKSZ     2048
-#define TARGET_SIGSTKSZ        8192
 
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h
index d558119..af6c2fc 100644
--- a/linux-user/hppa/target_signal.h
+++ b/linux-user/hppa/target_signal.h
@@ -64,7 +64,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_NOCLDWAIT     0x00000080
 
 #define TARGET_MINSIGSTKSZ	2048
-#define TARGET_SIGSTKSZ		8192
 
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
diff --git a/linux-user/mips/target_signal.h b/linux-user/mips/target_signal.h
index 780a4dd..fa542c1 100644
--- a/linux-user/mips/target_signal.h
+++ b/linux-user/mips/target_signal.h
@@ -67,7 +67,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_RESTORER      0x04000000      /* Only for O32 */
 
 #define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
 
 #if defined(TARGET_ABI_MIPSO32)
 /* compare linux/arch/mips/kernel/signal.c:setup_frame() */
diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h
index 275e9b7..b05098f 100644
--- a/linux-user/mips64/target_signal.h
+++ b/linux-user/mips64/target_signal.h
@@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_RESETHAND     0x80000000
 
 #define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
 
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
diff --git a/linux-user/sparc/target_signal.h b/linux-user/sparc/target_signal.h
index e661ddd..87757f0 100644
--- a/linux-user/sparc/target_signal.h
+++ b/linux-user/sparc/target_signal.h
@@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
 #define TARGET_ARCH_HAS_KA_RESTORER 1
 
 #define TARGET_MINSIGSTKSZ	4096
-#define TARGET_SIGSTKSZ		16384
 
 #ifdef TARGET_ABI32
 #define TARGET_ARCH_HAS_SETUP_FRAME
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] linux-user: Move target_signal.h generic definitions to generic/signal.h
  2021-11-26  2:23 ` [PATCH v2 1/3] linux-user: " Song Gao
@ 2021-11-26 10:47   ` Richard Henderson
  2021-12-20 15:56   ` Laurent Vivier
  1 sibling, 0 replies; 10+ messages in thread
From: Richard Henderson @ 2021-11-26 10:47 UTC (permalink / raw)
  To: Song Gao, qemu-devel; +Cc: alex.bennee, laurent, f4bug

On 11/26/21 3:23 AM, Song Gao wrote:
> No code change
> 
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> Reviewed-by: Laurent Vivier<laurent@vivier.eu>
> ---
>   linux-user/aarch64/target_signal.h    | 18 ------------------
>   linux-user/arm/target_signal.h        | 18 ------------------
>   linux-user/cris/target_signal.h       | 18 ------------------
>   linux-user/generic/signal.h           | 16 ++++++++++++++++
>   linux-user/hexagon/target_signal.h    | 11 -----------
>   linux-user/i386/target_signal.h       | 18 ------------------
>   linux-user/m68k/target_signal.h       | 18 ------------------
>   linux-user/microblaze/target_signal.h | 18 ------------------
>   linux-user/nios2/target_signal.h      | 16 ----------------
>   linux-user/openrisc/target_signal.h   | 23 -----------------------
>   linux-user/ppc/target_signal.h        | 18 ------------------
>   linux-user/riscv/target_signal.h      | 12 ------------
>   linux-user/s390x/target_signal.h      | 15 ---------------
>   linux-user/sh4/target_signal.h        | 18 ------------------
>   linux-user/x86_64/target_signal.h     | 18 ------------------
>   linux-user/xtensa/target_signal.h     | 17 -----------------
>   16 files changed, 16 insertions(+), 256 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ
  2021-11-26  2:23 ` [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ Song Gao
@ 2021-11-26 10:48   ` Richard Henderson
  2021-12-20 15:56   ` Laurent Vivier
  1 sibling, 0 replies; 10+ messages in thread
From: Richard Henderson @ 2021-11-26 10:48 UTC (permalink / raw)
  To: Song Gao, qemu-devel; +Cc: alex.bennee, laurent, f4bug

On 11/26/21 3:23 AM, Song Gao wrote:
> TARGET_MINSIGSTKSZ has been defined in generic/signal.h
> or target_signal.h, We don't need to define it again.
> 
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> Reviewed-by: Laurent Vivier<laurent@vivier.eu>
> Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   linux-user/aarch64/target_syscall.h    | 1 -
>   linux-user/alpha/target_syscall.h      | 1 -
>   linux-user/arm/target_syscall.h        | 1 -
>   linux-user/cris/target_syscall.h       | 1 -
>   linux-user/hppa/target_syscall.h       | 1 -
>   linux-user/i386/target_syscall.h       | 1 -
>   linux-user/m68k/target_syscall.h       | 1 -
>   linux-user/microblaze/target_syscall.h | 1 -
>   linux-user/mips/target_syscall.h       | 1 -
>   linux-user/mips64/target_syscall.h     | 1 -
>   linux-user/nios2/target_syscall.h      | 1 -
>   linux-user/openrisc/target_syscall.h   | 1 -
>   linux-user/ppc/target_syscall.h        | 1 -
>   linux-user/riscv/target_syscall.h      | 1 -
>   linux-user/s390x/target_syscall.h      | 1 -
>   linux-user/sh4/target_syscall.h        | 1 -
>   linux-user/sparc/target_syscall.h      | 1 -
>   linux-user/x86_64/target_syscall.h     | 1 -
>   18 files changed, 18 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ
  2021-11-26  2:23 ` [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ Song Gao
@ 2021-11-26 10:48   ` Richard Henderson
  2021-12-20 15:56   ` Laurent Vivier
  1 sibling, 0 replies; 10+ messages in thread
From: Richard Henderson @ 2021-11-26 10:48 UTC (permalink / raw)
  To: Song Gao, qemu-devel; +Cc: alex.bennee, laurent, f4bug

On 11/26/21 3:23 AM, Song Gao wrote:
> TARGET_SIGSTKSZ is not used, we should remove it.
> 
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> ---
>   linux-user/alpha/target_signal.h  | 1 -
>   linux-user/generic/signal.h       | 1 -
>   linux-user/hppa/target_signal.h   | 1 -
>   linux-user/mips/target_signal.h   | 1 -
>   linux-user/mips64/target_signal.h | 1 -
>   linux-user/sparc/target_signal.h  | 1 -
>   6 files changed, 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] linux-user: Move target_signal.h generic definitions to generic/signal.h
  2021-11-26  2:23 ` [PATCH v2 1/3] linux-user: " Song Gao
  2021-11-26 10:47   ` Richard Henderson
@ 2021-12-20 15:56   ` Laurent Vivier
  1 sibling, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2021-12-20 15:56 UTC (permalink / raw)
  To: Song Gao, qemu-devel; +Cc: richard.henderson, alex.bennee, f4bug

Le 26/11/2021 à 03:23, Song Gao a écrit :
> No code change
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> ---
>   linux-user/aarch64/target_signal.h    | 18 ------------------
>   linux-user/arm/target_signal.h        | 18 ------------------
>   linux-user/cris/target_signal.h       | 18 ------------------
>   linux-user/generic/signal.h           | 16 ++++++++++++++++
>   linux-user/hexagon/target_signal.h    | 11 -----------
>   linux-user/i386/target_signal.h       | 18 ------------------
>   linux-user/m68k/target_signal.h       | 18 ------------------
>   linux-user/microblaze/target_signal.h | 18 ------------------
>   linux-user/nios2/target_signal.h      | 16 ----------------
>   linux-user/openrisc/target_signal.h   | 23 -----------------------
>   linux-user/ppc/target_signal.h        | 18 ------------------
>   linux-user/riscv/target_signal.h      | 12 ------------
>   linux-user/s390x/target_signal.h      | 15 ---------------
>   linux-user/sh4/target_signal.h        | 18 ------------------
>   linux-user/x86_64/target_signal.h     | 18 ------------------
>   linux-user/xtensa/target_signal.h     | 17 -----------------
>   16 files changed, 16 insertions(+), 256 deletions(-)
> 
> diff --git a/linux-user/aarch64/target_signal.h b/linux-user/aarch64/target_signal.h
> index 7580d99..40e399d 100644
> --- a/linux-user/aarch64/target_signal.h
> +++ b/linux-user/aarch64/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef AARCH64_TARGET_SIGNAL_H
>   #define AARCH64_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK 1
> -#define TARGET_SS_DISABLE 2
> -
> -#define TARGET_MINSIGSTKSZ 2048
> -#define TARGET_SIGSTKSZ 8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_SEGV_MTEAERR  8  /* Asynchronous ARM MTE error */
> diff --git a/linux-user/arm/target_signal.h b/linux-user/arm/target_signal.h
> index 1e7fb0c..0e6351d 100644
> --- a/linux-user/arm/target_signal.h
> +++ b/linux-user/arm/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef ARM_TARGET_SIGNAL_H
>   #define ARM_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK	1
> -#define TARGET_SS_DISABLE	2
> -
> -#define TARGET_MINSIGSTKSZ	2048
> -#define TARGET_SIGSTKSZ		8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SETUP_FRAME
> diff --git a/linux-user/cris/target_signal.h b/linux-user/cris/target_signal.h
> index 83a5155..ab0653f 100644
> --- a/linux-user/cris/target_signal.h
> +++ b/linux-user/cris/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef CRIS_TARGET_SIGNAL_H
>   #define CRIS_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SETUP_FRAME
> diff --git a/linux-user/generic/signal.h b/linux-user/generic/signal.h
> index 943bc1a..ceaf8a8 100644
> --- a/linux-user/generic/signal.h
> +++ b/linux-user/generic/signal.h
> @@ -55,6 +55,22 @@
>   #define TARGET_SIG_UNBLOCK        1    /* for unblocking signals */
>   #define TARGET_SIG_SETMASK        2    /* for setting the signal mask */
>   
> +/* this struct defines a stack used during syscall handling */
> +typedef struct target_sigaltstack {
> +    abi_ulong ss_sp;
> +    abi_int ss_flags;
> +    abi_ulong ss_size;
> +} target_stack_t;
> +
> +/*
> + * sigaltstack controls
> + */
> +#define TARGET_SS_ONSTACK 1
> +#define TARGET_SS_DISABLE 2
> +
> +#define TARGET_MINSIGSTKSZ     2048
> +#define TARGET_SIGSTKSZ        8192
> +
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
>   /* mask for all SS_xxx flags */
> diff --git a/linux-user/hexagon/target_signal.h b/linux-user/hexagon/target_signal.h
> index 9e0223d..193abac 100644
> --- a/linux-user/hexagon/target_signal.h
> +++ b/linux-user/hexagon/target_signal.h
> @@ -18,17 +18,6 @@
>   #ifndef HEXAGON_TARGET_SIGNAL_H
>   #define HEXAGON_TARGET_SIGNAL_H
>   
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -#define TARGET_SS_ONSTACK 1
> -#define TARGET_SS_DISABLE 2
> -
> -#define TARGET_MINSIGSTKSZ 2048
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
> diff --git a/linux-user/i386/target_signal.h b/linux-user/i386/target_signal.h
> index 64d09f2..9315cba 100644
> --- a/linux-user/i386/target_signal.h
> +++ b/linux-user/i386/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef I386_TARGET_SIGNAL_H
>   #define I386_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK	1
> -#define TARGET_SS_DISABLE	2
> -
> -#define TARGET_MINSIGSTKSZ	2048
> -#define TARGET_SIGSTKSZ		8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SETUP_FRAME
> diff --git a/linux-user/m68k/target_signal.h b/linux-user/m68k/target_signal.h
> index 94157bf..6e0f4b7 100644
> --- a/linux-user/m68k/target_signal.h
> +++ b/linux-user/m68k/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef M68K_TARGET_SIGNAL_H
>   #define M68K_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK	1
> -#define TARGET_SS_DISABLE	2
> -
> -#define TARGET_MINSIGSTKSZ	2048
> -#define TARGET_SIGSTKSZ	8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SETUP_FRAME
> diff --git a/linux-user/microblaze/target_signal.h b/linux-user/microblaze/target_signal.h
> index e8b510f..7dc5c45 100644
> --- a/linux-user/microblaze/target_signal.h
> +++ b/linux-user/microblaze/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef MICROBLAZE_TARGET_SIGNAL_H
>   #define MICROBLAZE_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
> diff --git a/linux-user/nios2/target_signal.h b/linux-user/nios2/target_signal.h
> index fe266c4..46ca594 100644
> --- a/linux-user/nios2/target_signal.h
> +++ b/linux-user/nios2/target_signal.h
> @@ -1,22 +1,6 @@
>   #ifndef NIOS2_TARGET_SIGNAL_H
>   #define NIOS2_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/* sigaltstack controls  */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   /* Nios2 uses a fixed address on the kuser page for sigreturn. */
> diff --git a/linux-user/openrisc/target_signal.h b/linux-user/openrisc/target_signal.h
> index 077ec3d..5b9d409 100644
> --- a/linux-user/openrisc/target_signal.h
> +++ b/linux-user/openrisc/target_signal.h
> @@ -1,29 +1,6 @@
>   #ifndef OPENRISC_TARGET_SIGNAL_H
>   #define OPENRISC_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_long ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -/* sigaltstack controls  */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_SA_NOCLDSTOP    0x00000001
> -#define TARGET_SA_NOCLDWAIT    0x00000002
> -#define TARGET_SA_SIGINFO      0x00000004
> -#define TARGET_SA_ONSTACK      0x08000000
> -#define TARGET_SA_RESTART      0x10000000
> -#define TARGET_SA_NODEFER      0x40000000
> -#define TARGET_SA_RESETHAND    0x80000000
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
> diff --git a/linux-user/ppc/target_signal.h b/linux-user/ppc/target_signal.h
> index 82184ab..5be24e1 100644
> --- a/linux-user/ppc/target_signal.h
> +++ b/linux-user/ppc/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef PPC_TARGET_SIGNAL_H
>   #define PPC_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   #if !defined(TARGET_PPC64)
> diff --git a/linux-user/riscv/target_signal.h b/linux-user/riscv/target_signal.h
> index 3e36fdd..6c0470f 100644
> --- a/linux-user/riscv/target_signal.h
> +++ b/linux-user/riscv/target_signal.h
> @@ -1,18 +1,6 @@
>   #ifndef RISCV_TARGET_SIGNAL_H
>   #define RISCV_TARGET_SIGNAL_H
>   
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -#define TARGET_SS_ONSTACK 1
> -#define TARGET_SS_DISABLE 2
> -
> -#define TARGET_MINSIGSTKSZ 2048
> -#define TARGET_SIGSTKSZ 8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
> diff --git a/linux-user/s390x/target_signal.h b/linux-user/s390x/target_signal.h
> index 64f5f42..41e0e34 100644
> --- a/linux-user/s390x/target_signal.h
> +++ b/linux-user/s390x/target_signal.h
> @@ -1,21 +1,6 @@
>   #ifndef S390X_TARGET_SIGNAL_H
>   #define S390X_TARGET_SIGNAL_H
>   
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK      1
> -#define TARGET_SS_DISABLE      2
> -
> -#define TARGET_MINSIGSTKSZ     2048
> -#define TARGET_SIGSTKSZ        8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SETUP_FRAME
> diff --git a/linux-user/sh4/target_signal.h b/linux-user/sh4/target_signal.h
> index 04069cb..eee6a1a 100644
> --- a/linux-user/sh4/target_signal.h
> +++ b/linux-user/sh4/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef SH4_TARGET_SIGNAL_H
>   #define SH4_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SETUP_FRAME
> diff --git a/linux-user/x86_64/target_signal.h b/linux-user/x86_64/target_signal.h
> index 4673c5a..9d97174 100644
> --- a/linux-user/x86_64/target_signal.h
> +++ b/linux-user/x86_64/target_signal.h
> @@ -1,24 +1,6 @@
>   #ifndef X86_64_TARGET_SIGNAL_H
>   #define X86_64_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK	1
> -#define TARGET_SS_DISABLE	2
> -
> -#define TARGET_MINSIGSTKSZ	2048
> -#define TARGET_SIGSTKSZ		8192
> -
>   #include "../generic/signal.h"
>   
>   /* For x86_64, use of SA_RESTORER is mandatory. */
> diff --git a/linux-user/xtensa/target_signal.h b/linux-user/xtensa/target_signal.h
> index 1c7ee73..e4b1bea 100644
> --- a/linux-user/xtensa/target_signal.h
> +++ b/linux-user/xtensa/target_signal.h
> @@ -1,23 +1,6 @@
>   #ifndef XTENSA_TARGET_SIGNAL_H
>   #define XTENSA_TARGET_SIGNAL_H
>   
> -/* this struct defines a stack used during syscall handling */
> -
> -typedef struct target_sigaltstack {
> -    abi_ulong ss_sp;
> -    abi_int ss_flags;
> -    abi_ulong ss_size;
> -} target_stack_t;
> -
> -/*
> - * sigaltstack controls
> - */
> -#define TARGET_SS_ONSTACK     1
> -#define TARGET_SS_DISABLE     2
> -
> -#define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
> -
>   #include "../generic/signal.h"
>   
>   #define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1

Applied to my linux-user-for-7.0 branch.

Thanks,
Laurent


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ
  2021-11-26  2:23 ` [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ Song Gao
  2021-11-26 10:48   ` Richard Henderson
@ 2021-12-20 15:56   ` Laurent Vivier
  1 sibling, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2021-12-20 15:56 UTC (permalink / raw)
  To: Song Gao, qemu-devel; +Cc: richard.henderson, alex.bennee, f4bug

Le 26/11/2021 à 03:23, Song Gao a écrit :
> TARGET_MINSIGSTKSZ has been defined in generic/signal.h
> or target_signal.h, We don't need to define it again.
> 
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   linux-user/aarch64/target_syscall.h    | 1 -
>   linux-user/alpha/target_syscall.h      | 1 -
>   linux-user/arm/target_syscall.h        | 1 -
>   linux-user/cris/target_syscall.h       | 1 -
>   linux-user/hppa/target_syscall.h       | 1 -
>   linux-user/i386/target_syscall.h       | 1 -
>   linux-user/m68k/target_syscall.h       | 1 -
>   linux-user/microblaze/target_syscall.h | 1 -
>   linux-user/mips/target_syscall.h       | 1 -
>   linux-user/mips64/target_syscall.h     | 1 -
>   linux-user/nios2/target_syscall.h      | 1 -
>   linux-user/openrisc/target_syscall.h   | 1 -
>   linux-user/ppc/target_syscall.h        | 1 -
>   linux-user/riscv/target_syscall.h      | 1 -
>   linux-user/s390x/target_syscall.h      | 1 -
>   linux-user/sh4/target_syscall.h        | 1 -
>   linux-user/sparc/target_syscall.h      | 1 -
>   linux-user/x86_64/target_syscall.h     | 1 -
>   18 files changed, 18 deletions(-)
> 
> diff --git a/linux-user/aarch64/target_syscall.h b/linux-user/aarch64/target_syscall.h
> index 76f6c33..508219d 100644
> --- a/linux-user/aarch64/target_syscall.h
> +++ b/linux-user/aarch64/target_syscall.h
> @@ -15,7 +15,6 @@ struct target_pt_regs {
>   #endif
>   #define UNAME_MINIMUM_RELEASE "3.8.0"
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ       2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/alpha/target_syscall.h b/linux-user/alpha/target_syscall.h
> index 03091bf..fda3a49 100644
> --- a/linux-user/alpha/target_syscall.h
> +++ b/linux-user/alpha/target_syscall.h
> @@ -63,7 +63,6 @@ struct target_pt_regs {
>   #define TARGET_UAC_NOPRINT		1
>   #define TARGET_UAC_NOFIX		2
>   #define TARGET_UAC_SIGBUS		4
> -#define TARGET_MINSIGSTKSZ              4096
>   #define TARGET_MCL_CURRENT     0x2000
>   #define TARGET_MCL_FUTURE      0x4000
>   #define TARGET_MCL_ONFAULT     0x8000
> diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h
> index e870ed7..f04f9c9 100644
> --- a/linux-user/arm/target_syscall.h
> +++ b/linux-user/arm/target_syscall.h
> @@ -27,7 +27,6 @@ struct target_pt_regs {
>   
>   #define TARGET_CLONE_BACKWARDS
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/cris/target_syscall.h b/linux-user/cris/target_syscall.h
> index 19e1281..0b5ebf1 100644
> --- a/linux-user/cris/target_syscall.h
> +++ b/linux-user/cris/target_syscall.h
> @@ -39,7 +39,6 @@ struct target_pt_regs {
>   };
>   
>   #define TARGET_CLONE_BACKWARDS2
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/hppa/target_syscall.h b/linux-user/hppa/target_syscall.h
> index 0018bcb..4b382c1 100644
> --- a/linux-user/hppa/target_syscall.h
> +++ b/linux-user/hppa/target_syscall.h
> @@ -22,7 +22,6 @@ struct target_pt_regs {
>   #define UNAME_MACHINE "parisc"
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ       2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/i386/target_syscall.h b/linux-user/i386/target_syscall.h
> index ed356b3..aaade06 100644
> --- a/linux-user/i386/target_syscall.h
> +++ b/linux-user/i386/target_syscall.h
> @@ -150,7 +150,6 @@ struct target_vm86plus_struct {
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/m68k/target_syscall.h b/linux-user/m68k/target_syscall.h
> index 23359a6..8d4ddbd 100644
> --- a/linux-user/m68k/target_syscall.h
> +++ b/linux-user/m68k/target_syscall.h
> @@ -20,7 +20,6 @@ struct target_pt_regs {
>   #define UNAME_MACHINE "m68k"
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/microblaze/target_syscall.h b/linux-user/microblaze/target_syscall.h
> index 7f653db..43362a1 100644
> --- a/linux-user/microblaze/target_syscall.h
> +++ b/linux-user/microblaze/target_syscall.h
> @@ -49,7 +49,6 @@ struct target_pt_regs {
>   };
>   
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ      2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/mips/target_syscall.h b/linux-user/mips/target_syscall.h
> index f590574..7a82661 100644
> --- a/linux-user/mips/target_syscall.h
> +++ b/linux-user/mips/target_syscall.h
> @@ -24,7 +24,6 @@ struct target_pt_regs {
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/mips64/target_syscall.h b/linux-user/mips64/target_syscall.h
> index cd1e1b4..2c7a881 100644
> --- a/linux-user/mips64/target_syscall.h
> +++ b/linux-user/mips64/target_syscall.h
> @@ -21,7 +21,6 @@ struct target_pt_regs {
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ      2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/nios2/target_syscall.h b/linux-user/nios2/target_syscall.h
> index 78006c2..561b28d 100644
> --- a/linux-user/nios2/target_syscall.h
> +++ b/linux-user/nios2/target_syscall.h
> @@ -30,7 +30,6 @@ struct target_pt_regs {
>       unsigned long  orig_r7;
>   };
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/openrisc/target_syscall.h b/linux-user/openrisc/target_syscall.h
> index ef0d89a..7fe5b73 100644
> --- a/linux-user/openrisc/target_syscall.h
> +++ b/linux-user/openrisc/target_syscall.h
> @@ -15,7 +15,6 @@ struct target_pt_regs {
>   #define UNAME_MACHINE "openrisc"
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/ppc/target_syscall.h b/linux-user/ppc/target_syscall.h
> index b9c4b81..8b36469 100644
> --- a/linux-user/ppc/target_syscall.h
> +++ b/linux-user/ppc/target_syscall.h
> @@ -71,7 +71,6 @@ struct target_revectored_struct {
>   
>   #define TARGET_CLONE_BACKWARDS
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 0x2000
>   #define TARGET_MCL_FUTURE  0x4000
>   #define TARGET_MCL_ONFAULT 0x8000
> diff --git a/linux-user/riscv/target_syscall.h b/linux-user/riscv/target_syscall.h
> index dc597c8..8d4b372 100644
> --- a/linux-user/riscv/target_syscall.h
> +++ b/linux-user/riscv/target_syscall.h
> @@ -50,7 +50,6 @@ struct target_pt_regs {
>   #endif
>   #define UNAME_MINIMUM_RELEASE "4.15.0"
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/s390x/target_syscall.h b/linux-user/s390x/target_syscall.h
> index 94f8417..4018988 100644
> --- a/linux-user/s390x/target_syscall.h
> +++ b/linux-user/s390x/target_syscall.h
> @@ -27,7 +27,6 @@ struct target_pt_regs {
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
>   #define TARGET_CLONE_BACKWARDS2
> -#define TARGET_MINSIGSTKSZ        2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/sh4/target_syscall.h b/linux-user/sh4/target_syscall.h
> index c1437ad..1483988 100644
> --- a/linux-user/sh4/target_syscall.h
> +++ b/linux-user/sh4/target_syscall.h
> @@ -15,7 +15,6 @@ struct target_pt_regs {
>   #define UNAME_MACHINE "sh4"
>   #define UNAME_MINIMUM_RELEASE "2.6.32"
>   
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4
> diff --git a/linux-user/sparc/target_syscall.h b/linux-user/sparc/target_syscall.h
> index 087b39d..be77e44 100644
> --- a/linux-user/sparc/target_syscall.h
> +++ b/linux-user/sparc/target_syscall.h
> @@ -34,7 +34,6 @@ struct target_pt_regs {
>    * and copy_thread().
>    */
>   #define TARGET_CLONE_BACKWARDS
> -#define TARGET_MINSIGSTKSZ      4096
>   #define TARGET_MCL_CURRENT 0x2000
>   #define TARGET_MCL_FUTURE  0x4000
>   #define TARGET_MCL_ONFAULT 0x8000
> diff --git a/linux-user/x86_64/target_syscall.h b/linux-user/x86_64/target_syscall.h
> index 3ecccb7..fb55834 100644
> --- a/linux-user/x86_64/target_syscall.h
> +++ b/linux-user/x86_64/target_syscall.h
> @@ -100,7 +100,6 @@ struct target_msqid64_ds {
>   #define TARGET_ARCH_SET_FS 0x1002
>   #define TARGET_ARCH_GET_FS 0x1003
>   #define TARGET_ARCH_GET_GS 0x1004
> -#define TARGET_MINSIGSTKSZ 2048
>   #define TARGET_MCL_CURRENT 1
>   #define TARGET_MCL_FUTURE  2
>   #define TARGET_MCL_ONFAULT 4

Applied to my linux-user-for-7.0 branch.

Thanks,
Laurent



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ
  2021-11-26  2:23 ` [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ Song Gao
  2021-11-26 10:48   ` Richard Henderson
@ 2021-12-20 15:56   ` Laurent Vivier
  1 sibling, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2021-12-20 15:56 UTC (permalink / raw)
  To: Song Gao, qemu-devel; +Cc: richard.henderson, alex.bennee, f4bug

Le 26/11/2021 à 03:23, Song Gao a écrit :
> TARGET_SIGSTKSZ is not used, we should remove it.
> 
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   linux-user/alpha/target_signal.h  | 1 -
>   linux-user/generic/signal.h       | 1 -
>   linux-user/hppa/target_signal.h   | 1 -
>   linux-user/mips/target_signal.h   | 1 -
>   linux-user/mips64/target_signal.h | 1 -
>   linux-user/sparc/target_signal.h  | 1 -
>   6 files changed, 6 deletions(-)
> 
> diff --git a/linux-user/alpha/target_signal.h b/linux-user/alpha/target_signal.h
> index 0b6a39d..bbb06e5 100644
> --- a/linux-user/alpha/target_signal.h
> +++ b/linux-user/alpha/target_signal.h
> @@ -62,7 +62,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_SIGINFO       0x00000040
>   
>   #define TARGET_MINSIGSTKSZ	4096
> -#define TARGET_SIGSTKSZ		16384
>   
>   /* From <asm/gentrap.h>.  */
>   #define TARGET_GEN_INTOVF      -1      /* integer overflow */
> diff --git a/linux-user/generic/signal.h b/linux-user/generic/signal.h
> index ceaf8a8..6fd05b7 100644
> --- a/linux-user/generic/signal.h
> +++ b/linux-user/generic/signal.h
> @@ -69,7 +69,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SS_DISABLE 2
>   
>   #define TARGET_MINSIGSTKSZ     2048
> -#define TARGET_SIGSTKSZ        8192
>   
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
> diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h
> index d558119..af6c2fc 100644
> --- a/linux-user/hppa/target_signal.h
> +++ b/linux-user/hppa/target_signal.h
> @@ -64,7 +64,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_NOCLDWAIT     0x00000080
>   
>   #define TARGET_MINSIGSTKSZ	2048
> -#define TARGET_SIGSTKSZ		8192
>   
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
> diff --git a/linux-user/mips/target_signal.h b/linux-user/mips/target_signal.h
> index 780a4dd..fa542c1 100644
> --- a/linux-user/mips/target_signal.h
> +++ b/linux-user/mips/target_signal.h
> @@ -67,7 +67,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_RESTORER      0x04000000      /* Only for O32 */
>   
>   #define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
>   
>   #if defined(TARGET_ABI_MIPSO32)
>   /* compare linux/arch/mips/kernel/signal.c:setup_frame() */
> diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h
> index 275e9b7..b05098f 100644
> --- a/linux-user/mips64/target_signal.h
> +++ b/linux-user/mips64/target_signal.h
> @@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_RESETHAND     0x80000000
>   
>   #define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
>   
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
> diff --git a/linux-user/sparc/target_signal.h b/linux-user/sparc/target_signal.h
> index e661ddd..87757f0 100644
> --- a/linux-user/sparc/target_signal.h
> +++ b/linux-user/sparc/target_signal.h
> @@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_ARCH_HAS_KA_RESTORER 1
>   
>   #define TARGET_MINSIGSTKSZ	4096
> -#define TARGET_SIGSTKSZ		16384
>   
>   #ifdef TARGET_ABI32
>   #define TARGET_ARCH_HAS_SETUP_FRAME

Applied to my linux-user-for-7.0 branch.

Thanks,
Laurent



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-12-20 17:36 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26  2:23 [PATCH v2 0/3] Move target_signal.h generic definitions to generic/signal.h Song Gao
2021-11-26  2:23 ` [PATCH v2 1/3] linux-user: " Song Gao
2021-11-26 10:47   ` Richard Henderson
2021-12-20 15:56   ` Laurent Vivier
2021-11-26  2:23 ` [PATCH v2 2/3] linux-user: target_syscall.h remove definition TARGET_MINSIGSTKSZ Song Gao
2021-11-26 10:48   ` Richard Henderson
2021-12-20 15:56   ` Laurent Vivier
2021-11-26  2:23 ` [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ Song Gao
2021-11-26 10:48   ` Richard Henderson
2021-12-20 15:56   ` Laurent Vivier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.