From: Wadim Egorov <w.egorov@phytec.de>
To: Jacob Chen <jacobchen110@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
Heiko Stuebner <heiko@sntech.de>,
linux@armlinux.org.uk, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: Add support for phyCORE-RK3288 SoM
Date: Tue, 18 Apr 2017 17:01:41 +0200 [thread overview]
Message-ID: <381e11bc-649d-ddf2-4a28-f72a264204c3@phytec.de> (raw)
In-Reply-To: <CAFLEztSQ1-WU7KAXzuB66htXiaQN4wd=XmM5XtjZcoONt77XmQ@mail.gmail.com>
>> +&i2c0 {
>> + status = "okay";
>> + clock-frequency = <400000>;
>> +
>> + rk818: pmic@1c {
>> + compatible = "rockchip,rk818";
>> + reg = <0x1c>;
>> + interrupt-parent = <&gpio0>;
>> + interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pmic_int>;
>> + rockchip,system-power-controller;
>> + wakeup-source;
>> + #clock-cells = <1>;
>> +
> I think you miss "clock-output-names = "xin32k" here.
Yes, thanks for catching that. I will fix this later.
WARNING: multiple messages have this Message-ID (diff)
From: Wadim Egorov <w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
To: Jacob Chen <jacobchen110-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: Add support for phyCORE-RK3288 SoM
Date: Tue, 18 Apr 2017 17:01:41 +0200 [thread overview]
Message-ID: <381e11bc-649d-ddf2-4a28-f72a264204c3@phytec.de> (raw)
In-Reply-To: <CAFLEztSQ1-WU7KAXzuB66htXiaQN4wd=XmM5XtjZcoONt77XmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
>> +&i2c0 {
>> + status = "okay";
>> + clock-frequency = <400000>;
>> +
>> + rk818: pmic@1c {
>> + compatible = "rockchip,rk818";
>> + reg = <0x1c>;
>> + interrupt-parent = <&gpio0>;
>> + interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pmic_int>;
>> + rockchip,system-power-controller;
>> + wakeup-source;
>> + #clock-cells = <1>;
>> +
> I think you miss "clock-output-names = "xin32k" here.
Yes, thanks for catching that. I will fix this later.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: w.egorov@phytec.de (Wadim Egorov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: dts: rockchip: Add support for phyCORE-RK3288 SoM
Date: Tue, 18 Apr 2017 17:01:41 +0200 [thread overview]
Message-ID: <381e11bc-649d-ddf2-4a28-f72a264204c3@phytec.de> (raw)
In-Reply-To: <CAFLEztSQ1-WU7KAXzuB66htXiaQN4wd=XmM5XtjZcoONt77XmQ@mail.gmail.com>
>> +&i2c0 {
>> + status = "okay";
>> + clock-frequency = <400000>;
>> +
>> + rk818: pmic at 1c {
>> + compatible = "rockchip,rk818";
>> + reg = <0x1c>;
>> + interrupt-parent = <&gpio0>;
>> + interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pmic_int>;
>> + rockchip,system-power-controller;
>> + wakeup-source;
>> + #clock-cells = <1>;
>> +
> I think you miss "clock-output-names = "xin32k" here.
Yes, thanks for catching that. I will fix this later.
next prev parent reply other threads:[~2017-04-18 15:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 13:04 [PATCH v2 1/3] ARM: dts: rockchip: Add support for phyCORE-RK3288 SoM Wadim Egorov
2017-04-06 13:04 ` Wadim Egorov
2017-04-06 13:04 ` Wadim Egorov
2017-04-06 13:04 ` [PATCH v2 2/3] ARM: dts: rockchip: Add support for PCM-947 carrier board Wadim Egorov
2017-04-06 13:04 ` Wadim Egorov
2017-04-06 13:04 ` Wadim Egorov
2017-04-06 13:04 ` [PATCH v2 3/3] dt-bindings: Document Phytec phyCORE-RK3288 RDK Wadim Egorov
2017-04-06 13:04 ` Wadim Egorov
2017-04-10 18:26 ` Rob Herring
2017-04-10 18:26 ` Rob Herring
2017-04-10 18:26 ` Rob Herring
2017-04-06 22:21 ` [PATCH v2 1/3] ARM: dts: rockchip: Add support for phyCORE-RK3288 SoM Heiko Stuebner
2017-04-06 22:21 ` Heiko Stuebner
2017-04-06 22:21 ` Heiko Stuebner
2017-04-18 10:15 ` Jacob Chen
2017-04-18 10:15 ` Jacob Chen
2017-04-18 10:15 ` Jacob Chen
2017-04-18 15:01 ` Wadim Egorov [this message]
2017-04-18 15:01 ` Wadim Egorov
2017-04-18 15:01 ` Wadim Egorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=381e11bc-649d-ddf2-4a28-f72a264204c3@phytec.de \
--to=w.egorov@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jacobchen110@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.