All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine
@ 2020-06-11  7:47 Diego Sueiro
  2020-06-11  7:55 ` [meta-arm] " Bertrand Marquis
  0 siblings, 1 reply; 5+ messages in thread
From: Diego Sueiro @ 2020-06-11  7:47 UTC (permalink / raw)
  To: meta-arm; +Cc: nd

By default, XENGUEST_NETWORK_BRIDGE_MEMBERS should be empty and only be
set per machine.

Change-Id: I67c56847eb785279c28757a6052f092c838babe0
Issue-Id: SCM-995
Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 .../recipes-extended/xenguest/xenguest-network-bridge.bbappend    | 8 ++++++++
 .../recipes-extended/xenguest/xenguest-network-bridge.bb          | 6 +++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend b/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
index dc84921..de88cce 100644
--- a/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
+++ b/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
@@ -1,2 +1,10 @@
+XENGUEST_NETWORK_BRIDGE_MEMBERS_n1sdp ?= "eth0"
+
+XENGUEST_NETWORK_BRIDGE_MEMBERS_fvp-base ?= "eth0"
+
+XENGUEST_NETWORK_BRIDGE_MEMBERS_foundation-armv8 ?= "eth0"
+
+XENGUEST_NETWORK_BRIDGE_MEMBERS_gem5-arm64 ?= "eth0"
+
 # Juno board has 2 network interfaces, add both of them to the bridge
 XENGUEST_NETWORK_BRIDGE_MEMBERS_juno ?= "eth0 eth1"
diff --git a/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb b/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
index babd694..c6c2242 100644
--- a/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
+++ b/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
@@ -9,7 +9,11 @@ S = "${WORKDIR}"
 # Please refer to documentation/xenguest-network-bridge.md for documentation on
 # those parameters
 XENGUEST_NETWORK_BRIDGE_NAME ?= "xenbr0"
-XENGUEST_NETWORK_BRIDGE_MEMBERS ?= "eth0"
+
+# The XENGUEST_NETWORK_BRIDGE_MEMBERS should be set in a machine.conf
+# or bbappend file.
+#XENGUEST_NETWORK_BRIDGE_MEMBERS ?= "eth0"
+
 XENGUEST_NETWORK_BRIDGE_CONFIG ?= "xenguest-network-bridge-dhcp.cfg.in"
 
 SRC_URI = " \
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine
  2020-06-11  7:47 [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine Diego Sueiro
@ 2020-06-11  7:55 ` Bertrand Marquis
  2020-06-11 14:02   ` Jon Mason
  0 siblings, 1 reply; 5+ messages in thread
From: Bertrand Marquis @ 2020-06-11  7:55 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-arm, nd



> On 11 Jun 2020, at 08:47, Diego Sueiro via lists.yoctoproject.org <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> 
> By default, XENGUEST_NETWORK_BRIDGE_MEMBERS should be empty and only be
> set per machine.
> 
> Change-Id: I67c56847eb785279c28757a6052f092c838babe0
> Issue-Id: SCM-995
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

> ---
> .../recipes-extended/xenguest/xenguest-network-bridge.bbappend    | 8 ++++++++
> .../recipes-extended/xenguest/xenguest-network-bridge.bb          | 6 +++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend b/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
> index dc84921..de88cce 100644
> --- a/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
> +++ b/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
> @@ -1,2 +1,10 @@
> +XENGUEST_NETWORK_BRIDGE_MEMBERS_n1sdp ?= "eth0"
> +
> +XENGUEST_NETWORK_BRIDGE_MEMBERS_fvp-base ?= "eth0"
> +
> +XENGUEST_NETWORK_BRIDGE_MEMBERS_foundation-armv8 ?= "eth0"
> +
> +XENGUEST_NETWORK_BRIDGE_MEMBERS_gem5-arm64 ?= "eth0"
> +
> # Juno board has 2 network interfaces, add both of them to the bridge
> XENGUEST_NETWORK_BRIDGE_MEMBERS_juno ?= "eth0 eth1"
> diff --git a/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb b/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
> index babd694..c6c2242 100644
> --- a/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
> +++ b/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
> @@ -9,7 +9,11 @@ S = "${WORKDIR}"
> # Please refer to documentation/xenguest-network-bridge.md for documentation on
> # those parameters
> XENGUEST_NETWORK_BRIDGE_NAME ?= "xenbr0"
> -XENGUEST_NETWORK_BRIDGE_MEMBERS ?= "eth0"
> +
> +# The XENGUEST_NETWORK_BRIDGE_MEMBERS should be set in a machine.conf
> +# or bbappend file.
> +#XENGUEST_NETWORK_BRIDGE_MEMBERS ?= "eth0"
> +
> XENGUEST_NETWORK_BRIDGE_CONFIG ?= "xenguest-network-bridge-dhcp.cfg.in"
> 
> SRC_URI = " \
> -- 
> 2.7.4
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine
  2020-06-11  7:55 ` [meta-arm] " Bertrand Marquis
@ 2020-06-11 14:02   ` Jon Mason
  2020-06-11 14:19     ` Diego Sueiro
  0 siblings, 1 reply; 5+ messages in thread
From: Jon Mason @ 2020-06-11 14:02 UTC (permalink / raw)
  To: Bertrand Marquis; +Cc: Diego Sueiro, meta-arm, nd

On Thu, Jun 11, 2020 at 07:55:05AM +0000, Bertrand Marquis wrote:
> 
> 
> > On 11 Jun 2020, at 08:47, Diego Sueiro via lists.yoctoproject.org <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> > 
> > By default, XENGUEST_NETWORK_BRIDGE_MEMBERS should be empty and only be
> > set per machine.
> > 
> > Change-Id: I67c56847eb785279c28757a6052f092c838babe0
> > Issue-Id: SCM-995
> > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Applied to the master branch.

Thanks,
Jon

> 
> > ---
> > .../recipes-extended/xenguest/xenguest-network-bridge.bbappend    | 8 ++++++++
> > .../recipes-extended/xenguest/xenguest-network-bridge.bb          | 6 +++++-
> > 2 files changed, 13 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend b/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
> > index dc84921..de88cce 100644
> > --- a/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
> > +++ b/meta-arm-autonomy/dynamic-layers/meta-arm-bsp/recipes-extended/xenguest/xenguest-network-bridge.bbappend
> > @@ -1,2 +1,10 @@
> > +XENGUEST_NETWORK_BRIDGE_MEMBERS_n1sdp ?= "eth0"
> > +
> > +XENGUEST_NETWORK_BRIDGE_MEMBERS_fvp-base ?= "eth0"
> > +
> > +XENGUEST_NETWORK_BRIDGE_MEMBERS_foundation-armv8 ?= "eth0"
> > +
> > +XENGUEST_NETWORK_BRIDGE_MEMBERS_gem5-arm64 ?= "eth0"
> > +
> > # Juno board has 2 network interfaces, add both of them to the bridge
> > XENGUEST_NETWORK_BRIDGE_MEMBERS_juno ?= "eth0 eth1"
> > diff --git a/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb b/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
> > index babd694..c6c2242 100644
> > --- a/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
> > +++ b/meta-arm-autonomy/recipes-extended/xenguest/xenguest-network-bridge.bb
> > @@ -9,7 +9,11 @@ S = "${WORKDIR}"
> > # Please refer to documentation/xenguest-network-bridge.md for documentation on
> > # those parameters
> > XENGUEST_NETWORK_BRIDGE_NAME ?= "xenbr0"
> > -XENGUEST_NETWORK_BRIDGE_MEMBERS ?= "eth0"
> > +
> > +# The XENGUEST_NETWORK_BRIDGE_MEMBERS should be set in a machine.conf
> > +# or bbappend file.
> > +#XENGUEST_NETWORK_BRIDGE_MEMBERS ?= "eth0"
> > +
> > XENGUEST_NETWORK_BRIDGE_CONFIG ?= "xenguest-network-bridge-dhcp.cfg.in"
> > 
> > SRC_URI = " \
> > -- 
> > 2.7.4
> > 
> > 
> 

> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine
  2020-06-11 14:02   ` Jon Mason
@ 2020-06-11 14:19     ` Diego Sueiro
  2020-06-11 16:28       ` [meta-arm] " Jon Mason
  0 siblings, 1 reply; 5+ messages in thread
From: Diego Sueiro @ 2020-06-11 14:19 UTC (permalink / raw)
  To: meta-arm

On Thu, Jun 11, 2020 at 03:02 PM, Jon Mason wrote:

>
> On Thu, Jun 11, 2020 at 07:55:05AM +0000, Bertrand Marquis wrote:
> > 
> > 
> > > On 11 Jun 2020, at 08:47, Diego Sueiro via lists.yoctoproject.org
> <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> > > 
> > > By default, XENGUEST_NETWORK_BRIDGE_MEMBERS should be empty and only be
> > > set per machine.
> > > 
> > > Change-Id: I67c56847eb785279c28757a6052f092c838babe0
> > > Issue-Id: SCM-995
> > > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> > Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> Applied to the master branch.

Can you please apply to dunfell as well?

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine
  2020-06-11 14:19     ` Diego Sueiro
@ 2020-06-11 16:28       ` Jon Mason
  0 siblings, 0 replies; 5+ messages in thread
From: Jon Mason @ 2020-06-11 16:28 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-arm

On Thu, Jun 11, 2020 at 07:19:57AM -0700, Diego Sueiro wrote:
> On Thu, Jun 11, 2020 at 03:02 PM, Jon Mason wrote:
> 
> >
> > On Thu, Jun 11, 2020 at 07:55:05AM +0000, Bertrand Marquis wrote:
> > > 
> > > 
> > > > On 11 Jun 2020, at 08:47, Diego Sueiro via lists.yoctoproject.org
> > <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> > > > 
> > > > By default, XENGUEST_NETWORK_BRIDGE_MEMBERS should be empty and only be
> > > > set per machine.
> > > > 
> > > > Change-Id: I67c56847eb785279c28757a6052f092c838babe0
> > > > Issue-Id: SCM-995
> > > > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> > > Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> > 
> > Applied to the master branch.
> 
> Can you please apply to dunfell as well?

Done

> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-11 16:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11  7:47 [PATCH] arm-autonomy, xenguest-network-bridge: Set bridge members per machine Diego Sueiro
2020-06-11  7:55 ` [meta-arm] " Bertrand Marquis
2020-06-11 14:02   ` Jon Mason
2020-06-11 14:19     ` Diego Sueiro
2020-06-11 16:28       ` [meta-arm] " Jon Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.