From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Joel Stanley" <joel@jms.id.au>
Cc: "OpenBMC Maillist" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH linux dev-5.3 3/6] dt-bindings: clock: Add AST2600 RMII RCLK gate definitions
Date: Mon, 23 Sep 2019 15:01:42 +0930 [thread overview]
Message-ID: <383cb8cd-c650-49b4-8479-c6ea2140b0c0@www.fastmail.com> (raw)
In-Reply-To: <CACPK8XdK1HYaDkywgFSauU7VCqMNjU49JY2azyqwc7MXPeA49A@mail.gmail.com>
On Mon, 23 Sep 2019, at 14:55, Joel Stanley wrote:
> On Mon, 23 Sep 2019 at 05:11, Andrew Jeffery <andrew@aj.id.au> wrote:
> >
> >
> >
> > On Mon, 23 Sep 2019, at 14:28, Joel Stanley wrote:
> > > On Sun, 22 Sep 2019 at 12:36, Andrew Jeffery <andrew@aj.id.au> wrote:
> > > >
> > > > The AST2600 has an explicit gate for the RMII RCLK for each of the four
> > > > MACs.
> > > >
> > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > >
> > > Put this in the same patch as the clock driver changes when you respin.
> >
> > I initially did what you suggested and checkpatch complained. It's explicitly documented that DT header changes should be separate in the dt-specific submitting-patches documentation.
>
> That's silly.
No arguments here :)
> I would ignore that recommendation, but it's your call.
Yeah, was conflicted but given it was all fairly explicitly requested I figured splitting it was likely the path of least resistance.
next prev parent reply other threads:[~2019-09-23 5:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 12:36 [PATCH linux dev-5.3 0/6] ftgmac100: Support AST2600 RMII Andrew Jeffery
2019-09-22 12:36 ` [PATCH linux dev-5.3 1/6] dt-bindings: net: ftgmac100: Document AST2600 compatible Andrew Jeffery
2019-09-22 12:36 ` [PATCH linux dev-5.3 2/6] dt-bindings: net: ftgmac100: Describe clock properties Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
2019-09-23 5:14 ` Andrew Jeffery
2019-09-23 5:26 ` Joel Stanley
2019-09-23 23:20 ` Vijay Khemka
2019-09-25 4:19 ` Andrew Jeffery
2019-09-26 18:58 ` Vijay Khemka
2019-09-22 12:36 ` [PATCH linux dev-5.3 3/6] dt-bindings: clock: Add AST2600 RMII RCLK gate definitions Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
2019-09-23 5:11 ` Andrew Jeffery
2019-09-23 5:25 ` Joel Stanley
2019-09-23 5:31 ` Andrew Jeffery [this message]
2019-09-22 12:36 ` [PATCH linux dev-5.3 4/6] clk: ast2600: Add RMII RCLK gates for all four MACs Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
2019-09-22 12:36 ` [PATCH linux dev-5.3 5/6] net: ftgmac100: Ungate RCLK for RMII on AST2600 Andrew Jeffery
2019-09-23 4:57 ` Joel Stanley
2019-09-23 6:12 ` Cédric Le Goater
2019-09-23 6:26 ` Andrew Jeffery
2019-09-22 12:37 ` [PATCH linux dev-5.3 6/6] ARM: dts: tacoma: Enable 50MHz RMII RCLK for NCSI Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383cb8cd-c650-49b4-8479-c6ea2140b0c0@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.