From: Joel Stanley <joel@jms.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH linux dev-5.3 2/6] dt-bindings: net: ftgmac100: Describe clock properties
Date: Mon, 23 Sep 2019 04:58:42 +0000 [thread overview]
Message-ID: <CACPK8Xf_ciMEtayQ78yUo=YhrovRMe65xuwviE+DWXDSuQb5-Q@mail.gmail.com> (raw)
In-Reply-To: <20190922123700.749-3-andrew@aj.id.au>
On Sun, 22 Sep 2019 at 12:36, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is
> in use.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt
> index 04cc0191b7dd..c443b0b84be5 100644
> --- a/Documentation/devicetree/bindings/net/ftgmac100.txt
> +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
> @@ -24,6 +24,12 @@ Optional properties:
> - no-hw-checksum: Used to disable HW checksum support. Here for backward
> compatibility as the driver now should have correct defaults based on
> the SoC.
> +- clocks: In accordance with the generic clock bindings. Must describe the MAC
> + IP clock, and optionally an RMII RCLK gate for the AST2600.
perhaps: "and optionally a RMII clock if RMII or NC-SI is used"
We should implement this for the ast2500 too.
> +- clock-names:
> +
> + - "MACCLK": The MAC IP clock
> + - "RCLK": Clock gate for the RMII RCLK
>
> Example:
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-09-23 4:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 12:36 [PATCH linux dev-5.3 0/6] ftgmac100: Support AST2600 RMII Andrew Jeffery
2019-09-22 12:36 ` [PATCH linux dev-5.3 1/6] dt-bindings: net: ftgmac100: Document AST2600 compatible Andrew Jeffery
2019-09-22 12:36 ` [PATCH linux dev-5.3 2/6] dt-bindings: net: ftgmac100: Describe clock properties Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley [this message]
2019-09-23 5:14 ` Andrew Jeffery
2019-09-23 5:26 ` Joel Stanley
2019-09-23 23:20 ` Vijay Khemka
2019-09-25 4:19 ` Andrew Jeffery
2019-09-26 18:58 ` Vijay Khemka
2019-09-22 12:36 ` [PATCH linux dev-5.3 3/6] dt-bindings: clock: Add AST2600 RMII RCLK gate definitions Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
2019-09-23 5:11 ` Andrew Jeffery
2019-09-23 5:25 ` Joel Stanley
2019-09-23 5:31 ` Andrew Jeffery
2019-09-22 12:36 ` [PATCH linux dev-5.3 4/6] clk: ast2600: Add RMII RCLK gates for all four MACs Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
2019-09-22 12:36 ` [PATCH linux dev-5.3 5/6] net: ftgmac100: Ungate RCLK for RMII on AST2600 Andrew Jeffery
2019-09-23 4:57 ` Joel Stanley
2019-09-23 6:12 ` Cédric Le Goater
2019-09-23 6:26 ` Andrew Jeffery
2019-09-22 12:37 ` [PATCH linux dev-5.3 6/6] ARM: dts: tacoma: Enable 50MHz RMII RCLK for NCSI Andrew Jeffery
2019-09-23 4:58 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xf_ciMEtayQ78yUo=YhrovRMe65xuwviE+DWXDSuQb5-Q@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.