All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zang Roy-R61911 <r61911@freescale.com>
To: "Anton Vorontsov" <cbouatmailru@gmail.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
	dedekind1@gmail.com, Lan Chunhe-B25806 <B25806@freescale.com>,
	linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
	akpm@linux-foundation.org, dwmw2@infradead.org,
	Gala Kumar-B11780 <B11780@freescale.com>
Subject: RE: [PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices
Date: Fri, 10 Sep 2010 14:58:15 +0800	[thread overview]
Message-ID: <3850A844E6A3854C827AC5C0BEC7B60A1FBF4A@zch01exm23.fsl.freescale.net> (raw)
In-Reply-To: <20100909115338.GA12320@oksana.dev.rtsoft.ru>

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQW50b24gVm9yb250c292
IFttYWlsdG86Y2JvdWF0bWFpbHJ1QGdtYWlsLmNvbV0NCj4gU2VudDogVGh1cnNkYXksIFNlcHRl
bWJlciAwOSwgMjAxMCAxOTo1NCBQTQ0KPiBUbzogWmFuZyBSb3ktUjYxOTExDQo+IENjOiBsaW51
eC1tdGRAbGlzdHMuaW5mcmFkZWFkLm9yZzsgZHdtdzJAaW5mcmFkZWFkLm9yZzsgZGVkZWtpbmQx
QGdtYWlsLmNvbTsNCj4gYWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZzsgTGFuIENodW5oZS1CMjU4
MDY7IFdvb2QgU2NvdHQtQjA3NDIxOyBHYWxhIEt1bWFyLQ0KPiBCMTE3ODA7IGxpbnV4cHBjLWRl
dkBvemxhYnMub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8zIHYyXVtNVERdIFA0MDgwL2VM
QkM6IE1ha2UgRnJlZXNjYWxlIGVsYmMgaW50ZXJydXB0DQo+IGNvbW1vbiB0byBlbGJjIGRldmlj
ZXMNCj4gDQo+IEp1c3QgYSBmZXcgY29zbWV0aWMgbml0cyBmb3IgdGhpcyBwYXRjaC4uLg0KPiAN
Cj4gT24gVGh1LCBTZXAgMDksIDIwMTAgYXQgMDY6MjA6MzBQTSArMDgwMCwgUm95IFphbmcgd3Jv
dGU6DQo+IFsuLi5dDQpbc25pcF0NCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2Vf
aWQgZnNsX2xiY19tYXRjaFtdID0gew0KPiA+ICsJeyAuY29tcGF0aWJsZSA9ICJmc2wsZWxiYyIs
IH0sDQo+ID4gKwl7IC5jb21wYXRpYmxlID0gImZzbCxwcTMtbG9jYWxidXMiLCB9LA0KPiA+ICsJ
eyAuY29tcGF0aWJsZSA9ICJmc2wscHEyLWxvY2FsYnVzIiwgfSwNCj4gPiArCXsgLmNvbXBhdGli
bGUgPSAiZnNsLHBxMnByby1sb2NhbGJ1cyIsIH0sDQo+ID4gKwl7fSwNCj4gPiArfTsNCj4gDQo+
IFlvdSBuZWVkIGxpbnV4L21vZF9kZXZpY2V0YWJsZS5oIGZvciB0aGlzLg0KSXQgaGFzIGJlZW4g
aW5jbHVkZSBpbiBsaW51eC9vZi5oLg0KDQo+IA0KPiA+ICsNCj4gPiArc3RhdGljIHN0cnVjdCBv
Zl9wbGF0Zm9ybV9kcml2ZXIgZnNsX2xiY19jdHJsX2RyaXZlciA9IHsNCj4gDQo+IE5lZWQgbGlu
dXgvb2ZfcGxhdGZvcm0uaCBmb3IgdGhpcy4NCkl0IGhhcyBiZWVuIGluY2x1ZGUgYnkNCmZzbF9s
YmMuaC0+bGludXgvb2ZfcGxhdGZvcm0uaC0+IGxpbnV4L3BsYXRmb3JtX2RldmljZS5oDQpCZWZv
cmUgc3VibWl0dGluZyB0aGUgcGF0Y2gsIEkgaGF2ZSBidWlsdCBhbmQgdGVzdGVkIGl0Lg0KDQpE
byB5b3UgdGhpbmsgSSBkbyBub3QgYnVpbGQgdGhlIHRyZWUgYmVmb3JlIEkgc2VuZCBvdXQgdGhl
IHBhdGNoPw0KPiANCj4gPiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgb2ZfcGxhdGZvcm1fZHJpdmVy
IGZzbF9sYmNfY3RybF9kcml2ZXIgPSB7DQo+IA0KPiBOZWVkIGxpbnV4L29mX3BsYXRmb3JtLmgg
Zm9yIHRoaXMuDQo+IA0KPiBCdXQgeW91IGFjdHVhbGx5IGRvbid0IG5lZWQgb2ZfcGxhdGZvcm1f
ZHJpdmVyLCBhcyBmb3IgdGhlDQo+IG5ldyBjb2RlIHlvdSBjYW4gdXNlIHBsYXRmb3JtX2RyaXZl
ciAoYW5kIHRodXMNCj4gbGludXgvcGxhdGZvcm1fZGV2aWNlLmgpLg0KSSdkIHByZWZlciB1c2lu
ZyBvZl9wbGF0Zm9ybV9kcml2ZXIgaGVyZSBmb3Igc2ltcGxpZmllZCBjb2RlLg0KQW55IHNwZWNp
YWwgcmVhc29uIHRvIHVzZSBwbGF0Zm9ybV9kZXZpY2UgaGVyZT8NClRoYW5rcy4NClJveQ0K

WARNING: multiple messages have this Message-ID (diff)
From: Zang Roy-R61911 <r61911@freescale.com>
To: "Anton Vorontsov" <cbouatmailru@gmail.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
	dedekind1@gmail.com, Lan Chunhe-B25806 <B25806@freescale.com>,
	linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
	akpm@linux-foundation.org, dwmw2@infradead.org,
	Gala Kumar-B11780 <B11780@freescale.com>
Subject: RE: [PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices
Date: Fri, 10 Sep 2010 14:58:15 +0800	[thread overview]
Message-ID: <3850A844E6A3854C827AC5C0BEC7B60A1FBF4A@zch01exm23.fsl.freescale.net> (raw)
In-Reply-To: <20100909115338.GA12320@oksana.dev.rtsoft.ru>



> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@gmail.com]
> Sent: Thursday, September 09, 2010 19:54 PM
> To: Zang Roy-R61911
> Cc: linux-mtd@lists.infradead.org; dwmw2@infradead.org; dedekind1@gmail.com;
> akpm@linux-foundation.org; Lan Chunhe-B25806; Wood Scott-B07421; Gala Kumar-
> B11780; linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt
> common to elbc devices
> 
> Just a few cosmetic nits for this patch...
> 
> On Thu, Sep 09, 2010 at 06:20:30PM +0800, Roy Zang wrote:
> [...]
[snip]
> > +static const struct of_device_id fsl_lbc_match[] = {
> > +	{ .compatible = "fsl,elbc", },
> > +	{ .compatible = "fsl,pq3-localbus", },
> > +	{ .compatible = "fsl,pq2-localbus", },
> > +	{ .compatible = "fsl,pq2pro-localbus", },
> > +	{},
> > +};
> 
> You need linux/mod_devicetable.h for this.
It has been include in linux/of.h.

> 
> > +
> > +static struct of_platform_driver fsl_lbc_ctrl_driver = {
> 
> Need linux/of_platform.h for this.
It has been include by
fsl_lbc.h->linux/of_platform.h-> linux/platform_device.h
Before submitting the patch, I have built and tested it.

Do you think I do not build the tree before I send out the patch?
> 
> > +
> > +static struct of_platform_driver fsl_lbc_ctrl_driver = {
> 
> Need linux/of_platform.h for this.
> 
> But you actually don't need of_platform_driver, as for the
> new code you can use platform_driver (and thus
> linux/platform_device.h).
I'd prefer using of_platform_driver here for simplified code.
Any special reason to use platform_device here?
Thanks.
Roy

  reply	other threads:[~2010-09-10  6:58 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 10:20 [PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Roy Zang
2010-09-09 10:20 ` Roy Zang
2010-09-09 10:20 ` [PATCH 2/3 v2][MTD] P4080/mtd: Only make elbc nand driver detect nand flash partitions Roy Zang
2010-09-09 10:20   ` Roy Zang
2010-09-09 10:20   ` [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode Roy Zang
2010-09-09 10:20     ` Roy Zang
2010-09-09 11:06     ` Geert Uytterhoeven
2010-09-09 11:06       ` Geert Uytterhoeven
2010-09-13  7:22       ` Zang Roy-R61911
2010-09-13  7:22         ` Zang Roy-R61911
2010-09-13 16:27         ` Scott Wood
2010-09-13 16:27           ` Scott Wood
2010-09-14  4:09           ` Zang Roy-R61911
2010-09-14  4:09             ` Zang Roy-R61911
2010-09-14 11:56             ` Timur Tabi
2010-09-14 11:56               ` Timur Tabi
2010-09-09 11:41     ` Anton Vorontsov
2010-09-13  7:30       ` Zang Roy-R61911
2010-09-13  7:30         ` Zang Roy-R61911
2010-09-13 14:10         ` Timur Tabi
2010-09-13 14:10           ` Timur Tabi
2010-09-13 14:27           ` Artem Bityutskiy
2010-09-13 14:27             ` Artem Bityutskiy
2010-09-13 14:35             ` Timur Tabi
2010-09-13 14:35               ` Timur Tabi
2010-09-13 16:45               ` Artem Bityutskiy
2010-09-13 16:45                 ` Artem Bityutskiy
2010-09-13 18:36                 ` Timur Tabi
2010-09-13 18:36                   ` Timur Tabi
2010-09-13 18:46                   ` Artem Bityutskiy
2010-09-13 18:46                     ` Artem Bityutskiy
2010-09-13 20:04                   ` Scott Wood
2010-09-13 20:04                     ` Scott Wood
2010-09-14  6:20             ` Zang Roy-R61911
2010-09-14  6:20               ` Zang Roy-R61911
2010-09-09 11:23   ` [PATCH 2/3 v2][MTD] P4080/mtd: Only make elbc nand driver detect nand flash partitions Anton Vorontsov
2010-09-09 11:53 ` [PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Anton Vorontsov
2010-09-10  6:58   ` Zang Roy-R61911 [this message]
2010-09-10  6:58     ` Zang Roy-R61911
2010-09-10  9:31     ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3850A844E6A3854C827AC5C0BEC7B60A1FBF4A@zch01exm23.fsl.freescale.net \
    --to=r61911@freescale.com \
    --cc=B07421@freescale.com \
    --cc=B11780@freescale.com \
    --cc=B25806@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=cbouatmailru@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.