[PATCH net-next] be2net: log link status

[PATCH net-next] be2net: log link status

[Ivan Vecera]

The driver unlike other drivers does not log link state changes.

Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index fb0bc3c..e349131 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
 		netif_carrier_on(netdev);
 	else
 		netif_carrier_off(netdev);
+
+	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
 }
 
 static void be_tx_stats_update(struct be_tx_obj *txo, struct sk_buff *skb)
-- 
2.0.5

Re: [PATCH net-next] be2net: log link status

[Joe Perches]

On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
> The driver unlike other drivers does not log link state changes.
[]
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
[]
> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>  		netif_carrier_on(netdev);
>  	else
>  		netif_carrier_off(netdev);
> +
> +	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
>  }

If this is valuable, it's also valuable to emit the
link speed/duplex states like most other drivers.

Re: [PATCH net-next] be2net: log link status

[Ivan Vecera]

On 04/22/2015 03:10 PM, Joe Perches wrote:
> On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
>> The driver unlike other drivers does not log link state changes.
> []
>> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> []
>> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>>   		netif_carrier_on(netdev);
>>   	else
>>   		netif_carrier_off(netdev);
>> +
>> +	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
>>   }
>
> If this is valuable, it's also valuable to emit the
> link speed/duplex states like most other drivers.
>
Duplex state is not much valuable as for be2net link-up means 
full-duplex and link-down means unknown-duplex.
But link speed could be valuable. Will send v2.

Ivan

RE: [PATCH net-next] be2net: log link status

[Sathya Perla]

> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@redhat.com]
> 
> The driver unlike other drivers does not log link state changes.
> 
> Cc: Sathya Perla <sathya.perla@emulex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
> Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index fb0bc3c..e349131 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>  		netif_carrier_on(netdev);
>  	else
>  		netif_carrier_off(netdev);
> +
> +	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
>  }
> 
Acked-by: Sathya Perla <sathya.perla@emulex.com>