From: Mimi Zohar <zohar@linux.ibm.com> To: Casey Schaufler <casey@schaufler-ca.com>, casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Cc: linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, linux-kernel@vger.kernel.org Subject: Re: [PATCH v24 04/25] IMA: avoid label collisions with stacked LSMs Date: Mon, 22 Feb 2021 19:27:07 -0500 [thread overview] Message-ID: <3862fed24a1265611f71327ddb444e52557bdc7c.camel@linux.ibm.com> (raw) In-Reply-To: <77ebed19-2912-d8f2-cb4d-3f782c8e7f18@schaufler-ca.com> On Mon, 2021-02-22 at 15:45 -0800, Casey Schaufler wrote: > On 2/14/2021 10:21 AM, Mimi Zohar wrote: > > Would these changes match your suggestion? > > security/integrity/ima/ima_policy.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c > index 9ac673472781..e80956548243 100644 > --- a/security/integrity/ima/ima_policy.c > +++ b/security/integrity/ima/ima_policy.c > @@ -78,11 +78,11 @@ struct ima_rule_entry { > bool (*uid_op)(kuid_t, kuid_t); /* Handlers for operators */ > bool (*fowner_op)(kuid_t, kuid_t); /* uid_eq(), uid_gt(), uid_lt() */ > int pcr; > + int which_lsm; /* which of the rules to use */ > struct { > void *rules[LSMBLOB_ENTRIES]; /* LSM file metadata specific */ If each IMA policy rule may only contain a single LSM specific LSM_OBJ_{USER | ROLE | TYPE} and LSM_SUBJ_{USER | ROLE | TYPE}, then there is no need for rules[LSMBLOB_ENTRIES]. Leave it as "*rule". Otherwise it looks good. Mimi > char *args_p; /* audit value */ > int type; /* audit type */ > - int which_lsm; /* which of the rules to use */ > } lsm[MAX_LSM_RULES]; > char *fsname; > struct ima_rule_opt_list *keyrings; /* Measure keys added to these keyrings */
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com> To: Casey Schaufler <casey@schaufler-ca.com>, casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Cc: john.johansen@canonical.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, sds@tycho.nsa.gov Subject: Re: [PATCH v24 04/25] IMA: avoid label collisions with stacked LSMs Date: Mon, 22 Feb 2021 19:27:07 -0500 [thread overview] Message-ID: <3862fed24a1265611f71327ddb444e52557bdc7c.camel@linux.ibm.com> (raw) In-Reply-To: <77ebed19-2912-d8f2-cb4d-3f782c8e7f18@schaufler-ca.com> On Mon, 2021-02-22 at 15:45 -0800, Casey Schaufler wrote: > On 2/14/2021 10:21 AM, Mimi Zohar wrote: > > Would these changes match your suggestion? > > security/integrity/ima/ima_policy.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c > index 9ac673472781..e80956548243 100644 > --- a/security/integrity/ima/ima_policy.c > +++ b/security/integrity/ima/ima_policy.c > @@ -78,11 +78,11 @@ struct ima_rule_entry { > bool (*uid_op)(kuid_t, kuid_t); /* Handlers for operators */ > bool (*fowner_op)(kuid_t, kuid_t); /* uid_eq(), uid_gt(), uid_lt() */ > int pcr; > + int which_lsm; /* which of the rules to use */ > struct { > void *rules[LSMBLOB_ENTRIES]; /* LSM file metadata specific */ If each IMA policy rule may only contain a single LSM specific LSM_OBJ_{USER | ROLE | TYPE} and LSM_SUBJ_{USER | ROLE | TYPE}, then there is no need for rules[LSMBLOB_ENTRIES]. Leave it as "*rule". Otherwise it looks good. Mimi > char *args_p; /* audit value */ > int type; /* audit type */ > - int which_lsm; /* which of the rules to use */ > } lsm[MAX_LSM_RULES]; > char *fsname; > struct ima_rule_opt_list *keyrings; /* Measure keys added to these keyrings */ -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-02-23 0:28 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20210126164108.1958-1-casey.ref@schaufler-ca.com> 2021-01-26 16:40 ` [PATCH v24 00/25] LSM: Module stacking for AppArmor Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 01/25] LSM: Infrastructure management of the sock security Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 02/25] LSM: Add the lsmblob data structure Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 03/25] LSM: provide lsm name and id slot mappings Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 04/25] IMA: avoid label collisions with stacked LSMs Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-02-14 18:21 ` Mimi Zohar 2021-02-16 15:26 ` Casey Schaufler 2021-02-16 15:26 ` Casey Schaufler 2021-02-22 23:45 ` Casey Schaufler 2021-02-22 23:45 ` Casey Schaufler 2021-02-23 0:27 ` Mimi Zohar [this message] 2021-02-23 0:27 ` Mimi Zohar 2021-01-26 16:40 ` [PATCH v24 05/25] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 06/25] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 07/25] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 08/25] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 09/25] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 10/25] LSM: Use lsmblob in security_task_getsecid Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 11/25] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 12/25] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 13/25] IMA: Change internal interfaces to use lsmblobs Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 14/25] LSM: Specify which LSM to display Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 15/25] LSM: Ensure the correct LSM context releaser Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:40 ` [PATCH v24 16/25] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler 2021-01-26 16:40 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 17/25] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 18/25] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 19/25] NET: Store LSM netlabel data in a lsmblob Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 20/25] LSM: Verify LSM display sanity in binder Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 21/25] audit: add support for non-syscall auxiliary records Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 18:42 ` Richard Guy Briggs 2021-01-26 18:42 ` Richard Guy Briggs 2021-01-26 18:58 ` Casey Schaufler 2021-01-26 18:58 ` Casey Schaufler 2021-01-26 20:05 ` Paul Moore 2021-01-26 20:05 ` Paul Moore 2021-01-26 20:22 ` Richard Guy Briggs 2021-01-26 20:22 ` Richard Guy Briggs 2021-01-26 16:41 ` [PATCH v24 22/25] Audit: Add new record for multiple process LSM attributes Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 23/25] Audit: Add a new record for multiple object " Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 24/25] LSM: Add /proc attr entry for full LSM context Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-01-26 16:41 ` [PATCH v24 25/25] AppArmor: Remove the exclusive flag Casey Schaufler 2021-01-26 16:41 ` Casey Schaufler 2021-02-02 12:05 ` [PATCH v24 00/25] LSM: Module stacking for AppArmor Topi Miettinen 2021-02-02 12:05 ` Topi Miettinen 2021-02-02 15:30 ` Casey Schaufler 2021-02-02 15:30 ` Casey Schaufler 2021-02-02 17:12 ` Topi Miettinen 2021-02-02 17:12 ` Topi Miettinen 2021-02-02 18:06 ` Casey Schaufler 2021-02-02 18:06 ` Casey Schaufler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3862fed24a1265611f71327ddb444e52557bdc7c.camel@linux.ibm.com \ --to=zohar@linux.ibm.com \ --cc=casey.schaufler@intel.com \ --cc=casey@schaufler-ca.com \ --cc=jmorris@namei.org \ --cc=john.johansen@canonical.com \ --cc=keescook@chromium.org \ --cc=linux-audit@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=penguin-kernel@i-love.sakura.ne.jp \ --cc=sds@tycho.nsa.gov \ --cc=selinux@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.