All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: fix duplicated code
@ 2017-03-21  2:10 Chunming Zhou
       [not found] ` <1490062243-547-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Chunming Zhou @ 2017-03-21  2:10 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Chunming Zhou

it could come from branch merge.

Change-Id: I16959aad6ca6d64cb8330f23ee6472eec4cf2a3e
Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 81c3c75..dd7df45 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -990,10 +990,6 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev,
 
 	ring = container_of(vm->entity.sched, struct amdgpu_ring, sched);
 
-	memset(&params, 0, sizeof(params));
-	params.adev = adev;
-	params.src = src;
-
 	/* sync to everything on unmapping */
 	if (!(flags & AMDGPU_PTE_VALID))
 		owner = AMDGPU_FENCE_OWNER_UNDEFINED;
-- 
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix duplicated code
       [not found] ` <1490062243-547-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
@ 2017-03-21  2:34   ` Jerry Zhang
       [not found]     ` <58D0911F.9070601-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Jerry Zhang @ 2017-03-21  2:34 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW


On 03/21/2017 10:10 AM, Chunming Zhou wrote:
> it could come from branch merge.
>
> Change-Id: I16959aad6ca6d64cb8330f23ee6472eec4cf2a3e
> Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 81c3c75..dd7df45 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -990,10 +990,6 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev,
>
>   	ring = container_of(vm->entity.sched, struct amdgpu_ring, sched);
>
> -	memset(&params, 0, sizeof(params));
> -	params.adev = adev;
> -	params.src = src;
> -
>   	/* sync to everything on unmapping */
>   	if (!(flags & AMDGPU_PTE_VALID))
>   		owner = AMDGPU_FENCE_OWNER_UNDEFINED;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix duplicated code
       [not found]     ` <58D0911F.9070601-5C7GfCeVMHo@public.gmane.org>
@ 2017-03-21  6:37       ` Christian König
  0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2017-03-21  6:37 UTC (permalink / raw)
  To: Jerry Zhang, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 21.03.2017 um 03:34 schrieb Jerry Zhang:
>
> On 03/21/2017 10:10 AM, Chunming Zhou wrote:
>> it could come from branch merge.
>>
>> Change-Id: I16959aad6ca6d64cb8330f23ee6472eec4cf2a3e
>> Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
> Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 81c3c75..dd7df45 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -990,10 +990,6 @@ static int amdgpu_vm_bo_update_mapping(struct 
>> amdgpu_device *adev,
>>
>>       ring = container_of(vm->entity.sched, struct amdgpu_ring, sched);
>>
>> -    memset(&params, 0, sizeof(params));
>> -    params.adev = adev;
>> -    params.src = src;
>> -
>>       /* sync to everything on unmapping */
>>       if (!(flags & AMDGPU_PTE_VALID))
>>           owner = AMDGPU_FENCE_OWNER_UNDEFINED;
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-21  6:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21  2:10 [PATCH] drm/amdgpu: fix duplicated code Chunming Zhou
     [not found] ` <1490062243-547-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-03-21  2:34   ` Jerry Zhang
     [not found]     ` <58D0911F.9070601-5C7GfCeVMHo@public.gmane.org>
2017-03-21  6:37       ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.