* [RFC patch] clean up swiotlb check in intel_iommu_init
@ 2009-08-13 3:11 Luming Yu
2009-08-13 3:25 ` FUJITA Tomonori
2009-08-13 8:23 ` David Woodhouse
0 siblings, 2 replies; 5+ messages in thread
From: Luming Yu @ 2009-08-13 3:11 UTC (permalink / raw)
To: David Woodhouse, Yu, Fenghua, Luck, Tony, LKML, FUJITA Tomonori
Cc: Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
Hi there,
Since swiotlb is an fall back option that might have
initialized. We don't need to stop intel_iommu_init
because of swiotlb..
Please review. If make sense, please apply.
**The patch is enclosed in text attachment*
**Using web client to send the patch* *
**below is for review, please apply attached patch*/
Thanks,
Luming
Signed-off-by: Yu Luming <luming.yu@intel.com>
intel-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index 2314ad7..246acb9 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
* Check the need for DMA-remapping initialization now.
* Above initialization will also be used by Interrupt-remapping.
*/
- if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
+ if (no_iommu || dmar_disabled)
return -ENODEV;
iommu_init_mempool();
[-- Attachment #2: 6 --]
[-- Type: application/octet-stream, Size: 496 bytes --]
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index 2314ad7..246acb9 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
* Check the need for DMA-remapping initialization now.
* Above initialization will also be used by Interrupt-remapping.
*/
- if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
+ if (no_iommu || dmar_disabled)
return -ENODEV;
iommu_init_mempool();
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC patch] clean up swiotlb check in intel_iommu_init
2009-08-13 3:11 [RFC patch] clean up swiotlb check in intel_iommu_init Luming Yu
@ 2009-08-13 3:25 ` FUJITA Tomonori
2009-08-13 6:02 ` Luming Yu
2009-08-13 8:23 ` David Woodhouse
1 sibling, 1 reply; 5+ messages in thread
From: FUJITA Tomonori @ 2009-08-13 3:25 UTC (permalink / raw)
To: luming.yu
Cc: dwmw2, fenghua.yu, tony.luck, linux-kernel, fujita.tomonori, akpm
On Thu, 13 Aug 2009 11:11:27 +0800
Luming Yu <luming.yu@gmail.com> wrote:
> Hi there,
>
> Since swiotlb is an fall back option that might have
> initialized. We don't need to stop intel_iommu_init
> because of swiotlb..
I think that this doesn't work on X86; breaks "soft" boot option.
> Please review. If make sense, please apply.
>
> **The patch is enclosed in text attachment*
> **Using web client to send the patch* *
> **below is for review, please apply attached patch*/
>
> Thanks,
> Luming
>
> Signed-off-by: Yu Luming <luming.yu@intel.com>
>
> intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
> index 2314ad7..246acb9 100644
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
> * Check the need for DMA-remapping initialization now.
> * Above initialization will also be used by Interrupt-remapping.
> */
> - if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
> + if (no_iommu || dmar_disabled)
> return -ENODEV;
>
> iommu_init_mempool();
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC patch] clean up swiotlb check in intel_iommu_init
2009-08-13 3:25 ` FUJITA Tomonori
@ 2009-08-13 6:02 ` Luming Yu
0 siblings, 0 replies; 5+ messages in thread
From: Luming Yu @ 2009-08-13 6:02 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: dwmw2, fenghua.yu, tony.luck, linux-kernel, akpm
>>
>> Since swiotlb is an fall back option that might have
>> initialized. We don't need to stop intel_iommu_init
>> because of swiotlb..
>
> I think that this doesn't work on X86; breaks "soft" boot option.
Assumption is that swiotlb is default dma_ops.
I got this patch when working on ia64, will check x86 later.
But it is only needed when most of us agree that swiotlb should be
the default.
>
>
>> Please review. If make sense, please apply.
>>
>> **The patch is enclosed in text attachment*
>> **Using web client to send the patch* *
>> **below is for review, please apply attached patch*/
>>
>> Thanks,
>> Luming
>>
>> Signed-off-by: Yu Luming <luming.yu@intel.com>
>>
>> intel-iommu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
>> index 2314ad7..246acb9 100644
>> --- a/drivers/pci/intel-iommu.c
>> +++ b/drivers/pci/intel-iommu.c
>> @@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
>> * Check the need for DMA-remapping initialization now.
>> * Above initialization will also be used by Interrupt-remapping.
>> */
>> - if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
>> + if (no_iommu || dmar_disabled)
>> return -ENODEV;
>>
>> iommu_init_mempool();
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC patch] clean up swiotlb check in intel_iommu_init
2009-08-13 3:11 [RFC patch] clean up swiotlb check in intel_iommu_init Luming Yu
2009-08-13 3:25 ` FUJITA Tomonori
@ 2009-08-13 8:23 ` David Woodhouse
2009-08-13 8:51 ` Luming Yu
1 sibling, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2009-08-13 8:23 UTC (permalink / raw)
To: Luming Yu; +Cc: Yu, Fenghua, Luck, Tony, LKML, FUJITA Tomonori, Andrew Morton
On Thu, 2009-08-13 at 11:11 +0800, Luming Yu wrote:
>
> Since swiotlb is an fall back option that might have
> initialized. We don't need to stop intel_iommu_init
> because of swiotlb..
>
> Please review. If make sense, please apply.
It doesn't apply to the iommu-2.6.git tree.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC patch] clean up swiotlb check in intel_iommu_init
2009-08-13 8:23 ` David Woodhouse
@ 2009-08-13 8:51 ` Luming Yu
0 siblings, 0 replies; 5+ messages in thread
From: Luming Yu @ 2009-08-13 8:51 UTC (permalink / raw)
To: David Woodhouse
Cc: Yu, Fenghua, Luck, Tony, LKML, FUJITA Tomonori, Andrew Morton
On Thu, Aug 13, 2009 at 4:23 PM, David Woodhouse<dwmw2@infradead.org> wrote:
> On Thu, 2009-08-13 at 11:11 +0800, Luming Yu wrote:
>>
>> Since swiotlb is an fall back option that might have
>> initialized. We don't need to stop intel_iommu_init
>> because of swiotlb..
>>
>> Please review. If make sense, please apply.
>
> It doesn't apply to the iommu-2.6.git tree.
The patch is against 31-rc5.
If you were not using the attached patch, then I need to use another
mail client to re-send the patch to you. But it is not as convenient
as web gmail
that I'm current using...
If I must generate patch against iommu-2.6.git tree, please point out
the url of that tree,
I can refresh this patch later.
Please let me know what I should do to push this patch in..
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-08-13 8:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-13 3:11 [RFC patch] clean up swiotlb check in intel_iommu_init Luming Yu
2009-08-13 3:25 ` FUJITA Tomonori
2009-08-13 6:02 ` Luming Yu
2009-08-13 8:23 ` David Woodhouse
2009-08-13 8:51 ` Luming Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.