All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Suzuki K Poulose <Suzuki.Poulose@arm.com>,
	kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v3 4/6] KVM: arm/arm64: Consolidate page-table accessors
Date: Wed, 27 Jun 2018 15:53:45 +0100	[thread overview]
Message-ID: <38b5b90d-131f-ebd2-7a0f-491b92cf9f38@arm.com> (raw)
In-Reply-To: <0afbb729-d801-1563-a319-4d3e3d6ac6a9@arm.com>

On 27/06/18 14:59, Suzuki K Poulose wrote:
> Marc,
> 
> On 27/06/18 13:20, Marc Zyngier wrote:
>> The arm and arm64 KVM page tables accessors are pointlessly different
>> between the two architectures, and likely both wrong one way or another:
>> arm64 lacks a dsb(), and arm doesn't use WRITE_ONCE.
>>
>> Let's unify them.
> 
> nit: Feel free to ignore. The changes introducing kvm_p.d_populate
> is not mentioned in the commit description and they do look a bit
> disconnected from the change described above.

That's a good point. I've moved those into patch #5, where they make
much more sense.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] KVM: arm/arm64: Consolidate page-table accessors
Date: Wed, 27 Jun 2018 15:53:45 +0100	[thread overview]
Message-ID: <38b5b90d-131f-ebd2-7a0f-491b92cf9f38@arm.com> (raw)
In-Reply-To: <0afbb729-d801-1563-a319-4d3e3d6ac6a9@arm.com>

On 27/06/18 14:59, Suzuki K Poulose wrote:
> Marc,
> 
> On 27/06/18 13:20, Marc Zyngier wrote:
>> The arm and arm64 KVM page tables accessors are pointlessly different
>> between the two architectures, and likely both wrong one way or another:
>> arm64 lacks a dsb(), and arm doesn't use WRITE_ONCE.
>>
>> Let's unify them.
> 
> nit: Feel free to ignore. The changes introducing kvm_p.d_populate
> is not mentioned in the commit description and they do look a bit
> disconnected from the change described above.

That's a good point. I've moved those into patch #5, where they make
much more sense.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2018-06-27 14:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 12:20 [PATCH v3 0/6] KVM/arm64: Cache maintenance relaxations Marc Zyngier
2018-06-27 12:20 ` Marc Zyngier
2018-06-27 12:20 ` [PATCH v3 1/6] arm64: KVM: Add support for Stage-2 control of memory types and cacheability Marc Zyngier
2018-06-27 12:20   ` Marc Zyngier
2018-06-27 16:20   ` Suzuki K Poulose
2018-06-27 16:20     ` Suzuki K Poulose
2018-06-27 16:36     ` Marc Zyngier
2018-06-27 16:36       ` Marc Zyngier
2018-06-28 20:56   ` Christoffer Dall
2018-06-28 20:56     ` Christoffer Dall
2018-06-29  8:09     ` Marc Zyngier
2018-06-29  8:09       ` Marc Zyngier
2018-06-29  9:07       ` Christoffer Dall
2018-06-29  9:07         ` Christoffer Dall
2018-06-29  9:21         ` Marc Zyngier
2018-06-29  9:21           ` Marc Zyngier
2018-06-29  9:28           ` Christoffer Dall
2018-06-29  9:28             ` Christoffer Dall
2018-06-27 12:20 ` [PATCH v3 2/6] arm64: KVM: Handle Set/Way CMOs as NOPs if FWB is present Marc Zyngier
2018-06-27 12:20   ` Marc Zyngier
2018-06-27 12:20 ` [PATCH v3 3/6] arm64: KVM: Avoid marking pages as XN in Stage-2 if CTR_EL0.DIC is set Marc Zyngier
2018-06-27 12:20   ` Marc Zyngier
2018-06-27 12:20 ` [PATCH v3 4/6] KVM: arm/arm64: Consolidate page-table accessors Marc Zyngier
2018-06-27 12:20   ` Marc Zyngier
2018-06-27 13:59   ` Suzuki K Poulose
2018-06-27 13:59     ` Suzuki K Poulose
2018-06-27 14:53     ` Marc Zyngier [this message]
2018-06-27 14:53       ` Marc Zyngier
2018-06-27 12:20 ` [PATCH v3 5/6] KVM: arm/arm64: Stop using {pmd,pud,pgd}_populate Marc Zyngier
2018-06-27 12:20   ` Marc Zyngier
2018-06-27 13:47   ` Suzuki K Poulose
2018-06-27 13:47     ` Suzuki K Poulose
2018-06-27 14:45     ` Marc Zyngier
2018-06-27 14:45       ` Marc Zyngier
2018-06-27 12:20 ` [PATCH v3 6/6] KVM: arm/arm64: Remove unnecessary CMOs when creating HYP page tables Marc Zyngier
2018-06-27 12:20   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38b5b90d-131f-ebd2-7a0f-491b92cf9f38@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=Suzuki.Poulose@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.