All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Alistair Popple <alistair@popple.id.au>,
	Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [RFC PATCH linux dev-4.7 4/6] misc: Add Aspeed BT IPMI BMC driver
Date: Thu, 15 Sep 2016 09:37:22 +0200	[thread overview]
Message-ID: <38b843b7-24ec-7089-154c-262106afd50c@kaod.org> (raw)
In-Reply-To: <CACPK8XeB+y5SVzJvoWSAr5hsufZw0hVm6RKUGVNtocawBWPQ7A@mail.gmail.com>

On 09/15/2016 09:09 AM, Joel Stanley wrote:
> On Thu, Sep 15, 2016 at 4:02 PM, Cédric Le Goater <clg@kaod.org> wrote:
>> From: Alistair Popple <alistair@popple.id.au>
>>
>> This patch adds a simple device driver to expose the iBT interface on
>> Aspeed SOCs (AST2400 and AST2500) as a character device :
>> /dev/ipmi-bt-bmc.
>>
>> The BT (Block Transfer) interface is used to perform in-band IPMI
>> communication from a BMC to the host. Entire messages are buffered
>> before sending a notification to the host, or the BMC when on the
>> other side, that there is data to be read. The driver implements the
>> BMC side of the BT interface.
>>
>> Signed-off-by: Alistair Popple <alistair@popple.id.au>
>> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> [clg: - did some checkpatch fixes
>>       - added a devicetree binding documentation
>>       - renamed 'bt_host' to 'bt_bmc' to reflect that the driver is
>>         the BMC side of the IPMI BT interface
>>       - remaned the device name to 'ipmi-bt-bmc'
> 
> I'm not sure there. When I open /dev/ttyUSB0 I'm talking to the USB0
> serial device. When I open /dev/mtd0, I'm talking to the mtd0 device.
> So when I open /dev/ipmi-bt-bmc, I would expect to talk to the BMC
> device?

Yes. I went a little too far in the global rename. /dev/ipmi-bt-bmc makes 
more sense or just '/dev/ipmi-bt' because we won't have multiple hosts
to control.

C.

  reply	other threads:[~2016-09-15  7:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  6:32 [RFC PATCH linux dev-4.7 0/6] iBT interface changes Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 1/6] Revert "misc: Add Aspeed BT IPMI host driver" Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 2/6] ARM: aspeed: remove previous definitions in default config Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 3/6] ARM: dts: aspeed: remove previous iBT definitions Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 4/6] misc: Add Aspeed BT IPMI BMC driver Cédric Le Goater
2016-09-15  7:09   ` Joel Stanley
2016-09-15  7:37     ` Cédric Le Goater [this message]
2016-09-15  8:36       ` Cédric Le Goater
2016-09-15 10:03         ` Joel Stanley
2016-09-15 10:42           ` Cédric Le Goater
2016-09-15 10:51         ` Patrick Williams
2016-09-15 11:22           ` Cédric Le Goater
2016-09-15 11:33             ` Patrick Williams
2016-09-15 14:02               ` Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 5/6] ARM: aspeed: Add defconfigs for CONFIG_ASPEED_BT_IPMI_BMC Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 6/6] ARM: dts: aspeed: Enable BT IPMI BMC device Cédric Le Goater
2016-09-15  7:11   ` Joel Stanley
2016-09-15  7:55     ` Cédric Le Goater
2016-09-23  6:14 ` [RFC PATCH linux dev-4.7 0/6] iBT interface changes Joel Stanley
2016-09-23 13:22   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38b843b7-24ec-7089-154c-262106afd50c@kaod.org \
    --to=clg@kaod.org \
    --cc=alistair@popple.id.au \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.