All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [RFC PATCH linux dev-4.7 6/6] ARM: dts: aspeed: Enable BT IPMI BMC device
Date: Thu, 15 Sep 2016 16:41:49 +0930	[thread overview]
Message-ID: <CACPK8XdcvGKeTR5v_PZ_kwTydLjWS6FXkvdi=HWNV7KRxTLLVw@mail.gmail.com> (raw)
In-Reply-To: <1473921146-19509-7-git-send-email-clg@kaod.org>

On Thu, Sep 15, 2016 at 4:02 PM, Cédric Le Goater <clg@kaod.org> wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++
>  2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index eb0122fa34c2..4480b858103e 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -391,6 +391,12 @@
>                                 clocks = <&clk_apb>;
>                         };
>
> +                       ibt: ibt@1e789140 {

Given this is part of the LPC register set, and we need to expose
other parts of the LPC, I was wondering if we wanted to make this a
sub-node of a mfd device that covered all of the LPC controller's
registers. What do you think?

> +                               compatible = "aspeed,bt-bmc";

When getting bindings reviewed I've been told we should have something
soc specific in the string, like aspeed,ast2400-bt-bmc. I'm to too
fussed though.

> +                               reg = <0x1e789140 0x18>;
> +                               interrupts = <8>;
> +                       };
> +
>                         wdt1: wdt@1e785000 {
>                                 compatible = "aspeed,ast2400-wdt";
>                                 reg = <0x1e785000 0x1c>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 79abac876abf..7c781fb613f8 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -255,6 +255,12 @@
>                                 clocks = <&clk_apb>;
>                         };
>
> +                       ibt: ibt@1e789140 {
> +                               compatible = "aspeed,bt-bmc";
> +                               reg = <0x1e789140 0x18>;
> +                               interrupts = <8>;
> +                       };
> +
>                         wdt1: wdt@1e785000 {
>                                 compatible = "aspeed,ast2500-wdt";
>                                 reg = <0x1e785000 0x1c>;
> --
> 2.7.4
>

  reply	other threads:[~2016-09-15  7:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  6:32 [RFC PATCH linux dev-4.7 0/6] iBT interface changes Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 1/6] Revert "misc: Add Aspeed BT IPMI host driver" Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 2/6] ARM: aspeed: remove previous definitions in default config Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 3/6] ARM: dts: aspeed: remove previous iBT definitions Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 4/6] misc: Add Aspeed BT IPMI BMC driver Cédric Le Goater
2016-09-15  7:09   ` Joel Stanley
2016-09-15  7:37     ` Cédric Le Goater
2016-09-15  8:36       ` Cédric Le Goater
2016-09-15 10:03         ` Joel Stanley
2016-09-15 10:42           ` Cédric Le Goater
2016-09-15 10:51         ` Patrick Williams
2016-09-15 11:22           ` Cédric Le Goater
2016-09-15 11:33             ` Patrick Williams
2016-09-15 14:02               ` Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 5/6] ARM: aspeed: Add defconfigs for CONFIG_ASPEED_BT_IPMI_BMC Cédric Le Goater
2016-09-15  6:32 ` [RFC PATCH linux dev-4.7 6/6] ARM: dts: aspeed: Enable BT IPMI BMC device Cédric Le Goater
2016-09-15  7:11   ` Joel Stanley [this message]
2016-09-15  7:55     ` Cédric Le Goater
2016-09-23  6:14 ` [RFC PATCH linux dev-4.7 0/6] iBT interface changes Joel Stanley
2016-09-23 13:22   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8XdcvGKeTR5v_PZ_kwTydLjWS6FXkvdi=HWNV7KRxTLLVw@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=clg@kaod.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.