From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Harry Austen <hpausten@protonmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Yassine Oudjana <y.oudjana@protonmail.com>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: boot: dts: msm8996: add blsp1_i2c6 node
Date: Fri, 21 Oct 2022 10:36:50 -0400 [thread overview]
Message-ID: <38c21467-8970-eefa-7dd2-3f2ed3364afb@linaro.org> (raw)
In-Reply-To: <20221021142242.129276-3-hpausten@protonmail.com>
On 21/10/2022 10:24, Harry Austen wrote:
> Add support for the sixth I2C interface on the MSM8996 SoC.
>
> Signed-off-by: Harry Austen <hpausten@protonmail.com>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 31 +++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 80590267dfd0..70c0eae17360 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1400,6 +1400,20 @@ pwdn {
> };
> };
>
> + blsp1_i2c6_default: blsp1_i2c6 {
No underscores in node names.
Missing "state" suffix. See:
https://lore.kernel.org/linux-arm-msm/20221018155721.47140-1-krzysztof.kozlowski@linaro.org/
Bindings are already in next.
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
> + pins = "gpio27", "gpio28";
> + function = "blsp_i2c6";
> + drive-strength = <16>;
> + bias-disable;
> + };
> +
> + blsp1_i2c6_sleep: blsp1_i2c6_sleep {
> + pins = "gpio27", "gpio28";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-21 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 14:23 [PATCH 0/4] Initial OnePlus 3(T) Support Harry Austen
2022-10-21 14:23 ` [PATCH 1/4] arm64: dts: qcom: msm8996: standardize blsp indexing Harry Austen
2022-10-21 14:24 ` [PATCH 2/4] arm64: boot: dts: msm8996: add blsp1_i2c6 node Harry Austen
2022-10-21 14:36 ` Krzysztof Kozlowski [this message]
2022-10-21 14:24 ` [PATCH 3/4] dt-bindings: arm: qcom: add oneplus3(t) devices Harry Austen
2022-10-21 14:37 ` Krzysztof Kozlowski
2022-10-21 14:24 ` [PATCH 4/4] arm64: dts: qcom: msm8996: add support for oneplus3(t) Harry Austen
2022-10-21 14:44 ` Krzysztof Kozlowski
2022-10-22 10:38 ` Harry Austen
2022-10-22 15:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c21467-8970-eefa-7dd2-3f2ed3364afb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hpausten@protonmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=y.oudjana@protonmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.