All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] docs qemu-doc: Avoid ide-drive, it's deprecated
Date: Tue, 9 May 2017 11:53:25 +0200	[thread overview]
Message-ID: <38c73cb6-b128-0aab-3c4e-ffa9f402dcda@redhat.com> (raw)
In-Reply-To: <1494322876-28843-2-git-send-email-armbru@redhat.com>

On 09.05.2017 11:41, Markus Armbruster wrote:
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/bootindex.txt       | 2 +-
>  docs/qdev-device-use.txt | 4 ++--
>  qemu-options.hx          | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/bootindex.txt b/docs/bootindex.txt
> index b9a8ba1..6937862 100644
> --- a/docs/bootindex.txt
> +++ b/docs/bootindex.txt
> @@ -13,7 +13,7 @@ Let's assume we have a QEMU machine with two NICs (virtio, e1000) and two
>  disks (IDE, virtio):
>  
>  qemu -drive file=disk1.img,if=none,id=disk1
> -     -device ide-drive,drive=disk1,bootindex=4
> +     -device ide-hd,drive=disk1,bootindex=4
>       -drive file=disk2.img,if=none,id=disk2
>       -device virtio-blk-pci,drive=disk2,bootindex=3
>       -netdev type=user,id=net0 -device virtio-net-pci,netdev=net0,bootindex=2
> diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt
> index b059405..caf779b 100644
> --- a/docs/qdev-device-use.txt
> +++ b/docs/qdev-device-use.txt
> @@ -31,8 +31,8 @@ A QEMU block device (drive) has a host and a guest part.
>  
>  In the general case, the guest device is connected to a controller
>  device.  For instance, the IDE controller provides two IDE buses, each
> -of which can have up to two ide-drive devices, and each ide-drive
> -device is a guest part, and is connected to a host part.
> +of which can have up to two devices, and each device is a guest part,
> +and is connected to a host part.
>  
>  Except we sometimes lump controller, bus(es) and drive device(s) all
>  together into a single device.  For instance, the ISA floppy
> diff --git a/qemu-options.hx b/qemu-options.hx
> index f68829f..37147b3 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -224,7 +224,7 @@ STEXI
>  Set default value of @var{driver}'s property @var{prop} to @var{value}, e.g.:
>  
>  @example
> -qemu-system-i386 -global ide-drive.physical_block_size=4096 -drive file=file,if=ide,index=0,media=disk
> +qemu-system-i386 -global ide-hd.physical_block_size=4096 disk-image.img
>  @end example
>  
>  In particular, you can use this to set driver properties for devices which are 
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

  reply	other threads:[~2017-05-09  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09  9:41 [Qemu-devel] [PATCH 0/2] docs: Minor updates around ide-drive Markus Armbruster
2017-05-09  9:41 ` [Qemu-devel] [PATCH 1/2] docs qemu-doc: Avoid ide-drive, it's deprecated Markus Armbruster
2017-05-09  9:53   ` Thomas Huth [this message]
2017-05-09  9:41 ` [Qemu-devel] [PATCH 2/2] docs/qdev-device-use.txt: update section Default Devices Markus Armbruster
2017-05-09  9:59   ` Thomas Huth
2017-05-09  9:48 ` [Qemu-devel] [PATCH 0/2] docs: Minor updates around ide-drive Markus Armbruster
2017-05-09 14:14 ` John Snow
2017-05-23 11:30   ` Markus Armbruster
2017-05-23 14:56     ` Markus Armbruster
2017-05-23 15:47       ` John Snow
2017-05-23 14:38 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38c73cb6-b128-0aab-3c4e-ffa9f402dcda@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.