* [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-03 14:35 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-03 14:35 UTC (permalink / raw)
To: Mark Brown, Pierre-Louis Bossart, Peter Ujfalusi,
sound-open-firmware, alsa-devel, linux-kernel
Cc: Liam Girdwood, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Daniel Baluta, Jaroslav Kysela, Takashi Iwai, Andy Shevchenko
device_get_match_data() in ACPI case calls similar to acpi_match_device().
Hence there is no need to duplicate the call. Just assign what is in
the id->driver_data.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/sof/intel/bdw.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 26df780c702e..346813aa3768 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -674,6 +674,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
id = acpi_match_device(dev->driver->acpi_match_table, dev);
if (!id)
return -ENODEV;
+ desc = (const struct sof_dev_desc *)id->driver_data;
ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {
@@ -681,11 +682,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
return -ENODEV;
}
- desc = device_get_match_data(dev);
- if (!desc)
- return -ENODEV;
-
- return sof_acpi_probe(pdev, device_get_match_data(dev));
+ return sof_acpi_probe(pdev, desc);
}
/* acpi_driver definition */
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-03 14:35 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-03 14:35 UTC (permalink / raw)
To: Mark Brown, Pierre-Louis Bossart, Peter Ujfalusi,
sound-open-firmware, alsa-devel, linux-kernel
Cc: Kai Vehmanen, Bard Liao, Takashi Iwai, Liam Girdwood,
Ranjani Sridharan, Andy Shevchenko, Daniel Baluta
device_get_match_data() in ACPI case calls similar to acpi_match_device().
Hence there is no need to duplicate the call. Just assign what is in
the id->driver_data.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/sof/intel/bdw.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 26df780c702e..346813aa3768 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -674,6 +674,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
id = acpi_match_device(dev->driver->acpi_match_table, dev);
if (!id)
return -ENODEV;
+ desc = (const struct sof_dev_desc *)id->driver_data;
ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {
@@ -681,11 +682,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
return -ENODEV;
}
- desc = device_get_match_data(dev);
- if (!desc)
- return -ENODEV;
-
- return sof_acpi_probe(pdev, device_get_match_data(dev));
+ return sof_acpi_probe(pdev, desc);
}
/* acpi_driver definition */
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
2022-07-03 14:35 ` Andy Shevchenko
@ 2022-07-04 7:31 ` Péter Ujfalusi
-1 siblings, 0 replies; 14+ messages in thread
From: Péter Ujfalusi @ 2022-07-04 7:31 UTC (permalink / raw)
To: Andy Shevchenko, Mark Brown, Pierre-Louis Bossart,
sound-open-firmware, alsa-devel, linux-kernel
Cc: Liam Girdwood, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Daniel Baluta, Jaroslav Kysela, Takashi Iwai
On 03/07/2022 17:35, Andy Shevchenko wrote:
> device_get_match_data() in ACPI case calls similar to acpi_match_device().
> Hence there is no need to duplicate the call. Just assign what is in
> the id->driver_data.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/soc/sof/intel/bdw.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
> index 26df780c702e..346813aa3768 100644
> --- a/sound/soc/sof/intel/bdw.c
> +++ b/sound/soc/sof/intel/bdw.c
> @@ -674,6 +674,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> id = acpi_match_device(dev->driver->acpi_match_table, dev);
> if (!id)
> return -ENODEV;
> + desc = (const struct sof_dev_desc *)id->driver_data;
>
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {
> @@ -681,11 +682,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - desc = device_get_match_data(dev);
> - if (!desc)
> - return -ENODEV;
> -
> - return sof_acpi_probe(pdev, device_get_match_data(dev));
> + return sof_acpi_probe(pdev, desc);
> }
Would it not be simpler to just:
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 26df780c702e..2ee22c2772ba 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -668,7 +668,6 @@ static int sof_broadwell_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
const struct acpi_device_id *id;
- const struct sof_dev_desc *desc;
int ret;
id = acpi_match_device(dev->driver->acpi_match_table, dev);
@@ -681,11 +680,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
return -ENODEV;
}
- desc = device_get_match_data(dev);
- if (!desc)
- return -ENODEV;
-
- return sof_acpi_probe(pdev, device_get_match_data(dev));
+ return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
}
/* acpi_driver definition */
---
We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
--
Péter
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-04 7:31 ` Péter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Péter Ujfalusi @ 2022-07-04 7:31 UTC (permalink / raw)
To: Andy Shevchenko, Mark Brown, Pierre-Louis Bossart,
sound-open-firmware, alsa-devel, linux-kernel
Cc: Kai Vehmanen, Bard Liao, Takashi Iwai, Liam Girdwood,
Ranjani Sridharan, Daniel Baluta
On 03/07/2022 17:35, Andy Shevchenko wrote:
> device_get_match_data() in ACPI case calls similar to acpi_match_device().
> Hence there is no need to duplicate the call. Just assign what is in
> the id->driver_data.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/soc/sof/intel/bdw.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
> index 26df780c702e..346813aa3768 100644
> --- a/sound/soc/sof/intel/bdw.c
> +++ b/sound/soc/sof/intel/bdw.c
> @@ -674,6 +674,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> id = acpi_match_device(dev->driver->acpi_match_table, dev);
> if (!id)
> return -ENODEV;
> + desc = (const struct sof_dev_desc *)id->driver_data;
>
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {
> @@ -681,11 +682,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - desc = device_get_match_data(dev);
> - if (!desc)
> - return -ENODEV;
> -
> - return sof_acpi_probe(pdev, device_get_match_data(dev));
> + return sof_acpi_probe(pdev, desc);
> }
Would it not be simpler to just:
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 26df780c702e..2ee22c2772ba 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -668,7 +668,6 @@ static int sof_broadwell_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
const struct acpi_device_id *id;
- const struct sof_dev_desc *desc;
int ret;
id = acpi_match_device(dev->driver->acpi_match_table, dev);
@@ -681,11 +680,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
return -ENODEV;
}
- desc = device_get_match_data(dev);
- if (!desc)
- return -ENODEV;
-
- return sof_acpi_probe(pdev, device_get_match_data(dev));
+ return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
}
/* acpi_driver definition */
---
We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
--
Péter
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
2022-07-04 7:31 ` Péter Ujfalusi
@ 2022-07-04 16:19 ` Andy Shevchenko
-1 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-04 16:19 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: Mark Brown, Pierre-Louis Bossart, sound-open-firmware,
alsa-devel, linux-kernel, Liam Girdwood, Bard Liao,
Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela,
Takashi Iwai
On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
> On 03/07/2022 17:35, Andy Shevchenko wrote:
...
> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
> }
> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
I prefer not to cast inside the function parameters when it's not about POD.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-04 16:19 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-04 16:19 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: Pierre-Louis Bossart, alsa-devel, Kai Vehmanen, Daniel Baluta,
Takashi Iwai, linux-kernel, Liam Girdwood, Mark Brown,
Ranjani Sridharan, Bard Liao, sound-open-firmware
On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
> On 03/07/2022 17:35, Andy Shevchenko wrote:
...
> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
> }
> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
I prefer not to cast inside the function parameters when it's not about POD.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
2022-07-04 16:19 ` Andy Shevchenko
@ 2022-07-05 12:09 ` Péter Ujfalusi
-1 siblings, 0 replies; 14+ messages in thread
From: Péter Ujfalusi @ 2022-07-05 12:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Pierre-Louis Bossart, alsa-devel, Kai Vehmanen, Daniel Baluta,
Takashi Iwai, linux-kernel, Liam Girdwood, Mark Brown,
Ranjani Sridharan, Bard Liao, sound-open-firmware
On 04/07/2022 19:19, Andy Shevchenko wrote:
> On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
>> On 03/07/2022 17:35, Andy Shevchenko wrote:
>
> ...
>
>> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
>> }
>
>> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
>
> I prefer not to cast inside the function parameters when it's not about POD.
Fair enough.
How about assigning desc before it is used?
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 26df780c702e..a446154f2803 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -681,11 +681,8 @@ static int sof_broadwell_probe(struct platform_device *pdev)
return -ENODEV;
}
- desc = device_get_match_data(dev);
- if (!desc)
- return -ENODEV;
-
- return sof_acpi_probe(pdev, device_get_match_data(dev));
+ desc = (const struct sof_dev_desc *)id->driver_data;
+ return sof_acpi_probe(pdev, desc);
}
/* acpi_driver definition */
--
Péter
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-05 12:09 ` Péter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Péter Ujfalusi @ 2022-07-05 12:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Mark Brown, Pierre-Louis Bossart, sound-open-firmware,
alsa-devel, linux-kernel, Liam Girdwood, Bard Liao,
Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela,
Takashi Iwai
On 04/07/2022 19:19, Andy Shevchenko wrote:
> On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
>> On 03/07/2022 17:35, Andy Shevchenko wrote:
>
> ...
>
>> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
>> }
>
>> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
>
> I prefer not to cast inside the function parameters when it's not about POD.
Fair enough.
How about assigning desc before it is used?
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 26df780c702e..a446154f2803 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -681,11 +681,8 @@ static int sof_broadwell_probe(struct platform_device *pdev)
return -ENODEV;
}
- desc = device_get_match_data(dev);
- if (!desc)
- return -ENODEV;
-
- return sof_acpi_probe(pdev, device_get_match_data(dev));
+ desc = (const struct sof_dev_desc *)id->driver_data;
+ return sof_acpi_probe(pdev, desc);
}
/* acpi_driver definition */
--
Péter
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
2022-07-03 14:35 ` Andy Shevchenko
@ 2022-07-05 14:42 ` Pierre-Louis Bossart
-1 siblings, 0 replies; 14+ messages in thread
From: Pierre-Louis Bossart @ 2022-07-05 14:42 UTC (permalink / raw)
To: Andy Shevchenko, Mark Brown, Peter Ujfalusi, sound-open-firmware,
alsa-devel, linux-kernel
Cc: Liam Girdwood, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Daniel Baluta, Jaroslav Kysela, Takashi Iwai
On 7/3/22 09:35, Andy Shevchenko wrote:
> device_get_match_data() in ACPI case calls similar to acpi_match_device().
> Hence there is no need to duplicate the call. Just assign what is in
> the id->driver_data.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/soc/sof/intel/bdw.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
> index 26df780c702e..346813aa3768 100644
> --- a/sound/soc/sof/intel/bdw.c
> +++ b/sound/soc/sof/intel/bdw.c
> @@ -674,6 +674,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> id = acpi_match_device(dev->driver->acpi_match_table, dev);
> if (!id)
> return -ENODEV;
> + desc = (const struct sof_dev_desc *)id->driver_data;
>
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {
> @@ -681,11 +682,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - desc = device_get_match_data(dev);
> - if (!desc)
> - return -ENODEV;
> -
> - return sof_acpi_probe(pdev, device_get_match_data(dev));
> + return sof_acpi_probe(pdev, desc);
Thanks Andy, we have the same code pattern in sound/soc/sof/intel/byt.c,
can we change it as part of the series to keep the two files aligned?
> }
>
> /* acpi_driver definition */
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-05 14:42 ` Pierre-Louis Bossart
0 siblings, 0 replies; 14+ messages in thread
From: Pierre-Louis Bossart @ 2022-07-05 14:42 UTC (permalink / raw)
To: Andy Shevchenko, Mark Brown, Peter Ujfalusi, sound-open-firmware,
alsa-devel, linux-kernel
Cc: Kai Vehmanen, Bard Liao, Takashi Iwai, Liam Girdwood,
Ranjani Sridharan, Daniel Baluta
On 7/3/22 09:35, Andy Shevchenko wrote:
> device_get_match_data() in ACPI case calls similar to acpi_match_device().
> Hence there is no need to duplicate the call. Just assign what is in
> the id->driver_data.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/soc/sof/intel/bdw.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
> index 26df780c702e..346813aa3768 100644
> --- a/sound/soc/sof/intel/bdw.c
> +++ b/sound/soc/sof/intel/bdw.c
> @@ -674,6 +674,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> id = acpi_match_device(dev->driver->acpi_match_table, dev);
> if (!id)
> return -ENODEV;
> + desc = (const struct sof_dev_desc *)id->driver_data;
>
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {
> @@ -681,11 +682,7 @@ static int sof_broadwell_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - desc = device_get_match_data(dev);
> - if (!desc)
> - return -ENODEV;
> -
> - return sof_acpi_probe(pdev, device_get_match_data(dev));
> + return sof_acpi_probe(pdev, desc);
Thanks Andy, we have the same code pattern in sound/soc/sof/intel/byt.c,
can we change it as part of the series to keep the two files aligned?
> }
>
> /* acpi_driver definition */
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
2022-07-05 12:09 ` Péter Ujfalusi
@ 2022-07-05 15:25 ` Andy Shevchenko
-1 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-05 15:25 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: Andy Shevchenko, Mark Brown, Pierre-Louis Bossart,
sound-open-firmware, ALSA Development Mailing List,
Linux Kernel Mailing List, Liam Girdwood, Bard Liao,
Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela,
Takashi Iwai
On Tue, Jul 5, 2022 at 3:19 PM Péter Ujfalusi
<peter.ujfalusi@linux.intel.com> wrote:
> On 04/07/2022 19:19, Andy Shevchenko wrote:
> > On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
> >> On 03/07/2022 17:35, Andy Shevchenko wrote:
...
> >> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
> >> }
> >
> >> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
> >
> > I prefer not to cast inside the function parameters when it's not about POD.
>
> Fair enough.
>
> How about assigning desc before it is used?
As answered in the other email, I'm fine to modify the change accordingly.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-05 15:25 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-05 15:25 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: ALSA Development Mailing List, Kai Vehmanen, Liam Girdwood,
Daniel Baluta, Takashi Iwai, Linux Kernel Mailing List,
Pierre-Louis Bossart, Mark Brown, Ranjani Sridharan,
Andy Shevchenko, Bard Liao, sound-open-firmware
On Tue, Jul 5, 2022 at 3:19 PM Péter Ujfalusi
<peter.ujfalusi@linux.intel.com> wrote:
> On 04/07/2022 19:19, Andy Shevchenko wrote:
> > On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
> >> On 03/07/2022 17:35, Andy Shevchenko wrote:
...
> >> + return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
> >> }
> >
> >> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
> >
> > I prefer not to cast inside the function parameters when it's not about POD.
>
> Fair enough.
>
> How about assigning desc before it is used?
As answered in the other email, I'm fine to modify the change accordingly.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
2022-07-05 14:42 ` Pierre-Louis Bossart
@ 2022-07-05 15:26 ` Andy Shevchenko
-1 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-05 15:26 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Andy Shevchenko, Mark Brown, Peter Ujfalusi, sound-open-firmware,
ALSA Development Mailing List, Linux Kernel Mailing List,
Liam Girdwood, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Daniel Baluta, Jaroslav Kysela, Takashi Iwai
On Tue, Jul 5, 2022 at 5:02 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
> On 7/3/22 09:35, Andy Shevchenko wrote:
...
> Thanks Andy, we have the same code pattern in sound/soc/sof/intel/byt.c,
> can we change it as part of the series to keep the two files aligned?
Sure. I was looking for the ID of WPT SPI (I2S) controller and that's
how I found these two.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval
@ 2022-07-05 15:26 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2022-07-05 15:26 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Daniel Baluta, ALSA Development Mailing List, Kai Vehmanen,
Bard Liao, Takashi Iwai, Linux Kernel Mailing List,
Liam Girdwood, Mark Brown, Ranjani Sridharan, Andy Shevchenko,
Peter Ujfalusi, sound-open-firmware
On Tue, Jul 5, 2022 at 5:02 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
> On 7/3/22 09:35, Andy Shevchenko wrote:
...
> Thanks Andy, we have the same code pattern in sound/soc/sof/intel/byt.c,
> can we change it as part of the series to keep the two files aligned?
Sure. I was looking for the ID of WPT SPI (I2S) controller and that's
how I found these two.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-07-05 15:28 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-03 14:35 [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval Andy Shevchenko
2022-07-03 14:35 ` Andy Shevchenko
2022-07-04 7:31 ` Péter Ujfalusi
2022-07-04 7:31 ` Péter Ujfalusi
2022-07-04 16:19 ` Andy Shevchenko
2022-07-04 16:19 ` Andy Shevchenko
2022-07-05 12:09 ` Péter Ujfalusi
2022-07-05 12:09 ` Péter Ujfalusi
2022-07-05 15:25 ` Andy Shevchenko
2022-07-05 15:25 ` Andy Shevchenko
2022-07-05 14:42 ` Pierre-Louis Bossart
2022-07-05 14:42 ` Pierre-Louis Bossart
2022-07-05 15:26 ` Andy Shevchenko
2022-07-05 15:26 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.