All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
@ 2021-05-28 19:17 Fabrice Fontaine
  2021-05-29  9:09 ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2021-05-28 19:17 UTC (permalink / raw)
  To: buildroot

pipewire unconditionally enables b_pie since version 0.3.20 and
https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/abe73c9146cd223b40b22581b1fd58bc044c671e
which will raise the following build failure on m68k since commit
a6d88d3ba5e30e11f4d726f341bc56c1be7c71c9:

/srv/storage/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/9.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld: /srv/storage/autobuild/run/instance-1/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o: in function `lib_main':
(.text+0x4): undefined reference to `__shared_flat_add_library'

Fixes:
 - http://autobuild.buildroot.org/results/c258a2736661af8ea73abeda2503d8682e65f1e2

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pkg-meson.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
index a57820d4d2..a55063d58e 100644
--- a/package/pkg-meson.mk
+++ b/package/pkg-meson.mk
@@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
 		--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
 		--buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
 		--cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
+		-Db_pie=$(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \
 		-Dstrip=false \
 		-Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \
 		$$($$(PKG)_CONF_OPTS) \
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
  2021-05-28 19:17 [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie Fabrice Fontaine
@ 2021-05-29  9:09 ` Yann E. MORIN
  2021-05-29  9:21   ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2021-05-29  9:09 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

+Peter, +James

On 2021-05-28 21:17 +0200, Fabrice Fontaine spake thusly:
> pipewire unconditionally enables b_pie since version 0.3.20 and
> https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/abe73c9146cd223b40b22581b1fd58bc044c671e
> which will raise the following build failure on m68k since commit
> a6d88d3ba5e30e11f4d726f341bc56c1be7c71c9:
> 
> /srv/storage/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/9.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld: /srv/storage/autobuild/run/instance-1/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o: in function `lib_main':
> (.text+0x4): undefined reference to `__shared_flat_add_library'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/c258a2736661af8ea73abeda2503d8682e65f1e2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/pkg-meson.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> index a57820d4d2..a55063d58e 100644
> --- a/package/pkg-meson.mk
> +++ b/package/pkg-meson.mk
> @@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
>  		--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
>  		--buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
>  		--cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
> +		-Db_pie=$(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \

I was wondering if we should not also put that in the cross-compilation
file as well, or even only in the cross-compilation file.

I see, below, that strip is on the command line, and not in the
cross-compilation file. However, the meson documentation [0] states that
the precendence of options is:

  - command line
  - machine file
  - build-system definition

So, b providing the default in the cross-compilation file, we also
ensure it is available in the file (and the template) we install in
$(HOST_DIR)/etc/meson/cross-compilation.conf and in
$(HOST_DIR)/etc/meson/cross-compilation.conf.in, so that builds outside
of Buildroot (e.g. SDK) by default use the same values as the builds in
Buildroot, but that users can still override that on the command line.

Thoughts?

In the meantime, I think it is still correct to have b_pie on the
command line for our infra, like we have strip, so: applied to master,
thanks.

[0] https://mesonbuild.com/Machine-files.html#meson-builtin-options

>  		-Dstrip=false \

And strip should probably also go in the cross-compilation file, too,
nmaybe?

Or is there a rule that says "this type of option should go in the cross
file, anything else should go on the cokmmand line" ?

Regards,
Yann E. MORIN.

>  		-Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \
>  		$$($$(PKG)_CONF_OPTS) \
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
  2021-05-29  9:09 ` Yann E. MORIN
@ 2021-05-29  9:21   ` Yann E. MORIN
  2021-05-29  9:41     ` Fabrice Fontaine
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2021-05-29  9:21 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2021-05-29 11:09 +0200, Yann E. MORIN spake thusly:
> On 2021-05-28 21:17 +0200, Fabrice Fontaine spake thusly:
> > pipewire unconditionally enables b_pie since version 0.3.20 and
> > https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/abe73c9146cd223b40b22581b1fd58bc044c671e
> > which will raise the following build failure on m68k since commit
> > a6d88d3ba5e30e11f4d726f341bc56c1be7c71c9:
> > 
> > /srv/storage/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/9.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld: /srv/storage/autobuild/run/instance-1/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o: in function `lib_main':
> > (.text+0x4): undefined reference to `__shared_flat_add_library'
> > 
> > Fixes:
> >  - http://autobuild.buildroot.org/results/c258a2736661af8ea73abeda2503d8682e65f1e2
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/pkg-meson.mk | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> > index a57820d4d2..a55063d58e 100644
> > --- a/package/pkg-meson.mk
> > +++ b/package/pkg-meson.mk
> > @@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
> >  		--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
> >  		--buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
> >  		--cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
> > +		-Db_pie=$(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \
[--SNIP--]
> In the meantime, I think it is still correct to have b_pie on the
> command line for our infra, like we have strip, so: applied to master,
> thanks.

Given a later patch that arrived in parallel, it turns out this patch
was not correct, and that we still have a bit of interrogation on that,
so I've reverted it, sorry. I'll keep an eye on the discussions...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
  2021-05-29  9:21   ` Yann E. MORIN
@ 2021-05-29  9:41     ` Fabrice Fontaine
  2021-05-29 19:30       ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2021-05-29  9:41 UTC (permalink / raw)
  To: buildroot

Dear all,

Le sam. 29 mai 2021 ? 11:21, Yann E. MORIN <yann.morin.1998@free.fr> a ?crit :
>
> Fabrice, All,
>
> On 2021-05-29 11:09 +0200, Yann E. MORIN spake thusly:
> > On 2021-05-28 21:17 +0200, Fabrice Fontaine spake thusly:
> > > pipewire unconditionally enables b_pie since version 0.3.20 and
> > > https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/abe73c9146cd223b40b22581b1fd58bc044c671e
> > > which will raise the following build failure on m68k since commit
> > > a6d88d3ba5e30e11f4d726f341bc56c1be7c71c9:
> > >
> > > /srv/storage/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/m68k-buildroot-linux-uclibc/9.3.0/../../../../m68k-buildroot-linux-uclibc/bin/ld: /srv/storage/autobuild/run/instance-1/output-1/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/Scrt1.o: in function `lib_main':
> > > (.text+0x4): undefined reference to `__shared_flat_add_library'
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.org/results/c258a2736661af8ea73abeda2503d8682e65f1e2
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > ---
> > >  package/pkg-meson.mk | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> > > index a57820d4d2..a55063d58e 100644
> > > --- a/package/pkg-meson.mk
> > > +++ b/package/pkg-meson.mk
> > > @@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
> > >             --default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
> > >             --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
> > >             --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
> > > +           -Db_pie=$(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \
> [--SNIP--]
> > In the meantime, I think it is still correct to have b_pie on the
> > command line for our infra, like we have strip, so: applied to master,
> > thanks.
>
> Given a later patch that arrived in parallel, it turns out this patch
> was not correct, and that we still have a bit of interrogation on that,
> so I've reverted it, sorry. I'll keep an eye on the discussions...
I think that the second version of this patch (i.e. always disabling
b_pie through command line) is the best option because:
- PIE is already enabled by the toolchain-wrapper:
hardening-check
output/build/pipewire-0.3.26/build/spa/plugins/audioconvert/benchmark-resample
output/build/pipewire-0.3.26/build/spa/plugins/audioconvert/benchmark-resample:
 Position Independent Executable: yes
- Enabling PIE in two different places is not future-proof and is not
done in any other infrastructures (autotools, cmake, etc.). I think
this is also the reason why strip is unconditionally disabled in the
command line (it is already handled in Makefile.in)
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
  2021-05-29  9:41     ` Fabrice Fontaine
@ 2021-05-29 19:30       ` Yann E. MORIN
  2021-06-01 19:31         ` Arnout Vandecappelle
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2021-05-29 19:30 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

Meson experts, questions for you below!

On 2021-05-29 11:41 +0200, Fabrice Fontaine spake thusly:
> Le sam. 29 mai 2021 ? 11:21, Yann E. MORIN <yann.morin.1998@free.fr> a
> ?crit :
> > On 2021-05-29 11:09 +0200, Yann E. MORIN spake thusly:
> > > On 2021-05-28 21:17 +0200, Fabrice Fontaine spake thusly:
[--SNIP--]
> > > > diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> > > > index a57820d4d2..a55063d58e 100644
> > > > --- a/package/pkg-meson.mk
> > > > +++ b/package/pkg-meson.mk
> > > > @@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
> > > >             --default-library=$(if
> > > >             $(BR2_STATIC_LIBS),static,shared) \
> > > >             --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release)
> > > >             \
> > > >             --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf
> > > >             \
> > > > +           -Db_pie=$(if
> > > > $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \
> > Given a later patch that arrived in parallel, it turns out this
> > patch
> > was not correct, and that we still have a bit of interrogation on
> > that,
> > so I've reverted it, sorry. I'll keep an eye on the discussions...
> I think that the second version of this patch (i.e. always disabling
> b_pie through command line) is the best option because:
> - PIE is already enabled by the toolchain-wrapper:
> hardening-check
> output/build/pipewire-0.3.26/build/spa/plugins/audioconvert/benchmark-resample
> output/build/pipewire-0.3.26/build/spa/plugins/audioconvert/benchmark-resample:
>  Position Independent Executable: yes

OK, so PIE is indeed applied when building, good.

> - Enabling PIE in two different places is not future-proof and is not
> done in any other infrastructures (autotools, cmake, etc.).

Yeah, that makes perfect sense.

> I think
> this is also the reason why strip is unconditionally disabled in the
> command line (it is already handled in Makefile.in)

Yeah, I know about strip. However, my question for the meson experts in
the room, is: should we leave that (strip, b_pie) on the command line,
or should we have them in the cross-compilation file?

Additionaly, the machine-files documentation [0] lists pkg_config_path
as being part of the builtin options, so shouldn't we also push that
into the cross-compilation file?

As of today, we have two places where we push meson options: the command
line, and the cross-compilation file. To further Fanrice's argument:
having two places where we push options is not very consistent and
future-proof.

Basically, that would give a patch like (@HOST_DIR@ is already replaced):

    diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
    index 37b49eea3b..942f68f008 100644
    --- a/package/meson/cross-compilation.conf.in
    +++ b/package/meson/cross-compilation.conf.in
    @@ -13,6 +13,9 @@ g-ir-compiler = '@STAGING_DIR@/usr/bin/g-ir-compiler'
     g-ir-scanner = '@STAGING_DIR@/usr/bin/g-ir-scanner'
     
     [built-in options]
    +b_pie = false
    +strip = false
    +build.pkg_config_path = '@HOST_DIR@/lib/pkgconfig'
     c_args = [@TARGET_CFLAGS@]
     c_link_args = [@TARGET_LDFLAGS@]
     cpp_args = [@TARGET_CXXFLAGS@]
    diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
    index 1857450564..87cf0e3dd7 100644
    --- a/package/pkg-meson.mk
    +++ b/package/pkg-meson.mk
    @@ -91,9 +91,6 @@ define $(2)_CONFIGURE_CMDS
     		--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
     		--buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
     		--cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
    -		-Db_pie=false \
    -		-Dstrip=false \
    -		-Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \
     		$$($$(PKG)_CONF_OPTS) \
     		$$($$(PKG)_SRCDIR) $$($$(PKG)_SRCDIR)/build
     endef

As far as I can tell from the documentation, this really seems like this
should be what we want to do in Buildroot, because that way, these
settings will also be used for the SDK, or for building manually outside
of Buildroot...

So, what's your thoughts about that?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie
  2021-05-29 19:30       ` Yann E. MORIN
@ 2021-06-01 19:31         ` Arnout Vandecappelle
  0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2021-06-01 19:31 UTC (permalink / raw)
  To: buildroot



On 29/05/2021 21:30, Yann E. MORIN wrote:
> Fabrice, All,
> 
> Meson experts, questions for you below!
> 
> On 2021-05-29 11:41 +0200, Fabrice Fontaine spake thusly:
>> Le sam. 29 mai 2021 ? 11:21, Yann E. MORIN <yann.morin.1998@free.fr> a
>> ?crit :
>>> On 2021-05-29 11:09 +0200, Yann E. MORIN spake thusly:
>>>> On 2021-05-28 21:17 +0200, Fabrice Fontaine spake thusly:
> [--SNIP--]
>>>>> diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
>>>>> index a57820d4d2..a55063d58e 100644
>>>>> --- a/package/pkg-meson.mk
>>>>> +++ b/package/pkg-meson.mk
>>>>> @@ -91,6 +91,7 @@ define $(2)_CONFIGURE_CMDS
>>>>>             --default-library=$(if
>>>>>             $(BR2_STATIC_LIBS),static,shared) \
>>>>>             --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release)
>>>>>             \
>>>>>             --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf
>>>>>             \
>>>>> +           -Db_pie=$(if
>>>>> $(BR2_TOOLCHAIN_SUPPORTS_PIE),true,false) \
>>> Given a later patch that arrived in parallel, it turns out this
>>> patch
>>> was not correct, and that we still have a bit of interrogation on
>>> that,
>>> so I've reverted it, sorry. I'll keep an eye on the discussions...
>> I think that the second version of this patch (i.e. always disabling
>> b_pie through command line) is the best option because:
>> - PIE is already enabled by the toolchain-wrapper:
>> hardening-check
>> output/build/pipewire-0.3.26/build/spa/plugins/audioconvert/benchmark-resample
>> output/build/pipewire-0.3.26/build/spa/plugins/audioconvert/benchmark-resample:
>>  Position Independent Executable: yes
> 
> OK, so PIE is indeed applied when building, good.
> 
>> - Enabling PIE in two different places is not future-proof and is not
>> done in any other infrastructures (autotools, cmake, etc.).
> 
> Yeah, that makes perfect sense.
> 
>> I think
>> this is also the reason why strip is unconditionally disabled in the
>> command line (it is already handled in Makefile.in)
> 
> Yeah, I know about strip. However, my question for the meson experts in
> the room, is: should we leave that (strip, b_pie) on the command line,
> or should we have them in the cross-compilation file?

 Well, currently we pass them in the toolchain wrapper.

 If we would put -fPIE in the cflags in the cross-compilation file, we'd hit
this message:

        if '-f' + arg.lower() in all_flags or '-f' + arg.upper() in all_flags:
            mlog.warning("Use the '{}' kwarg instead of passing '{}' manually to
{!r}".format(arg, '-f' + arg, self.name))
            return True

 But now, meson doesn't notice because we hide it in the wrapper.

 Anyway, the only effect of b_pie (or various other ways of passing the same
option) is that it adds -fPIE to the compilation flags. So I don't think it's
useful to set b_pie.


> Additionaly, the machine-files documentation [0] lists pkg_config_path
> as being part of the builtin options, so shouldn't we also push that
> into the cross-compilation file?

 Yes, that's just accidental. It was passed as a command-line option in the
weston package, and later refactored in the core package-meson in commit
5cff3a8bdfba92e9f61d0984df08f1ecd205c072 - but still keeping it as a
command-line option.


> As of today, we have two places where we push meson options: the command
> line, and the cross-compilation file. To further Fanrice's argument:
> having two places where we push options is not very consistent and
> future-proof.
> 
> Basically, that would give a patch like (@HOST_DIR@ is already replaced):
> 
>     diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
>     index 37b49eea3b..942f68f008 100644
>     --- a/package/meson/cross-compilation.conf.in
>     +++ b/package/meson/cross-compilation.conf.in
>     @@ -13,6 +13,9 @@ g-ir-compiler = '@STAGING_DIR@/usr/bin/g-ir-compiler'
>      g-ir-scanner = '@STAGING_DIR@/usr/bin/g-ir-scanner'
>      
>      [built-in options]
>     +b_pie = false
>     +strip = false
>     +build.pkg_config_path = '@HOST_DIR@/lib/pkgconfig'
>      c_args = [@TARGET_CFLAGS@]
>      c_link_args = [@TARGET_LDFLAGS@]
>      cpp_args = [@TARGET_CXXFLAGS@]
>     diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
>     index 1857450564..87cf0e3dd7 100644
>     --- a/package/pkg-meson.mk
>     +++ b/package/pkg-meson.mk
>     @@ -91,9 +91,6 @@ define $(2)_CONFIGURE_CMDS
>      		--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
>      		--buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
>      		--cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
>     -		-Db_pie=false \
>     -		-Dstrip=false \
>     -		-Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \
>      		$$($$(PKG)_CONF_OPTS) \
>      		$$($$(PKG)_SRCDIR) $$($$(PKG)_SRCDIR)/build
>      endef

 LGTM.


 Regards,
 Arnout

> As far as I can tell from the documentation, this really seems like this
> should be what we want to do in Buildroot, because that way, these
> settings will also be used for the SDK, or for building manually outside
> of Buildroot...
> 
> So, what's your thoughts about that?
> 
> Regards,
> Yann E. MORIN.
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-01 19:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 19:17 [Buildroot] [PATCH 1/1] package/pkg-meson: handle b_pie Fabrice Fontaine
2021-05-29  9:09 ` Yann E. MORIN
2021-05-29  9:21   ` Yann E. MORIN
2021-05-29  9:41     ` Fabrice Fontaine
2021-05-29 19:30       ` Yann E. MORIN
2021-06-01 19:31         ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.