All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message
@ 2021-11-29 12:25 Colin Ian King
  2021-11-29 12:34 ` Grumbach, Emmanuel
  0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2021-11-29 12:25 UTC (permalink / raw)
  To: Luca Coelho, Kalle Valo, David S . Miller, Jakub Kicinski,
	Emmanuel Grumbach, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

There is a spelling mistake in a dev_err message and also in a devfs
filename. Fix these.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/wireless/intel/iwlwifi/mei/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
index 112cc362e8e7..ed208f273289 100644
--- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
+++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
@@ -209,7 +209,7 @@ static void iwl_mei_free_shared_mem(struct mei_cl_device *cldev)
 	struct iwl_mei *mei = mei_cldev_get_drvdata(cldev);
 
 	if (mei_cldev_dma_unmap(cldev))
-		dev_err(&cldev->dev, "Coudln't unmap the shared mem properly\n");
+		dev_err(&cldev->dev, "Couldn't unmap the shared mem properly\n");
 	memset(&mei->shared_mem, 0, sizeof(mei->shared_mem));
 }
 
@@ -1754,7 +1754,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
 			     mei->dbgfs_dir, &iwl_mei_status);
 	debugfs_create_file("send_start_message", S_IWUSR, mei->dbgfs_dir,
 			    mei, &iwl_mei_dbgfs_send_start_message_ops);
-	debugfs_create_file("req_ownserhip", S_IWUSR, mei->dbgfs_dir,
+	debugfs_create_file("req_ownership", S_IWUSR, mei->dbgfs_dir,
 			    mei, &iwl_mei_dbgfs_req_ownership_ops);
 }
 
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message
  2021-11-29 12:25 [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message Colin Ian King
@ 2021-11-29 12:34 ` Grumbach, Emmanuel
  2021-11-29 12:45   ` Colin King (gmail)
  0 siblings, 1 reply; 3+ messages in thread
From: Grumbach, Emmanuel @ 2021-11-29 12:34 UTC (permalink / raw)
  To: Colin Ian King, Coelho, Luciano, Kalle Valo, David S . Miller,
	Jakub Kicinski, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

Hi Colin,

> Subject: [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and
> error message
> 
> There is a spelling mistake in a dev_err message and also in a devfs
> filename. Fix these.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mei/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 112cc362e8e7..ed208f273289 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -209,7 +209,7 @@ static void iwl_mei_free_shared_mem(struct
> mei_cl_device *cldev)
>  	struct iwl_mei *mei = mei_cldev_get_drvdata(cldev);
> 
>  	if (mei_cldev_dma_unmap(cldev))
> -		dev_err(&cldev->dev, "Coudln't unmap the shared mem
> properly\n");
> +		dev_err(&cldev->dev, "Couldn't unmap the shared mem
> properly\n");
>  	memset(&mei->shared_mem, 0, sizeof(mei->shared_mem));
>  }

I fixed this one already in a separate patch that hasn't been applied yet.

> 
> @@ -1754,7 +1754,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei
> *mei)
>  			     mei->dbgfs_dir, &iwl_mei_status);
>  	debugfs_create_file("send_start_message", S_IWUSR, mei-
> >dbgfs_dir,
>  			    mei, &iwl_mei_dbgfs_send_start_message_ops);
> -	debugfs_create_file("req_ownserhip", S_IWUSR, mei->dbgfs_dir,
> +	debugfs_create_file("req_ownership", S_IWUSR, mei->dbgfs_dir,
>  			    mei, &iwl_mei_dbgfs_req_ownership_ops);
>  }
> 
> --

I hadn't stop this one.

> 2.33.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message
  2021-11-29 12:34 ` Grumbach, Emmanuel
@ 2021-11-29 12:45   ` Colin King (gmail)
  0 siblings, 0 replies; 3+ messages in thread
From: Colin King (gmail) @ 2021-11-29 12:45 UTC (permalink / raw)
  To: Grumbach, Emmanuel, Colin Ian King, Coelho, Luciano, Kalle Valo,
	David S . Miller, Jakub Kicinski, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

On 29/11/2021 12:34, Grumbach, Emmanuel wrote:
> Hi Colin,
> 
>> Subject: [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and
>> error message
>>
>> There is a spelling mistake in a dev_err message and also in a devfs
>> filename. Fix these.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>>   drivers/net/wireless/intel/iwlwifi/mei/main.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> b/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> index 112cc362e8e7..ed208f273289 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
>> @@ -209,7 +209,7 @@ static void iwl_mei_free_shared_mem(struct
>> mei_cl_device *cldev)
>>   	struct iwl_mei *mei = mei_cldev_get_drvdata(cldev);
>>
>>   	if (mei_cldev_dma_unmap(cldev))
>> -		dev_err(&cldev->dev, "Coudln't unmap the shared mem
>> properly\n");
>> +		dev_err(&cldev->dev, "Couldn't unmap the shared mem
>> properly\n");
>>   	memset(&mei->shared_mem, 0, sizeof(mei->shared_mem));
>>   }
> 
> I fixed this one already in a separate patch that hasn't been applied yet.
> 
>>
>> @@ -1754,7 +1754,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei
>> *mei)
>>   			     mei->dbgfs_dir, &iwl_mei_status);
>>   	debugfs_create_file("send_start_message", S_IWUSR, mei-
>>> dbgfs_dir,
>>   			    mei, &iwl_mei_dbgfs_send_start_message_ops);
>> -	debugfs_create_file("req_ownserhip", S_IWUSR, mei->dbgfs_dir,
>> +	debugfs_create_file("req_ownership", S_IWUSR, mei->dbgfs_dir,
>>   			    mei, &iwl_mei_dbgfs_req_ownership_ops);
>>   }
>>
>> --
> 
> I hadn't stop this one.

I'll send a V2 with the debugfs fix

> 
>> 2.33.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-29 14:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 12:25 [PATCH][next] iwlwifi: mei: Fix spelling mistakes in a devfs file and error message Colin Ian King
2021-11-29 12:34 ` Grumbach, Emmanuel
2021-11-29 12:45   ` Colin King (gmail)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.