[PATCH] build: remove tboot make targets

[PATCH] build: remove tboot make targets

[Doug Goldstein]

The tboot targets are woefully out of date. These should really be
retired because setting up tboot is more complex than the build process
for it.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
Everyone knows my feeling about the Xen build system being a meta-distro
builder. This just removes something that never really belonged
integrated in the Xen build system. The best option would be
documentation instead of a make target to explain how to setup tboot
along with the necessary ACMs and the policy generation. But then again
tboot has its own docs covering that. The Linux kernel doesn't have a
make target for tboot so why should Xen? This is my rant while I tried
to keep the rant-y bits out of the commit message.

---
 Makefile | 44 --------------------------------------------
 README   |  5 -----
 2 files changed, 49 deletions(-)

diff --git a/Makefile b/Makefile
index 1d43044033..d959cd5b47 100644
--- a/Makefile
+++ b/Makefile
@@ -291,11 +291,6 @@ help:
 	@echo '  uninstall             - attempt to remove installed Xen tools'
 	@echo '                          (use with extreme care!)'
 	@echo
-	@echo 'Trusted Boot (tboot) targets:'
-	@echo '  build-tboot           - download and build the tboot module'
-	@echo '  install-tboot         - download, build, and install the tboot module'
-	@echo '  clean-tboot           - clean the tboot module if it exists'
-	@echo
 	@echo 'Package targets:'
 	@echo '  src-tarball-release   - make a source tarball with xen and qemu tagged with a release'
 	@echo '  src-tarball           - make a source tarball with xen and qemu tagged with git describe'
@@ -324,46 +319,7 @@ uninstall-docs:
 .PHONY: uninstall
 uninstall: D=$(DESTDIR)
 uninstall: uninstall-tools-public-headers $(TARGS_UNINSTALL)
-	rm -rf $(D)/boot/tboot*
 
 .PHONY: xenversion
 xenversion:
 	@$(MAKE) --no-print-directory -C xen xenversion
-
-#
-# tboot targets
-#
-
-TBOOT_TARFILE = tboot-20090330.tar.gz
-#TBOOT_BASE_URL = http://downloads.sourceforge.net/tboot
-TBOOT_BASE_URL = $(XEN_EXTFILES_URL)
-
-.PHONY: build-tboot
-build-tboot: download_tboot
-	$(MAKE) -C tboot build
-
-.PHONY: install-tboot
-install-tboot: download_tboot
-	$(MAKE) -C tboot install
-
-.PHONY: dist-tboot
-dist-tboot: download_tboot
-	$(MAKE) DESTDIR=$(DISTDIR)/install -C tboot dist
-
-.PHONY: clean-tboot
-clean-tboot:
-	[ ! -d tboot ] || $(MAKE) -C tboot clean
-
-.PHONY: distclean-tboot
-distclean-tboot:
-	[ ! -d tboot ] || $(MAKE) -C tboot distclean
-
-.PHONY: download_tboot
-download_tboot: tboot/Makefile
-
-tboot/Makefile: tboot/$(TBOOT_TARFILE)
-	[ -e tboot/Makefile ] || tar -xzf tboot/$(TBOOT_TARFILE) -C tboot/ --strip-components 1
-
-tboot/$(TBOOT_TARFILE):
-	mkdir -p tboot
-	wget -O tboot/$(TBOOT_TARFILE) $(TBOOT_BASE_URL)/$(TBOOT_TARFILE)
diff --git a/README b/README
index 4b95b21c7b..3a497fb064 100644
--- a/README
+++ b/README
@@ -199,8 +199,3 @@ http://sourceforge.net/projects/tboot.  This project hosts the code in a
 mercurial repo at http://tboot.sourceforge.net/hg/tboot.hg and contains
 tarballs of the source.  Instructions in the tboot README describe how
 to modify grub.conf to use tboot to launch Xen.
-
-There are optional targets as part of Xen's top-level makefile that will
-download and build tboot: install-tboot, build-tboot, dist-tboot, clean-tboot.
-These will download the latest tar file from the SourceForge site using wget,
-then build/install/dist according to Xen's settings.
-- 
2.16.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] build: remove tboot make targets

[Jan Beulich]

>>> On 19.08.18 at 04:22, <cardoe@cardoe.com> wrote:
> The tboot targets are woefully out of date. These should really be
> retired because setting up tboot is more complex than the build process
> for it.
> 
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

But I think you would better have Cc-ed the TXT/TBOOT maintainers
(now done), as it was presumably them having introduced these
targets. Even if the chance if high to not see any response, we
should at least give them a chance to chime in.

Jan

> ---
> Everyone knows my feeling about the Xen build system being a meta-distro
> builder. This just removes something that never really belonged
> integrated in the Xen build system. The best option would be
> documentation instead of a make target to explain how to setup tboot
> along with the necessary ACMs and the policy generation. But then again
> tboot has its own docs covering that. The Linux kernel doesn't have a
> make target for tboot so why should Xen? This is my rant while I tried
> to keep the rant-y bits out of the commit message.
> 
> ---
>  Makefile | 44 --------------------------------------------
>  README   |  5 -----
>  2 files changed, 49 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1d43044033..d959cd5b47 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -291,11 +291,6 @@ help:
>  	@echo '  uninstall             - attempt to remove installed Xen tools'
>  	@echo '                          (use with extreme care!)'
>  	@echo
> -	@echo 'Trusted Boot (tboot) targets:'
> -	@echo '  build-tboot           - download and build the tboot module'
> -	@echo '  install-tboot         - download, build, and install the tboot 
> module'
> -	@echo '  clean-tboot           - clean the tboot module if it exists'
> -	@echo
>  	@echo 'Package targets:'
>  	@echo '  src-tarball-release   - make a source tarball with xen and qemu 
> tagged with a release'
>  	@echo '  src-tarball           - make a source tarball with xen and qemu 
> tagged with git describe'
> @@ -324,46 +319,7 @@ uninstall-docs:
>  .PHONY: uninstall
>  uninstall: D=$(DESTDIR)
>  uninstall: uninstall-tools-public-headers $(TARGS_UNINSTALL)
> -	rm -rf $(D)/boot/tboot*
>  
>  .PHONY: xenversion
>  xenversion:
>  	@$(MAKE) --no-print-directory -C xen xenversion
> -
> -#
> -# tboot targets
> -#
> -
> -TBOOT_TARFILE = tboot-20090330.tar.gz
> -#TBOOT_BASE_URL = http://downloads.sourceforge.net/tboot 
> -TBOOT_BASE_URL = $(XEN_EXTFILES_URL)
> -
> -.PHONY: build-tboot
> -build-tboot: download_tboot
> -	$(MAKE) -C tboot build
> -
> -.PHONY: install-tboot
> -install-tboot: download_tboot
> -	$(MAKE) -C tboot install
> -
> -.PHONY: dist-tboot
> -dist-tboot: download_tboot
> -	$(MAKE) DESTDIR=$(DISTDIR)/install -C tboot dist
> -
> -.PHONY: clean-tboot
> -clean-tboot:
> -	[ ! -d tboot ] || $(MAKE) -C tboot clean
> -
> -.PHONY: distclean-tboot
> -distclean-tboot:
> -	[ ! -d tboot ] || $(MAKE) -C tboot distclean
> -
> -.PHONY: download_tboot
> -download_tboot: tboot/Makefile
> -
> -tboot/Makefile: tboot/$(TBOOT_TARFILE)
> -	[ -e tboot/Makefile ] || tar -xzf tboot/$(TBOOT_TARFILE) -C tboot/ 
> --strip-components 1
> -
> -tboot/$(TBOOT_TARFILE):
> -	mkdir -p tboot
> -	wget -O tboot/$(TBOOT_TARFILE) $(TBOOT_BASE_URL)/$(TBOOT_TARFILE)
> diff --git a/README b/README
> index 4b95b21c7b..3a497fb064 100644
> --- a/README
> +++ b/README
> @@ -199,8 +199,3 @@ http://sourceforge.net/projects/tboot.  This project 
> hosts the code in a
>  mercurial repo at http://tboot.sourceforge.net/hg/tboot.hg and contains
>  tarballs of the source.  Instructions in the tboot README describe how
>  to modify grub.conf to use tboot to launch Xen.
> -
> -There are optional targets as part of Xen's top-level makefile that will
> -download and build tboot: install-tboot, build-tboot, dist-tboot, clean-tboot.
> -These will download the latest tar file from the SourceForge site using 
> wget,
> -then build/install/dist according to Xen's settings.
> -- 
> 2.16.1




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] build: remove tboot make targets

[Doug Goldstein]

On Mon, Aug 20, 2018 at 02:33:10AM -0600, Jan Beulich wrote:
> >>> On 19.08.18 at 04:22, <cardoe@cardoe.com> wrote:
> > The tboot targets are woefully out of date. These should really be
> > retired because setting up tboot is more complex than the build process
> > for it.
> > 
> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> But I think you would better have Cc-ed the TXT/TBOOT maintainers
> (now done), as it was presumably them having introduced these
> targets. Even if the chance if high to not see any response, we
> should at least give them a chance to chime in.

Just a one week ping.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] build: remove tboot make targets

[Wei, Gang]

在 2018年8月28日，上午12:24，Doug Goldstein <cardoe@cardoe.com> 写道：
> 
> On Mon, Aug 20, 2018 at 02:33:10AM -0600, Jan Beulich wrote:
>>>>> On 19.08.18 at 04:22, <cardoe@cardoe.com> wrote:
>>> The tboot targets are woefully out of date. These should really be
>>> retired because setting up tboot is more complex than the build process
>>> for it.
>>> 
>>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> 
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> 
>> But I think you would better have Cc-ed the TXT/TBOOT maintainers
>> (now done), as it was presumably them having introduced these
>> targets. Even if the chance if high to not see any response, we
>> should at least give them a chance to chime in.
> 
> Just a one week ping.

Acked-by: Gang Wei <gang.wei@intel.com>

I agree that referring to the document to do the tboot deployment for Xen will be better.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] build: remove tboot make targets

[Jan Beulich]

>>> On 27.08.18 at 18:23, <cardoe@cardoe.com> wrote:
> On Mon, Aug 20, 2018 at 02:33:10AM -0600, Jan Beulich wrote:
>> >>> On 19.08.18 at 04:22, <cardoe@cardoe.com> wrote:
>> > The tboot targets are woefully out of date. These should really be
>> > retired because setting up tboot is more complex than the build process
>> > for it.
>> > 
>> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> 
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> 
>> But I think you would better have Cc-ed the TXT/TBOOT maintainers
>> (now done), as it was presumably them having introduced these
>> targets. Even if the chance if high to not see any response, we
>> should at least give them a chance to chime in.
> 
> Just a one week ping.

Slightly too late, don't you think, with it having gone in yesterday?
And why _to_ me anyway, when my ack is even visible above?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] build: remove tboot make targets

[Wei Liu]

On Sat, Aug 18, 2018 at 09:22:05PM -0500, Doug Goldstein wrote:
> The tboot targets are woefully out of date. These should really be
> retired because setting up tboot is more complex than the build process
> for it.
> 
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] build: remove tboot make targets

[Christopher Clark]

On Mon, Aug 20, 2018 at 1:38 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> On Sat, Aug 18, 2018 at 09:22:05PM -0500, Doug Goldstein wrote:
>> The tboot targets are woefully out of date. These should really be
>> retired because setting up tboot is more complex than the build process
>> for it.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Code reviewed and standard (non-tboot related) build tested with the
patch applied: looks good.

No references to any of the following remain in the tree afterwards:
* TBOOT_TARFILE
* TBOOT_BASE_URL
* build-tboot, install-tboot, dist-tboot, clean-tboot, distclean-tboot
* download_tboot

The README section about tboot, just above the chunk removed, contains
a stale URL for the tboot hg repository, which has apparently now
moved to:
http://hg.code.sf.net/p/tboot/code

I don't use uninstall (ever) but since Doug's patch touches it, I just
tested it with this applied. Uninstall failed, but it's not a fault of
this patch:

| make[6]: Entering directory './git/tools/tests/x86_emulator'
| make[6]: *** No rule to make target 'uninstall'.  Stop.
| make[6]: Leaving directory './git/tools/tests/x86_emulator'
|
| make[6]: *** No rule to make target 'uninstall'.  Stop.
| make[6]: Leaving directory '/./git/tools/tests/x86_emulator'
| ./git/tools/tests/../../tools/Rules.mk:249: recipe for target
'subdir-uninstall-x86_emulator' failed
| make[5]: *** [subdir-uninstall-x86_emulator] Error 2
| make[5]: Leaving directory './git/tools/tests'
|
| ./git/tools/tests/../../tools/Rules.mk:249: recipe for target
'subdir-uninstall-x86_emulator' failed

so I've just posted a patch that fixes this and another defect in the
Linux hotplug uninstall logic to make it actually remove what it
installed.

Reviewed-by: Christopher Clark <christopher.clark6@baesystems.com>

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel