All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] oeqa: Use cpio 2.13 as testcase
@ 2020-02-05  5:41 Khem Raj
  2020-02-05  5:41 ` [PATCH 2/2] oeqa: autoreconf cpio before building Khem Raj
  0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2020-02-05  5:41 UTC (permalink / raw)
  To: openembedded-core

cpio 2.12 was released in 2015 and might have used older autotools
which could result in errors like

https://bugzilla.yoctoproject.org/show_bug.cgi?id=13779

Bumping to 2.13 will help in matching the tool versions
A good change on top would be to run

aclocal -I .; autoheader; autoconf; automake --add-missing -c

before running configure step perhaps

[YOCTO #13779]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 4 ++--
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py b/meta/lib/oeqa/runtime/cases/buildcpio.py
index f4e871e421..4bd72dd37e 100644
--- a/meta/lib/oeqa/runtime/cases/buildcpio.py
+++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
@@ -12,7 +12,7 @@ class BuildCpioTest(OERuntimeTestCase):
 
     @classmethod
     def setUpClass(cls):
-        uri = 'https://downloads.yoctoproject.org/mirror/sources/cpio-2.12.tar.gz'
+        uri = 'https://downloads.yoctoproject.org/mirror/sources/cpio-2.13.tar.gz'
         cls.project = TargetBuildProject(cls.tc.target,
                                          uri,
                                          dl_dir = cls.tc.td['DL_DIR'])
diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py b/meta/lib/oeqa/sdk/cases/buildcpio.py
index 0a5e68d5fd..b0beafb38f 100644
--- a/meta/lib/oeqa/sdk/cases/buildcpio.py
+++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
@@ -17,10 +17,10 @@ class BuildCpioTest(OESDKTestCase):
     """
     def test_cpio(self):
         with tempfile.TemporaryDirectory(prefix="cpio-", dir=self.tc.sdk_dir) as testdir:
-            tarball = self.fetch(testdir, self.td["DL_DIR"], "https://ftp.gnu.org/gnu/cpio/cpio-2.12.tar.gz")
+            tarball = self.fetch(testdir, self.td["DL_DIR"], "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz")
 
             dirs = {}
-            dirs["source"] = os.path.join(testdir, "cpio-2.12")
+            dirs["source"] = os.path.join(testdir, "cpio-2.13")
             dirs["build"] = os.path.join(testdir, "build")
             dirs["install"] = os.path.join(testdir, "install")
 
diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py b/meta/lib/oeqa/selftest/cases/meta_ide.py
index 03901a2f32..809142559a 100644
--- a/meta/lib/oeqa/selftest/cases/meta_ide.py
+++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
@@ -40,7 +40,7 @@ class MetaIDE(OESelftestTestCase):
     def test_meta_ide_can_build_cpio_project(self):
         dl_dir = self.td.get('DL_DIR', None)
         self.project = SDKBuildProject(self.tmpdir_metaideQA + "/cpio/", self.environment_script_path,
-                        "https://ftp.gnu.org/gnu/cpio/cpio-2.12.tar.gz",
+                        "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
         self.assertEqual(self.project.run_configure(), 0,
-- 
2.25.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/2] oeqa: autoreconf cpio before building
  2020-02-05  5:41 [PATCH 1/2] oeqa: Use cpio 2.13 as testcase Khem Raj
@ 2020-02-05  5:41 ` Khem Raj
  2020-02-07 18:09   ` Richard Purdie
  0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2020-02-05  5:41 UTC (permalink / raw)
  To: openembedded-core

since the versions of autotools might differ in OE especially
so recreate config.h.in, aclocal.m4, configure, and Makefile.in

[YOCTO #13779]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
 meta/lib/oeqa/sdk/cases/buildcpio.py     | 1 +
 meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py b/meta/lib/oeqa/runtime/cases/buildcpio.py
index 4bd72dd37e..9cc261c314 100644
--- a/meta/lib/oeqa/runtime/cases/buildcpio.py
+++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
     @OEHasPackage(['autoconf'])
     def test_cpio(self):
         self.project.download_archive()
-        self.project.run_configure()
+        self.project.run_configure('','autoreconf --force;')
         self.project.run_make()
         self.project.run_install()
diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py b/meta/lib/oeqa/sdk/cases/buildcpio.py
index b0beafb38f..ec10149d34 100644
--- a/meta/lib/oeqa/sdk/cases/buildcpio.py
+++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
@@ -28,6 +28,7 @@ class BuildCpioTest(OESDKTestCase):
             self.assertTrue(os.path.isdir(dirs["source"]))
             os.makedirs(dirs["build"])
 
+            self._run("cd {source} && autoreconf --force")
             self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
             self._run("cd {build} && make -j".format(**dirs))
             self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py b/meta/lib/oeqa/selftest/cases/meta_ide.py
index 809142559a..46398c7e2d 100644
--- a/meta/lib/oeqa/selftest/cases/meta_ide.py
+++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
@@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
                         "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
                         self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
         self.project.download_archive()
-        self.assertEqual(self.project.run_configure(), 0,
+        self.assertEqual(self.project.run_configure('','autoreconf --force;'), 0,
                         msg="Running configure failed")
         self.assertEqual(self.project.run_make(), 0,
                         msg="Running make failed")
-- 
2.25.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] oeqa: autoreconf cpio before building
  2020-02-05  5:41 ` [PATCH 2/2] oeqa: autoreconf cpio before building Khem Raj
@ 2020-02-07 18:09   ` Richard Purdie
  2020-02-07 18:18     ` Andre McCurdy
  2020-02-07 18:26     ` Khem Raj
  0 siblings, 2 replies; 7+ messages in thread
From: Richard Purdie @ 2020-02-07 18:09 UTC (permalink / raw)
  To: Khem Raj, openembedded-core

On Tue, 2020-02-04 at 21:41 -0800, Khem Raj wrote:
> since the versions of autotools might differ in OE especially
> so recreate config.h.in, aclocal.m4, configure, and Makefile.in
> 
> [YOCTO #13779]
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
>  meta/lib/oeqa/sdk/cases/buildcpio.py     | 1 +
>  meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py
> b/meta/lib/oeqa/runtime/cases/buildcpio.py
> index 4bd72dd37e..9cc261c314 100644
> --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
>      @OEHasPackage(['autoconf'])
>      def test_cpio(self):
>          self.project.download_archive()
> -        self.project.run_configure()
> +        self.project.run_configure('','autoreconf --force;')
>          self.project.run_make()
>          self.project.run_install()
> diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py
> b/meta/lib/oeqa/sdk/cases/buildcpio.py
> index b0beafb38f..ec10149d34 100644
> --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> @@ -28,6 +28,7 @@ class BuildCpioTest(OESDKTestCase):
>              self.assertTrue(os.path.isdir(dirs["source"]))
>              os.makedirs(dirs["build"])
>  
> +            self._run("cd {source} && autoreconf --force")
>              self._run("cd {build} && {source}/configure
> $CONFIGURE_FLAGS".format(**dirs))
>              self._run("cd {build} && make -j".format(**dirs))
>              self._run("cd {build} && make install
> DESTDIR={install}".format(**dirs))
> diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py
> b/meta/lib/oeqa/selftest/cases/meta_ide.py
> index 809142559a..46398c7e2d 100644
> --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
>                          "
> https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
>                          self.tmpdir_metaideQA, self.td['DATETIME'],
> dl_dir=dl_dir)
>          self.project.download_archive()
> -        self.assertEqual(self.project.run_configure(), 0,
> +        self.assertEqual(self.project.run_configure('','autoreconf
> --force;'), 0,
>                          msg="Running configure failed")
>          self.assertEqual(self.project.run_make(), 0,
>                          msg="Running make failed")
> -- 
> 2.25.0

This breaks the SDK everywhere:

https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1552/steps/8/logs/step2c

(and many more)

Cheers,

Richard




^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] oeqa: autoreconf cpio before building
  2020-02-07 18:09   ` Richard Purdie
@ 2020-02-07 18:18     ` Andre McCurdy
  2020-02-07 18:28       ` Khem Raj
  2020-02-07 18:26     ` Khem Raj
  1 sibling, 1 reply; 7+ messages in thread
From: Andre McCurdy @ 2020-02-07 18:18 UTC (permalink / raw)
  To: Richard Purdie; +Cc: OE Core mailing list

On Fri, Feb 7, 2020 at 10:09 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2020-02-04 at 21:41 -0800, Khem Raj wrote:
> > since the versions of autotools might differ in OE especially
> > so recreate config.h.in, aclocal.m4, configure, and Makefile.in
> >
> > [YOCTO #13779]
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
> >  meta/lib/oeqa/sdk/cases/buildcpio.py     | 1 +
> >  meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
> >  3 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > index 4bd72dd37e..9cc261c314 100644
> > --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
> >      @OEHasPackage(['autoconf'])
> >      def test_cpio(self):
> >          self.project.download_archive()
> > -        self.project.run_configure()
> > +        self.project.run_configure('','autoreconf --force;')
> >          self.project.run_make()
> >          self.project.run_install()
> > diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > index b0beafb38f..ec10149d34 100644
> > --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > @@ -28,6 +28,7 @@ class BuildCpioTest(OESDKTestCase):
> >              self.assertTrue(os.path.isdir(dirs["source"]))
> >              os.makedirs(dirs["build"])
> >
> > +            self._run("cd {source} && autoreconf --force")
> >              self._run("cd {build} && {source}/configure
> > $CONFIGURE_FLAGS".format(**dirs))
> >              self._run("cd {build} && make -j".format(**dirs))
> >              self._run("cd {build} && make install
> > DESTDIR={install}".format(**dirs))
> > diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > index 809142559a..46398c7e2d 100644
> > --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
> >                          "
> > https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
> >                          self.tmpdir_metaideQA, self.td['DATETIME'],
> > dl_dir=dl_dir)
> >          self.project.download_archive()
> > -        self.assertEqual(self.project.run_configure(), 0,
> > +        self.assertEqual(self.project.run_configure('','autoreconf
> > --force;'), 0,
> >                          msg="Running configure failed")
> >          self.assertEqual(self.project.run_make(), 0,
> >                          msg="Running make failed")
> > --
> > 2.25.0
>
> This breaks the SDK everywhere:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1552/steps/8/logs/step2c
>
> (and many more)

Configuring with --disable-maintainer-mode might be a better fix for
the original problem?

  https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] oeqa: autoreconf cpio before building
  2020-02-07 18:09   ` Richard Purdie
  2020-02-07 18:18     ` Andre McCurdy
@ 2020-02-07 18:26     ` Khem Raj
  1 sibling, 0 replies; 7+ messages in thread
From: Khem Raj @ 2020-02-07 18:26 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer

On Fri, Feb 7, 2020 at 10:09 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2020-02-04 at 21:41 -0800, Khem Raj wrote:
> > since the versions of autotools might differ in OE especially
> > so recreate config.h.in, aclocal.m4, configure, and Makefile.in
> >
> > [YOCTO #13779]
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
> >  meta/lib/oeqa/sdk/cases/buildcpio.py     | 1 +
> >  meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
> >  3 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > index 4bd72dd37e..9cc261c314 100644
> > --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
> >      @OEHasPackage(['autoconf'])
> >      def test_cpio(self):
> >          self.project.download_archive()
> > -        self.project.run_configure()
> > +        self.project.run_configure('','autoreconf --force;')
> >          self.project.run_make()
> >          self.project.run_install()
> > diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > index b0beafb38f..ec10149d34 100644
> > --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > @@ -28,6 +28,7 @@ class BuildCpioTest(OESDKTestCase):
> >              self.assertTrue(os.path.isdir(dirs["source"]))
> >              os.makedirs(dirs["build"])
> >
> > +            self._run("cd {source} && autoreconf --force")
> >              self._run("cd {build} && {source}/configure
> > $CONFIGURE_FLAGS".format(**dirs))
> >              self._run("cd {build} && make -j".format(**dirs))
> >              self._run("cd {build} && make install
> > DESTDIR={install}".format(**dirs))
> > diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > index 809142559a..46398c7e2d 100644
> > --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
> >                          "
> > https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
> >                          self.tmpdir_metaideQA, self.td['DATETIME'],
> > dl_dir=dl_dir)
> >          self.project.download_archive()
> > -        self.assertEqual(self.project.run_configure(), 0,
> > +        self.assertEqual(self.project.run_configure('','autoreconf
> > --force;'), 0,
> >                          msg="Running configure failed")
> >          self.assertEqual(self.project.run_make(), 0,
> >                          msg="Running make failed")
> > --
> > 2.25.0
>
> This breaks the SDK everywhere:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1552/steps/8/logs/step2c
>
> (and many more)
>

yes obvious oversight, I have sent a v2, anyway this patch was not fixing
original problem too.

> Cheers,
>
> Richard
>
>


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] oeqa: autoreconf cpio before building
  2020-02-07 18:18     ` Andre McCurdy
@ 2020-02-07 18:28       ` Khem Raj
  2020-02-07 18:47         ` Andre McCurdy
  0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2020-02-07 18:28 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On Fri, Feb 7, 2020 at 10:18 AM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> On Fri, Feb 7, 2020 at 10:09 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Tue, 2020-02-04 at 21:41 -0800, Khem Raj wrote:
> > > since the versions of autotools might differ in OE especially
> > > so recreate config.h.in, aclocal.m4, configure, and Makefile.in
> > >
> > > [YOCTO #13779]
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > >  meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
> > >  meta/lib/oeqa/sdk/cases/buildcpio.py     | 1 +
> > >  meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
> > >  3 files changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > index 4bd72dd37e..9cc261c314 100644
> > > --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
> > >      @OEHasPackage(['autoconf'])
> > >      def test_cpio(self):
> > >          self.project.download_archive()
> > > -        self.project.run_configure()
> > > +        self.project.run_configure('','autoreconf --force;')
> > >          self.project.run_make()
> > >          self.project.run_install()
> > > diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > index b0beafb38f..ec10149d34 100644
> > > --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > @@ -28,6 +28,7 @@ class BuildCpioTest(OESDKTestCase):
> > >              self.assertTrue(os.path.isdir(dirs["source"]))
> > >              os.makedirs(dirs["build"])
> > >
> > > +            self._run("cd {source} && autoreconf --force")
> > >              self._run("cd {build} && {source}/configure
> > > $CONFIGURE_FLAGS".format(**dirs))
> > >              self._run("cd {build} && make -j".format(**dirs))
> > >              self._run("cd {build} && make install
> > > DESTDIR={install}".format(**dirs))
> > > diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > index 809142559a..46398c7e2d 100644
> > > --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
> > >                          "
> > > https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
> > >                          self.tmpdir_metaideQA, self.td['DATETIME'],
> > > dl_dir=dl_dir)
> > >          self.project.download_archive()
> > > -        self.assertEqual(self.project.run_configure(), 0,
> > > +        self.assertEqual(self.project.run_configure('','autoreconf
> > > --force;'), 0,
> > >                          msg="Running configure failed")
> > >          self.assertEqual(self.project.run_make(), 0,
> > >                          msg="Running make failed")
> > > --
> > > 2.25.0
> >
> > This breaks the SDK everywhere:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1552/steps/8/logs/step2c
> >
> > (and many more)
>
> Configuring with --disable-maintainer-mode might be a better fix for
> the original problem?
>

yes, or just touch configure, which I have sent as v2, but I am still
miffed with why its happening on mips64 box alone.

>   https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] oeqa: autoreconf cpio before building
  2020-02-07 18:28       ` Khem Raj
@ 2020-02-07 18:47         ` Andre McCurdy
  0 siblings, 0 replies; 7+ messages in thread
From: Andre McCurdy @ 2020-02-07 18:47 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Fri, Feb 7, 2020 at 10:28 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Fri, Feb 7, 2020 at 10:18 AM Andre McCurdy <armccurdy@gmail.com> wrote:
> >
> > On Fri, Feb 7, 2020 at 10:09 AM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > >
> > > On Tue, 2020-02-04 at 21:41 -0800, Khem Raj wrote:
> > > > since the versions of autotools might differ in OE especially
> > > > so recreate config.h.in, aclocal.m4, configure, and Makefile.in
> > > >
> > > > [YOCTO #13779]
> > > >
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > ---
> > > >  meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
> > > >  meta/lib/oeqa/sdk/cases/buildcpio.py     | 1 +
> > > >  meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
> > > >  3 files changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > > b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > > index 4bd72dd37e..9cc261c314 100644
> > > > --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > > +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> > > > @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
> > > >      @OEHasPackage(['autoconf'])
> > > >      def test_cpio(self):
> > > >          self.project.download_archive()
> > > > -        self.project.run_configure()
> > > > +        self.project.run_configure('','autoreconf --force;')
> > > >          self.project.run_make()
> > > >          self.project.run_install()
> > > > diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > > b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > > index b0beafb38f..ec10149d34 100644
> > > > --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > > +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> > > > @@ -28,6 +28,7 @@ class BuildCpioTest(OESDKTestCase):
> > > >              self.assertTrue(os.path.isdir(dirs["source"]))
> > > >              os.makedirs(dirs["build"])
> > > >
> > > > +            self._run("cd {source} && autoreconf --force")
> > > >              self._run("cd {build} && {source}/configure
> > > > $CONFIGURE_FLAGS".format(**dirs))
> > > >              self._run("cd {build} && make -j".format(**dirs))
> > > >              self._run("cd {build} && make install
> > > > DESTDIR={install}".format(**dirs))
> > > > diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > > b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > > index 809142559a..46398c7e2d 100644
> > > > --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > > +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> > > > @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
> > > >                          "
> > > > https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
> > > >                          self.tmpdir_metaideQA, self.td['DATETIME'],
> > > > dl_dir=dl_dir)
> > > >          self.project.download_archive()
> > > > -        self.assertEqual(self.project.run_configure(), 0,
> > > > +        self.assertEqual(self.project.run_configure('','autoreconf
> > > > --force;'), 0,
> > > >                          msg="Running configure failed")
> > > >          self.assertEqual(self.project.run_make(), 0,
> > > >                          msg="Running make failed")
> > > > --
> > > > 2.25.0
> > >
> > > This breaks the SDK everywhere:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1552/steps/8/logs/step2c
> > >
> > > (and many more)
> >
> > Configuring with --disable-maintainer-mode might be a better fix for
> > the original problem?
> >
>
> yes, or just touch configure, which I have sent as v2

If only it was that easy! :-)


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-07 18:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05  5:41 [PATCH 1/2] oeqa: Use cpio 2.13 as testcase Khem Raj
2020-02-05  5:41 ` [PATCH 2/2] oeqa: autoreconf cpio before building Khem Raj
2020-02-07 18:09   ` Richard Purdie
2020-02-07 18:18     ` Andre McCurdy
2020-02-07 18:28       ` Khem Raj
2020-02-07 18:47         ` Andre McCurdy
2020-02-07 18:26     ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.