All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Pavel Tatashin <pasha.tatashin@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mhocko@kernel.org, akpm@linux-foundation.org,
	terraluna977@gmail.com, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] mm: Reversed logic in memblock_discard
Date: Thu, 24 Aug 2017 14:21:07 +0200	[thread overview]
Message-ID: <398b8217-4d67-4a9d-26c3-872dbd575dce@suse.cz> (raw)
In-Reply-To: <1503511441-95478-2-git-send-email-pasha.tatashin@oracle.com>

+CC stable

On 08/23/2017 08:04 PM, Pavel Tatashin wrote:
> In recently introduced memblock_discard() there is a reversed logic bug.
> Memory is freed of static array instead of dynamically allocated one.
> 
> Fixes: 3010f876500f ("mm: discard memblock data later")

That patch was CC'd stable. So this one should be too. Looks like it the
original patch wasn't yet included in a stable release, so we can avoid
breakage.

> Reported-and-tested-by: Woody Suwalski <terraluna977@gmail.com>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
> ---
>  mm/memblock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index bf14aea6ab70..91205780e6b1 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -299,7 +299,7 @@ void __init memblock_discard(void)
>  		__memblock_free_late(addr, size);
>  	}
>  
> -	if (memblock.memory.regions == memblock_memory_init_regions) {
> +	if (memblock.memory.regions != memblock_memory_init_regions) {
>  		addr = __pa(memblock.memory.regions);
>  		size = PAGE_ALIGN(sizeof(struct memblock_region) *
>  				  memblock.memory.max);
> 

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Pavel Tatashin <pasha.tatashin@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mhocko@kernel.org, akpm@linux-foundation.org,
	terraluna977@gmail.com, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] mm: Reversed logic in memblock_discard
Date: Thu, 24 Aug 2017 14:21:07 +0200	[thread overview]
Message-ID: <398b8217-4d67-4a9d-26c3-872dbd575dce@suse.cz> (raw)
In-Reply-To: <1503511441-95478-2-git-send-email-pasha.tatashin@oracle.com>

+CC stable

On 08/23/2017 08:04 PM, Pavel Tatashin wrote:
> In recently introduced memblock_discard() there is a reversed logic bug.
> Memory is freed of static array instead of dynamically allocated one.
> 
> Fixes: 3010f876500f ("mm: discard memblock data later")

That patch was CC'd stable. So this one should be too. Looks like it the
original patch wasn't yet included in a stable release, so we can avoid
breakage.

> Reported-and-tested-by: Woody Suwalski <terraluna977@gmail.com>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
> ---
>  mm/memblock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index bf14aea6ab70..91205780e6b1 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -299,7 +299,7 @@ void __init memblock_discard(void)
>  		__memblock_free_late(addr, size);
>  	}
>  
> -	if (memblock.memory.regions == memblock_memory_init_regions) {
> +	if (memblock.memory.regions != memblock_memory_init_regions) {
>  		addr = __pa(memblock.memory.regions);
>  		size = PAGE_ALIGN(sizeof(struct memblock_region) *
>  				  memblock.memory.max);
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-08-24 12:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 18:04 [PATCH v1 0/1] Reversed logic in memblock_discard Pavel Tatashin
2017-08-23 18:04 ` Pavel Tatashin
2017-08-23 18:04 ` [PATCH v1 1/1] mm: " Pavel Tatashin
2017-08-23 18:04   ` Pavel Tatashin
2017-08-24 12:21   ` Vlastimil Babka [this message]
2017-08-24 12:21     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=398b8217-4d67-4a9d-26c3-872dbd575dce@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=pasha.tatashin@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=terraluna977@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.