From: Vijay Khemka <vijaykhemka@fb.com>
To: Rashmica Gupta <rashmica.g@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>
Cc: "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks
Date: Wed, 11 Sep 2019 17:48:28 +0000 [thread overview]
Message-ID: <39AE527D-F629-4AD7-980C-61C55C5B8718@fb.com> (raw)
In-Reply-To: <20190904061245.30770-1-rashmica.g@gmail.com>
On 9/11/19, 5:16 AM, "Linux-aspeed on behalf of Rashmica Gupta" <linux-aspeed-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of rashmica.g@gmail.com> wrote:
Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver')
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
---
drivers/gpio/gpio-aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 9defe25d4721..77752b2624e8 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1165,7 +1165,7 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
gpio->chip.base = -1;
/* Allocate a cache of the output registers */
- banks = gpio->config->nr_gpios >> 5;
+ banks = (gpio->config->nr_gpios >> 5) + 1;
If number of gpios are 32 then it should be only 1 bank, as per above it is 2 bank.
gpio->dcache = devm_kcalloc(&pdev->dev,
banks, sizeof(u32), GFP_KERNEL);
if (!gpio->dcache)
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Vijay Khemka <vijaykhemka@fb.com>
To: Rashmica Gupta <rashmica.g@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks
Date: Wed, 11 Sep 2019 17:48:28 +0000 [thread overview]
Message-ID: <39AE527D-F629-4AD7-980C-61C55C5B8718@fb.com> (raw)
In-Reply-To: <20190904061245.30770-1-rashmica.g@gmail.com>
On 9/11/19, 5:16 AM, "Linux-aspeed on behalf of Rashmica Gupta" <linux-aspeed-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of rashmica.g@gmail.com> wrote:
Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver')
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
---
drivers/gpio/gpio-aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 9defe25d4721..77752b2624e8 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1165,7 +1165,7 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
gpio->chip.base = -1;
/* Allocate a cache of the output registers */
- banks = gpio->config->nr_gpios >> 5;
+ banks = (gpio->config->nr_gpios >> 5) + 1;
If number of gpios are 32 then it should be only 1 bank, as per above it is 2 bank.
gpio->dcache = devm_kcalloc(&pdev->dev,
banks, sizeof(u32), GFP_KERNEL);
if (!gpio->dcache)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-11 17:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 6:12 [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks Rashmica Gupta
2019-09-04 6:12 ` Rashmica Gupta
2019-09-04 6:12 ` [PATCH 2/4] gpio/aspeed: Setup irqchip dynamically Rashmica Gupta
2019-09-04 6:12 ` Rashmica Gupta
2019-09-04 6:12 ` [PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver Rashmica Gupta
2019-09-04 6:12 ` Rashmica Gupta
2019-09-04 16:30 ` Andy Shevchenko
2019-09-04 16:30 ` Andy Shevchenko
2019-09-04 23:34 ` Rashmica Gupta
2019-09-04 23:34 ` Rashmica Gupta
2019-09-05 8:10 ` Andy Shevchenko
2019-09-05 8:10 ` Andy Shevchenko
2019-09-04 6:12 ` [PATCH 4/4] gpio: Update documentation with ast2600 controllers Rashmica Gupta
2019-09-04 6:12 ` Rashmica Gupta
2019-09-04 7:02 ` Bartosz Golaszewski
2019-09-04 7:02 ` Bartosz Golaszewski
2019-09-04 23:22 ` Rashmica Gupta
2019-09-04 23:22 ` Rashmica Gupta
2019-09-04 6:57 ` [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks Bartosz Golaszewski
2019-09-04 6:57 ` Bartosz Golaszewski
2019-09-04 16:27 ` Andy Shevchenko
2019-09-04 16:27 ` Andy Shevchenko
2019-09-04 23:17 ` Rashmica Gupta
2019-09-04 23:17 ` Rashmica Gupta
2019-09-05 8:08 ` Andy Shevchenko
2019-09-05 8:08 ` Andy Shevchenko
2019-09-11 17:48 ` Vijay Khemka [this message]
2019-09-11 17:48 ` Vijay Khemka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39AE527D-F629-4AD7-980C-61C55C5B8718@fb.com \
--to=vijaykhemka@fb.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashmica.g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.