All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools: make misra convert tool executable
@ 2022-08-03  7:35 Bertrand Marquis
  2022-08-03  7:55 ` Jan Beulich
  0 siblings, 1 reply; 3+ messages in thread
From: Bertrand Marquis @ 2022-08-03  7:35 UTC (permalink / raw)
  To: xen-devel
  Cc: Andrew Cooper, George Dunlap, Jan Beulich, Julien Grall,
	Stefano Stabellini, Wei Liu

Fix misra document conversion script to be executable.

Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
 xen/tools/convert_misra_doc.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 xen/tools/convert_misra_doc.py

diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py
old mode 100644
new mode 100755
-- 
2.25.1



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] tools: make misra convert tool executable
  2022-08-03  7:35 [PATCH] tools: make misra convert tool executable Bertrand Marquis
@ 2022-08-03  7:55 ` Jan Beulich
  2022-08-03  8:00   ` Bertrand Marquis
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2022-08-03  7:55 UTC (permalink / raw)
  To: Bertrand Marquis
  Cc: Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini,
	Wei Liu, xen-devel

On 03.08.2022 09:35, Bertrand Marquis wrote:
> Fix misra document conversion script to be executable.
> 
> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
>  xen/tools/convert_misra_doc.py | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 xen/tools/convert_misra_doc.py

Hmm, the real fix imo would be to add $(PYTHON), just like we use
$(SHELL) to invoke shell scripts. This is to cover for file systems
lacking a way to express executable permission. (Along with that I
certainly wouldn't mind the mode change, but that would then only
be for cosmetic reasons.)

Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] tools: make misra convert tool executable
  2022-08-03  7:55 ` Jan Beulich
@ 2022-08-03  8:00   ` Bertrand Marquis
  0 siblings, 0 replies; 3+ messages in thread
From: Bertrand Marquis @ 2022-08-03  8:00 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini,
	Wei Liu, xen-devel

Hi Jan,

> On 3 Aug 2022, at 08:55, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 03.08.2022 09:35, Bertrand Marquis wrote:
>> Fix misra document conversion script to be executable.
>> 
>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> xen/tools/convert_misra_doc.py | 0
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>> mode change 100644 => 100755 xen/tools/convert_misra_doc.py
> 
> Hmm, the real fix imo would be to add $(PYTHON), just like we use
> $(SHELL) to invoke shell scripts. This is to cover for file systems
> lacking a way to express executable permission. (Along with that I
> certainly wouldn't mind the mode change, but that would then only
> be for cosmetic reasons.)

Good point, I will submit a v2 doing both.

Cheers
Bertrand

> 
> Jan



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-03  8:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03  7:35 [PATCH] tools: make misra convert tool executable Bertrand Marquis
2022-08-03  7:55 ` Jan Beulich
2022-08-03  8:00   ` Bertrand Marquis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.