All of lore.kernel.org
 help / color / mirror / Atom feed
From: Meghana Madhyastha <meghana.madhyastha@gmail.com>
To: "Lee Jones" <lee.jones@linaro.org>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v19 01/10] video: backlight: Add helpers to enable and disable backlight
Date: Wed, 24 Jan 2018 16:34:07 +0000	[thread overview]
Message-ID: <39b5bf0a02008a8072d910bdf8231c431e9ef504.1516810725.git.meghana.madhyastha@gmail.com> (raw)
In-Reply-To: <cover.1516810725.git.meghana.madhyastha@gmail.com>

Add helper functions backlight_enable and backlight_disable to
enable/disable a backlight device. These helper functions can
then be used by different drm and tinydrm drivers to avoid
repetition of code and also to enforce a uniform and consistent
way to enable/disable a backlight device.

Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul<seanpaul@chromium.org>
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
 include/linux/backlight.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index af7003548..ace825e2c 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -130,6 +130,38 @@ static inline int backlight_update_status(struct backlight_device *bd)
 	return ret;
 }
 
+/**
+ * backlight_enable - Enable backlight
+ * @bd: the backlight device to enable
+ */
+static inline int backlight_enable(struct backlight_device *bd)
+{
+	if (!bd)
+		return 0;
+
+	bd->props.power = FB_BLANK_UNBLANK;
+	bd->props.fb_blank = FB_BLANK_UNBLANK;
+	bd->props.state &= ~BL_CORE_FBBLANK;
+
+	return backlight_update_status(bd);
+}
+
+/**
+ * backlight_disable - Disable backlight
+ * @bd: the backlight device to disable
+ */
+static inline int backlight_disable(struct backlight_device *bd)
+{
+	if (!bd)
+		return 0;
+
+	bd->props.power = FB_BLANK_POWERDOWN;
+	bd->props.fb_blank = FB_BLANK_POWERDOWN;
+	bd->props.state |= BL_CORE_FBBLANK;
+
+	return backlight_update_status(bd);
+}
+
 extern struct backlight_device *backlight_device_register(const char *name,
 	struct device *dev, void *devdata, const struct backlight_ops *ops,
 	const struct backlight_properties *props);
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Meghana Madhyastha <meghana.madhyastha@gmail.com>
To: "Lee Jones" <lee.jones@linaro.org>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v19 01/10] video: backlight: Add helpers to enable and disable backlight
Date: Wed, 24 Jan 2018 16:34:07 +0000	[thread overview]
Message-ID: <39b5bf0a02008a8072d910bdf8231c431e9ef504.1516810725.git.meghana.madhyastha@gmail.com> (raw)
In-Reply-To: <cover.1516810725.git.meghana.madhyastha@gmail.com>

Add helper functions backlight_enable and backlight_disable to
enable/disable a backlight device. These helper functions can
then be used by different drm and tinydrm drivers to avoid
repetition of code and also to enforce a uniform and consistent
way to enable/disable a backlight device.

Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul<seanpaul@chromium.org>
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
 include/linux/backlight.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index af7003548..ace825e2c 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -130,6 +130,38 @@ static inline int backlight_update_status(struct backlight_device *bd)
 	return ret;
 }
 
+/**
+ * backlight_enable - Enable backlight
+ * @bd: the backlight device to enable
+ */
+static inline int backlight_enable(struct backlight_device *bd)
+{
+	if (!bd)
+		return 0;
+
+	bd->props.power = FB_BLANK_UNBLANK;
+	bd->props.fb_blank = FB_BLANK_UNBLANK;
+	bd->props.state &= ~BL_CORE_FBBLANK;
+
+	return backlight_update_status(bd);
+}
+
+/**
+ * backlight_disable - Disable backlight
+ * @bd: the backlight device to disable
+ */
+static inline int backlight_disable(struct backlight_device *bd)
+{
+	if (!bd)
+		return 0;
+
+	bd->props.power = FB_BLANK_POWERDOWN;
+	bd->props.fb_blank = FB_BLANK_POWERDOWN;
+	bd->props.state |= BL_CORE_FBBLANK;
+
+	return backlight_update_status(bd);
+}
+
 extern struct backlight_device *backlight_device_register(const char *name,
 	struct device *dev, void *devdata, const struct backlight_ops *ops,
 	const struct backlight_properties *props);
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-01-24 16:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 16:32 [PATCH v19 00/10] Add backlight helper functions Meghana Madhyastha
2018-01-24 16:32 ` Meghana Madhyastha
2018-01-24 16:34 ` Meghana Madhyastha [this message]
2018-01-24 16:34   ` [PATCH v19 01/10] video: backlight: Add helpers to enable and disable backlight Meghana Madhyastha
2018-01-24 16:34 ` [PATCH v19 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable Meghana Madhyastha
2018-01-24 16:35 ` [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c Meghana Madhyastha
2018-01-24 16:35   ` Meghana Madhyastha
2018-01-25 14:14   ` Thierry Reding
2018-01-26  9:48   ` Lee Jones
2018-01-26  9:48     ` Lee Jones
2018-01-26 17:46     ` Randy Dunlap
2018-01-29  9:11       ` Lee Jones
2018-01-29 14:43         ` Sean Paul
2018-01-29 14:43           ` Sean Paul
2018-01-30  9:02           ` Lee Jones
2018-01-30  9:02             ` Lee Jones
2018-01-30  2:30         ` Randy Dunlap
2018-01-24 16:36 ` [PATCH v19 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight Meghana Madhyastha
2018-01-24 16:36   ` Meghana Madhyastha
2018-01-24 16:37 ` [PATCH v19 05/10] video: backlight: Add devres versions of of_find_backlight Meghana Madhyastha
2018-01-24 16:37   ` Meghana Madhyastha
2018-01-24 16:37 ` [PATCH v19 06/10] drm/tinydrm: Call devres version " Meghana Madhyastha
2018-01-24 16:37   ` Meghana Madhyastha
2018-01-24 16:39 ` [PATCH v19 07/10] drm/panel: Use backlight_enable/disable helpers Meghana Madhyastha
2018-01-25 14:08   ` Thierry Reding
2018-01-25 14:08     ` Thierry Reding
2018-01-24 16:40 ` [PATCH v19 08/10] drm/omapdrm: " Meghana Madhyastha
2018-01-24 16:40 ` [PATCH v19 09/10] drm/panel: Use of_find_backlight helper Meghana Madhyastha
2018-01-24 16:40   ` Meghana Madhyastha
2018-01-25 14:09   ` Thierry Reding
2018-01-25 14:09     ` Thierry Reding
2018-01-24 16:41 ` [PATCH v19 10/10] drm/omapdrm: " Meghana Madhyastha
2018-01-24 19:23   ` Sean Paul
2018-01-24 19:23     ` Sean Paul
2018-01-24 19:26     ` Sean Paul
2018-01-24 19:26       ` Sean Paul
2018-01-25 11:27       ` Daniel Thompson
2018-01-24 20:13   ` Noralf Trønnes
2018-01-24 20:13     ` Noralf Trønnes
2018-01-25 14:17 ` [PATCH v19 00/10] Add backlight helper functions Thierry Reding
2018-02-20 16:16 ` Sean Paul
2018-02-20 16:16   ` Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39b5bf0a02008a8072d910bdf8231c431e9ef504.1516810725.git.meghana.madhyastha@gmail.com \
    --to=meghana.madhyastha@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=seanpaul@chromium.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.