All of lore.kernel.org
 help / color / mirror / Atom feed
* Enabling gro_flush_timeout/napi_defer_hard_irqs per default in a driver?
@ 2021-03-10 20:22 Heiner Kallweit
  0 siblings, 0 replies; only message in thread
From: Heiner Kallweit @ 2021-03-10 20:22 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: netdev

In r8169 standard irq coalescing is disabled per default, and setting
gro_flush_timeout = 20000 and napi_defer_hard_irqs = 1 reduces interrupt
number significantly, e.g. in iperf.
Therefore I wonder whether it would make sense to set reasonable defaults
for both parameters in the driver, similar to drivers enabling irq
coalescing per default. This way users could benefit who are not
experienced enough to tweak sysfs parameters.
Now to the actual question:
Are you aware of any use cases where setting these parameters could
have a negative impact, what would speak for leaving them disabled
per default?

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-10 20:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 20:22 Enabling gro_flush_timeout/napi_defer_hard_irqs per default in a driver? Heiner Kallweit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.