All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: Help
       [not found]   ` <20090822073516.GD2108@elf.ucw.cz>
@ 2009-09-22 23:33     ` Rafael J. Wysocki
       [not found]     ` <200909230133.28689.rjw@sisk.pl>
  1 sibling, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2009-09-22 23:33 UTC (permalink / raw)
  To: kix; +Cc: suspend-devel List, pm list, stefan.seyfried

Hi kix,

On Saturday 22 August 2009, Pavel Machek wrote:
> Hi!
> 
> > > Message body follows:
> > > 
> > > I would like to help in the project.
> > > 
> > > - updating the database.
> > > 
> > > Have you seen the patch I sent?
> > 
> > Yes, sorry for the lack of response, but I didn't really have the time to
> > review the patch.
> > 
> > That said, I don't think we'd like to move the whitelist to a separate file.
> > Rather than that, we've been considering removing it altogether.
> > 
> > Still, if you want to maintain the whitelist in its current form, I think
> > you could do that.
> 
> Yes, maintainer for the whitelist would be very welcome.
> 
> Now... whitelist inside the binary is very welcome for init=/bin/bash,
> etc; OTOH if the .c file is compiled from .txt description... that's
> probably acceptable. Also it might make sense to load external
> whitelist _in addition_ to the internal one, so people can quickly
> experiment with whitelist entries...

If you're still willing to be a whitelist maintainer, please set up a git
repository from which I can pull the whitelist updates.

If you'd like to move the whitelist to a separate file, please do so.  You are
free to use whatever format you think is suitable, although it would be nice
if the whitelist file could be easily updated by users.

Best,
Rafael

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]     ` <200909230133.28689.rjw@sisk.pl>
@ 2009-09-23  8:34       ` Rodolfo (kix)
  2009-09-23 16:43       ` Help Pavel Machek
       [not found]       ` <3096bd910909230134v6ad1c5acr53b172d9472488e8@mail.gmail.com>
  2 siblings, 0 replies; 13+ messages in thread
From: Rodolfo (kix) @ 2009-09-23  8:34 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: suspend-devel List, kix, pm list

Hi Rafael,

I am thinking about the maintaining ...

1. The users sends the hardware info to be added to the database (now
by mail). Then:

1. Probably we need a little script (or web script? or post directly
form the s2ram -i?):
  1.a The script checks if the machine is previously added to the
database (in a text file). Probably this script can read from the
mailing list format

xxxx:% sudo /root/s2ram -i
This machine can be identified by:
    sys_vendor   = "TOSHIBA"
    sys_product  = "Satellite U305"
    sys_version  = "PSU34U-00L003"
    bios_version = "V1.70   "
See http://en.opensuse.org/S2ram for details.

  1.b If is not added, the script add the machine to a text file.

2. The text file can be processed using a little script to convert it
to the "whitelist.[c,h]" files and converted to web page (s2whitelist
and s2web :-))
3. The script can do a git update if needed.

In my opinion, the file should have this format:

<author info for the comment's
line>·<sys_vendor>·<sys_product>·<sys_version>·<bios_version>·<flags>

I am using the "·" separator because probably is not used in any field.

What do you think? Thanks.

Best Regards,

kix.

On Wed, Sep 23, 2009 at 1:33 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> Hi kix,
>
> On Saturday 22 August 2009, Pavel Machek wrote:
>> Hi!
>>
>> > > Message body follows:
>> > >
>> > > I would like to help in the project.
>> > >
>> > > - updating the database.
>> > >
>> > > Have you seen the patch I sent?
>> >
>> > Yes, sorry for the lack of response, but I didn't really have the time to
>> > review the patch.
>> >
>> > That said, I don't think we'd like to move the whitelist to a separate file.
>> > Rather than that, we've been considering removing it altogether.
>> >
>> > Still, if you want to maintain the whitelist in its current form, I think
>> > you could do that.
>>
>> Yes, maintainer for the whitelist would be very welcome.
>>
>> Now... whitelist inside the binary is very welcome for init=/bin/bash,
>> etc; OTOH if the .c file is compiled from .txt description... that's
>> probably acceptable. Also it might make sense to load external
>> whitelist _in addition_ to the internal one, so people can quickly
>> experiment with whitelist entries...
>
> If you're still willing to be a whitelist maintainer, please set up a git
> repository from which I can pull the whitelist updates.
>
> If you'd like to move the whitelist to a separate file, please do so.  You are
> free to use whatever format you think is suitable, although it would be nice
> if the whitelist file could be easily updated by users.
>
> Best,
> Rafael
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Suspend-devel mailing list
> Suspend-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/suspend-devel
>



-- 
Rodolfo García "kix"
EA4ERH - IN80ER

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Help
       [not found]     ` <200909230133.28689.rjw@sisk.pl>
  2009-09-23  8:34       ` [Suspend-devel] Help Rodolfo (kix)
@ 2009-09-23 16:43       ` Pavel Machek
       [not found]       ` <3096bd910909230134v6ad1c5acr53b172d9472488e8@mail.gmail.com>
  2 siblings, 0 replies; 13+ messages in thread
From: Pavel Machek @ 2009-09-23 16:43 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: suspend-devel List, kix, pm list, stefan.seyfried

Hi!

> > > > Message body follows:
> > > > 
> > > > I would like to help in the project.
> > > > 
> > > > - updating the database.
> > > > 
> > > > Have you seen the patch I sent?
> > > 
> > > Yes, sorry for the lack of response, but I didn't really have the time to
> > > review the patch.
> > > 
> > > That said, I don't think we'd like to move the whitelist to a separate file.
> > > Rather than that, we've been considering removing it altogether.
> > > 
> > > Still, if you want to maintain the whitelist in its current form, I think
> > > you could do that.
> > 
> > Yes, maintainer for the whitelist would be very welcome.
> > 
> > Now... whitelist inside the binary is very welcome for init=/bin/bash,
> > etc; OTOH if the .c file is compiled from .txt description... that's
> > probably acceptable. Also it might make sense to load external
> > whitelist _in addition_ to the internal one, so people can quickly
> > experiment with whitelist entries...
> 
> If you're still willing to be a whitelist maintainer, please set up a git
> repository from which I can pull the whitelist updates.

Yes, that would be great.

> If you'd like to move the whitelist to a separate file, please do so.  You are
> free to use whatever format you think is suitable, although it would be nice
> if the whitelist file could be easily updated by users.

Ack.
										Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]       ` <3096bd910909230134v6ad1c5acr53b172d9472488e8@mail.gmail.com>
@ 2009-09-23 22:28         ` Rafael J. Wysocki
       [not found]         ` <200909240028.03305.rjw@sisk.pl>
  1 sibling, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2009-09-23 22:28 UTC (permalink / raw)
  To: Rodolfo (kix); +Cc: suspend-devel List, kix, pm list

On Wednesday 23 September 2009, Rodolfo (kix) wrote:
> Hi Rafael,

Hi,

> I am thinking about the maintaining ...
> 
> 1. The users sends the hardware info to be added to the database (now
> by mail). Then:
> 
> 1. Probably we need a little script (or web script? or post directly
> form the s2ram -i?):
>   1.a The script checks if the machine is previously added to the
> database (in a text file). Probably this script can read from the
> mailing list format
> 
> xxxx:% sudo /root/s2ram -i
> This machine can be identified by:
>     sys_vendor   = "TOSHIBA"
>     sys_product  = "Satellite U305"
>     sys_version  = "PSU34U-00L003"
>     bios_version = "V1.70   "
> See http://en.opensuse.org/S2ram for details.
> 
>   1.b If is not added, the script add the machine to a text file.

However you arrange that is up to you.  My experience is that the users
generally send whitelist information by email.

> 2. The text file can be processed using a little script to convert it
> to the "whitelist.[c,h]" files and converted to web page (s2whitelist
> and s2web :-))
> 3. The script can do a git update if needed.

Well, I'm surely not going to allow the script to update the master git tree
at kernel.org directly.

> In my opinion, the file should have this format:
> 
> <author info for the comment's
> line>·<sys_vendor>·<sys_product>·<sys_version>·<bios_version>·<flags>
> 
> I am using the "·" separator because probably is not used in any field.

What's the code of this character?

Rafael

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]         ` <200909240028.03305.rjw@sisk.pl>
@ 2009-09-24 12:51           ` Stefan Seyfried
       [not found]           ` <20090924145128.26e758df@strolchi.home.s3e.de>
  1 sibling, 0 replies; 13+ messages in thread
From: Stefan Seyfried @ 2009-09-24 12:51 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: suspend-devel List, kix, Rodolfo (kix), pm list

On Thu, 24 Sep 2009 00:28:03 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Wednesday 23 September 2009, Rodolfo (kix) wrote:
> > Hi Rafael,
> 
> Hi,
> 
> > I am thinking about the maintaining ...

Good luck! I know that you'll need it ;)

Let me throw my 2 cents into the bowl.

> > 1. The users sends the hardware info to be added to the database
> > (now by mail). Then:
> > 
> > 1. Probably we need a little script (or web script? or post directly
> > form the s2ram -i?):
> >   1.a The script checks if the machine is previously added to the
> > database (in a text file). Probably this script can read from the
> > mailing list format
> > 
> > xxxx:% sudo /root/s2ram -i
> > This machine can be identified by:
> >     sys_vendor   = "TOSHIBA"
> >     sys_product  = "Satellite U305"
> >     sys_version  = "PSU34U-00L003"
> >     bios_version = "V1.70   "
> > See http://en.opensuse.org/S2ram for details.
> > 
> >   1.b If is not added, the script add the machine to a text file.
> 
> However you arrange that is up to you.  My experience is that the
> users generally send whitelist information by email.
> 
> > 2. The text file can be processed using a little script to convert
> > it to the "whitelist.[c,h]" files and converted to web page
> > (s2whitelist and s2web :-))
> > 3. The script can do a git update if needed.
> 
> Well, I'm surely not going to allow the script to update the master
> git tree at kernel.org directly.

There's also the issue that some sanity checking should be done before
adding an entry. Pretty often, users send some hilarious option
combinations, on machines that should nowadays just work without any
options (e.g. intel-based).

The next thing is, that I, personally, would reject any machines that
should work out of the box nowadays with in-kernel drivers (means:
intel, nvidia- and ATI binary-module driven). You can only make things
worse on such machines with userspace workarounds, and they should be
recognized automatically by recent (means: newer than 2 years)
pm-utils, so that no hack is needed. IMHO the whitelist should not be
cluttered with them.

> > In my opinion, the file should have this format:
> > 
> > <author info for the comment's
> > line>·<sys_vendor>·<sys_product>·<sys_version>·<bios_version>·<flags>
> > 
> > I am using the "·" separator because probably is not used in any
> > field.
> 
> What's the code of this character?

Something strange ;-)

I'd use the pipe character: '|'. I have not yet encountered it in
s2ram-relevant DMI data. It still is readable and not subject to
encoding issues AFAICT.

I'd put the author info / comment at the end, since then you can
sort/grep for sys_vendor easily, which is probably most useful.

And I still think that nowadays s2ram is the wrong tool for the
whitelist, but well... :-)

Good luck,

	Stefan
-- 
Stefan Seyfried

"Ceterum censeo whitelist.c esse delendam"
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]           ` <20090924145128.26e758df@strolchi.home.s3e.de>
@ 2009-09-24 17:53             ` Rafael J. Wysocki
       [not found]             ` <200909241953.46519.rjw@sisk.pl>
  1 sibling, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2009-09-24 17:53 UTC (permalink / raw)
  To: Stefan Seyfried; +Cc: suspend-devel List, kix, Rodolfo (kix), pm list

On Thursday 24 September 2009, Stefan Seyfried wrote:
> On Thu, 24 Sep 2009 00:28:03 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > On Wednesday 23 September 2009, Rodolfo (kix) wrote:
> > > Hi Rafael,
> > 
> > Hi,
> > 
> > > I am thinking about the maintaining ...
> 
> Good luck! I know that you'll need it ;)
> 
> Let me throw my 2 cents into the bowl.
> 
> > > 1. The users sends the hardware info to be added to the database
> > > (now by mail). Then:
> > > 
> > > 1. Probably we need a little script (or web script? or post directly
> > > form the s2ram -i?):
> > >   1.a The script checks if the machine is previously added to the
> > > database (in a text file). Probably this script can read from the
> > > mailing list format
> > > 
> > > xxxx:% sudo /root/s2ram -i
> > > This machine can be identified by:
> > >     sys_vendor   = "TOSHIBA"
> > >     sys_product  = "Satellite U305"
> > >     sys_version  = "PSU34U-00L003"
> > >     bios_version = "V1.70   "
> > > See http://en.opensuse.org/S2ram for details.
> > > 
> > >   1.b If is not added, the script add the machine to a text file.
> > 
> > However you arrange that is up to you.  My experience is that the
> > users generally send whitelist information by email.
> > 
> > > 2. The text file can be processed using a little script to convert
> > > it to the "whitelist.[c,h]" files and converted to web page
> > > (s2whitelist and s2web :-))
> > > 3. The script can do a git update if needed.
> > 
> > Well, I'm surely not going to allow the script to update the master
> > git tree at kernel.org directly.
> 
> There's also the issue that some sanity checking should be done before
> adding an entry. Pretty often, users send some hilarious option
> combinations, on machines that should nowadays just work without any
> options (e.g. intel-based).

Agreed.

> The next thing is, that I, personally, would reject any machines that
> should work out of the box nowadays with in-kernel drivers (means:
> intel, nvidia- and ATI binary-module driven). You can only make things
> worse on such machines with userspace workarounds, and they should be
> recognized automatically by recent (means: newer than 2 years)
> pm-utils, so that no hack is needed. IMHO the whitelist should not be
> cluttered with them.

Agreed in general, maybe except for the binary driver part.  I certainly prefer
people using s2ram's workarounds to people installing binary graphics drivers
just to make suspend work.

> > > In my opinion, the file should have this format:
> > > 
> > > <author info for the comment's
> > > line>·<sys_vendor>·<sys_product>·<sys_version>·<bios_version>·<flags>
> > > 
> > > I am using the "·" separator because probably is not used in any
> > > field.
> > 
> > What's the code of this character?
> 
> Something strange ;-)
> 
> I'd use the pipe character: '|'. I have not yet encountered it in
> s2ram-relevant DMI data. It still is readable and not subject to
> encoding issues AFAICT.

Yes, it is an ASCII character (officially called "vertical bar" BTW).

> I'd put the author info / comment at the end, since then you can
> sort/grep for sys_vendor easily, which is probably most useful.

Agreed.

> And I still think that nowadays s2ram is the wrong tool for the
> whitelist, but well... :-)

Oh, you know my opinion. ;-)

Still, if Rodolfo is willing to maintain the whitelist, I won't object.

Thanks,
Rafael
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]             ` <200909241953.46519.rjw@sisk.pl>
@ 2009-09-24 18:20               ` Kix
       [not found]               ` <5B7CD99A-A3B3-44EC-A073-31C0A5B7286B@gmail.com>
  1 sibling, 0 replies; 13+ messages in thread
From: Kix @ 2009-09-24 18:20 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: suspend-devel List, kix, Rodolfo (kix), pm list, Stefan Seyfried

Ok, I will write some lines to manage the whitelist. I will use your  
comments :-)

Thanks!



El 24/09/2009, a las 19:53, "Rafael J. Wysocki" <rjw@sisk.pl> escribió:

> On Thursday 24 September 2009, Stefan Seyfried wrote:
>> On Thu, 24 Sep 2009 00:28:03 +0200
>> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>>
>>> On Wednesday 23 September 2009, Rodolfo (kix) wrote:
>>>> Hi Rafael,
>>>
>>> Hi,
>>>
>>>> I am thinking about the maintaining ...
>>
>> Good luck! I know that you'll need it ;)
>>
>> Let me throw my 2 cents into the bowl.
>>
>>>> 1. The users sends the hardware info to be added to the database
>>>> (now by mail). Then:
>>>>
>>>> 1. Probably we need a little script (or web script? or post  
>>>> directly
>>>> form the s2ram -i?):
>>>>  1.a The script checks if the machine is previously added to the
>>>> database (in a text file). Probably this script can read from the
>>>> mailing list format
>>>>
>>>> xxxx:% sudo /root/s2ram -i
>>>> This machine can be identified by:
>>>>    sys_vendor   = "TOSHIBA"
>>>>    sys_product  = "Satellite U305"
>>>>    sys_version  = "PSU34U-00L003"
>>>>    bios_version = "V1.70   "
>>>> See http://en.opensuse.org/S2ram for details.
>>>>
>>>>  1.b If is not added, the script add the machine to a text file.
>>>
>>> However you arrange that is up to you.  My experience is that the
>>> users generally send whitelist information by email.
>>>
>>>> 2. The text file can be processed using a little script to convert
>>>> it to the "whitelist.[c,h]" files and converted to web page
>>>> (s2whitelist and s2web :-))
>>>> 3. The script can do a git update if needed.
>>>
>>> Well, I'm surely not going to allow the script to update the master
>>> git tree at kernel.org directly.
>>
>> There's also the issue that some sanity checking should be done  
>> before
>> adding an entry. Pretty often, users send some hilarious option
>> combinations, on machines that should nowadays just work without any
>> options (e.g. intel-based).
>
> Agreed.
>
>> The next thing is, that I, personally, would reject any machines that
>> should work out of the box nowadays with in-kernel drivers (means:
>> intel, nvidia- and ATI binary-module driven). You can only make  
>> things
>> worse on such machines with userspace workarounds, and they should be
>> recognized automatically by recent (means: newer than 2 years)
>> pm-utils, so that no hack is needed. IMHO the whitelist should not be
>> cluttered with them.
>
> Agreed in general, maybe except for the binary driver part.  I  
> certainly prefer
> people using s2ram's workarounds to people installing binary  
> graphics drivers
> just to make suspend work.
>
>>>> In my opinion, the file should have this format:
>>>>
>>>> <author info for the comment's
>>>> line>·<sys_vendor>·<sys_product>·<sys_version>·<bios_version>· 
>>>> <flags>
>>>>
>>>> I am using the "·" separator because probably is not used in any
>>>> field.
>>>
>>> What's the code of this character?
>>
>> Something strange ;-)
>>
>> I'd use the pipe character: '|'. I have not yet encountered it in
>> s2ram-relevant DMI data. It still is readable and not subject to
>> encoding issues AFAICT.
>
> Yes, it is an ASCII character (officially called "vertical bar" BTW).
>
>> I'd put the author info / comment at the end, since then you can
>> sort/grep for sys_vendor easily, which is probably most useful.
>
> Agreed.
>
>> And I still think that nowadays s2ram is the wrong tool for the
>> whitelist, but well... :-)
>
> Oh, you know my opinion. ;-)
>
> Still, if Rodolfo is willing to maintain the whitelist, I won't  
> object.
>
> Thanks,
> Rafael
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]               ` <5B7CD99A-A3B3-44EC-A073-31C0A5B7286B@gmail.com>
@ 2009-09-28 22:13                 ` Rodolfo (kix)
       [not found]                 ` <3096bd910909281513h134e505cy6631f998cd1cba5b@mail.gmail.com>
  1 sibling, 0 replies; 13+ messages in thread
From: Rodolfo (kix) @ 2009-09-28 22:13 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: suspend-devel List, kix, Rodolfo (kix), pm list, Stefan Seyfried

Hi!!

1. A new database file, comma separated, has been created (it was
terrible, I am very tired)
2. A little script to search in the database (using the "match"
function) is implemented
3. Other script to convert the database file to whitelist.c has been
created too.

The scripts has been created using perl. Why? because is fast, good
and is only for the database maintaning, not for the code
distribution.

Please, test it, the code is in http://www.kix.es/20090929/

Any comments are welcome.

-kix-

On Thu, Sep 24, 2009 at 8:20 PM, Kix <rodolfogarciap@gmail.com> wrote:
> Ok, I will write some lines to manage the whitelist. I will use your
> comments :-)
>
> Thanks!
>
>
>
> El 24/09/2009, a las 19:53, "Rafael J. Wysocki" <rjw@sisk.pl> escribió:
>
>> On Thursday 24 September 2009, Stefan Seyfried wrote:
>>>
>>> On Thu, 24 Sep 2009 00:28:03 +0200
>>> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>>>
>>>> On Wednesday 23 September 2009, Rodolfo (kix) wrote:
>>>>>
>>>>> Hi Rafael,
>>>>
>>>> Hi,
>>>>
>>>>> I am thinking about the maintaining ...
>>>
>>> Good luck! I know that you'll need it ;)
>>>
>>> Let me throw my 2 cents into the bowl.
>>>
>>>>> 1. The users sends the hardware info to be added to the database
>>>>> (now by mail). Then:
>>>>>
>>>>> 1. Probably we need a little script (or web script? or post directly
>>>>> form the s2ram -i?):
>>>>>  1.a The script checks if the machine is previously added to the
>>>>> database (in a text file). Probably this script can read from the
>>>>> mailing list format
>>>>>
>>>>> xxxx:% sudo /root/s2ram -i
>>>>> This machine can be identified by:
>>>>>   sys_vendor   = "TOSHIBA"
>>>>>   sys_product  = "Satellite U305"
>>>>>   sys_version  = "PSU34U-00L003"
>>>>>   bios_version = "V1.70   "
>>>>> See http://en.opensuse.org/S2ram for details.
>>>>>
>>>>>  1.b If is not added, the script add the machine to a text file.
>>>>
>>>> However you arrange that is up to you.  My experience is that the
>>>> users generally send whitelist information by email.
>>>>
>>>>> 2. The text file can be processed using a little script to convert
>>>>> it to the "whitelist.[c,h]" files and converted to web page
>>>>> (s2whitelist and s2web :-))
>>>>> 3. The script can do a git update if needed.
>>>>
>>>> Well, I'm surely not going to allow the script to update the master
>>>> git tree at kernel.org directly.
>>>
>>> There's also the issue that some sanity checking should be done before
>>> adding an entry. Pretty often, users send some hilarious option
>>> combinations, on machines that should nowadays just work without any
>>> options (e.g. intel-based).
>>
>> Agreed.
>>
>>> The next thing is, that I, personally, would reject any machines that
>>> should work out of the box nowadays with in-kernel drivers (means:
>>> intel, nvidia- and ATI binary-module driven). You can only make things
>>> worse on such machines with userspace workarounds, and they should be
>>> recognized automatically by recent (means: newer than 2 years)
>>> pm-utils, so that no hack is needed. IMHO the whitelist should not be
>>> cluttered with them.
>>
>> Agreed in general, maybe except for the binary driver part.  I certainly
>> prefer
>> people using s2ram's workarounds to people installing binary graphics
>> drivers
>> just to make suspend work.
>>
>>>>> In my opinion, the file should have this format:
>>>>>
>>>>> <author info for the comment's
>>>>> line>·<sys_vendor>·<sys_product>·<sys_version>·<bios_version>·<flags>
>>>>>
>>>>> I am using the "·" separator because probably is not used in any
>>>>> field.
>>>>
>>>> What's the code of this character?
>>>
>>> Something strange ;-)
>>>
>>> I'd use the pipe character: '|'. I have not yet encountered it in
>>> s2ram-relevant DMI data. It still is readable and not subject to
>>> encoding issues AFAICT.
>>
>> Yes, it is an ASCII character (officially called "vertical bar" BTW).
>>
>>> I'd put the author info / comment at the end, since then you can
>>> sort/grep for sys_vendor easily, which is probably most useful.
>>
>> Agreed.
>>
>>> And I still think that nowadays s2ram is the wrong tool for the
>>> whitelist, but well... :-)
>>
>> Oh, you know my opinion. ;-)
>>
>> Still, if Rodolfo is willing to maintain the whitelist, I won't object.
>>
>> Thanks,
>> Rafael
>



-- 
Rodolfo García "kix"
EA4ERH - IN80ER

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]                 ` <3096bd910909281513h134e505cy6631f998cd1cba5b@mail.gmail.com>
@ 2009-09-28 22:27                   ` Rafael J. Wysocki
       [not found]                   ` <200909290027.08115.rjw@sisk.pl>
  1 sibling, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2009-09-28 22:27 UTC (permalink / raw)
  To: Rodolfo (kix); +Cc: suspend-devel List, kix, pm list, Stefan Seyfried

On Tuesday 29 September 2009, Rodolfo (kix) wrote:
> Hi!!

Hi,

> 1. A new database file, comma separated, has been created (it was
> terrible, I am very tired)

Well, I can imagine. :-)

> 2. A little script to search in the database (using the "match"
> function) is implemented
> 3. Other script to convert the database file to whitelist.c has been
> created too.
> 
> The scripts has been created using perl. Why? because is fast, good
> and is only for the database maintaning, not for the code
> distribution.
> 
> Please, test it, the code is in http://www.kix.es/20090929/

OK, so the idea is that users wanting to add an entry to the whitelist will
edit the whitelist file and the use your script to generate a new
whitelist.c before building s2ram.  Is this correct?

Rafael

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]                   ` <200909290027.08115.rjw@sisk.pl>
@ 2009-09-28 22:57                     ` Kix
       [not found]                     ` <3A45B297-68FA-461E-9E31-864627534050@gmail.com>
  1 sibling, 0 replies; 13+ messages in thread
From: Kix @ 2009-09-28 22:57 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: suspend-devel List, kix, Rodolfo (kix), pm list, Stefan Seyfried





El 29/09/2009, a las 00:27, "Rafael J. Wysocki" <rjw@sisk.pl> escribió:

> On Tuesday 29 September 2009, Rodolfo (kix) wrote:
>> Hi!!
>
> Hi,
>
>> 1. A new database file, comma separated, has been created (it was
>> terrible, I am very tired)
>
> Well, I can imagine. :-)
>
>> 2. A little script to search in the database (using the "match"
>> function) is implemented
>> 3. Other script to convert the database file to whitelist.c has been
>> created too.
>>
>> The scripts has been created using perl. Why? because is fast, good
>> and is only for the database maintaning, not for the code
>> distribution.
>>
>> Please, test it, the code is in http://www.kix.es/20090929/
>
> OK, so the idea is that users wanting to add an entry to the  
> whitelist will
> edit the whitelist file and the use your script to generate a new
> whitelist.c before building s2ram.  Is this correct?

Really I don't know. Probably the users can send the entry to the mail  
list and (I | We) generate a new whitelist.c

Probably we can accept/ decline the new machine using other script and  
post it to the git automatically

I am not sure about if the users need the database file... IMO the  
database management and the whitelist.c creation should be monitorized  
and not fully open. A bad entry can be ... terrible?

Using your procedure, if two users modify the script at the some time  
and sent it, we will lost one entry, therefore we need to use diff  
between them.

On the other hand, probably the database can be "cleaned". Probably  
some entries can be dupplicated.

Time to sleep.

More opinions??

Kix

>
> Rafael
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]                       ` <200910041524.42266.rjw@sisk.pl>
@ 2009-11-11 11:22                         ` Rodolfo (kix)
       [not found]                         ` <3096bd910911110322w744a184cj99bf442d5baca1a2@mail.gmail.com>
  1 sibling, 0 replies; 13+ messages in thread
From: Rodolfo (kix) @ 2009-11-11 11:22 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: suspend-devel List, kix, pm list, Stefan Seyfried

Hi,

I come back from my vacations. I'm so tired and many many mail (and
dirty clothes to wash) ...

Is possible to add a new little configuration file in the suspend
distribution to testing? If the file exists, then, read it and if the
information is correct, apply it to suspend the machine. Else, load
the default machine-whitelist list.

If is correct, then, we can add new machines, tested, to the whitelist database.

kix

On Sun, Oct 4, 2009 at 2:24 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Tuesday 29 September 2009, Kix wrote:
>>
>> El 29/09/2009, a las 00:27, "Rafael J. Wysocki" <rjw@sisk.pl> escribió:
>>
>> > On Tuesday 29 September 2009, Rodolfo (kix) wrote:
>> >> Hi!!
>> >
>> > Hi,
>> >
>> >> 1. A new database file, comma separated, has been created (it was
>> >> terrible, I am very tired)
>> >
>> > Well, I can imagine. :-)
>> >
>> >> 2. A little script to search in the database (using the "match"
>> >> function) is implemented
>> >> 3. Other script to convert the database file to whitelist.c has been
>> >> created too.
>> >>
>> >> The scripts has been created using perl. Why? because is fast, good
>> >> and is only for the database maintaning, not for the code
>> >> distribution.
>> >>
>> >> Please, test it, the code is in http://www.kix.es/20090929/
>> >
>> > OK, so the idea is that users wanting to add an entry to the
>> > whitelist will
>> > edit the whitelist file and the use your script to generate a new
>> > whitelist.c before building s2ram.  Is this correct?
>>
>> Really I don't know. Probably the users can send the entry to the mail
>> list and (I | We) generate a new whitelist.c
>>
>> Probably we can accept/ decline the new machine using other script and
>> post it to the git automatically
>>
>> I am not sure about if the users need the database file... IMO the
>> database management and the whitelist.c creation should be monitorized
>> and not fully open. A bad entry can be ... terrible?
>
> There are two distinct things to consider here.  First, there's the whitelist.c
> that's available from the git repository and I agree that it should be
> carefully maintained.  Second, there are users with systems that are not
> in the white list and it would be nice to allow them to add their systems
> to their own copies of whitelist.c using a script that will check if the system
> is really new etc.  Then, these users would be able to send their copies of
> whitelist.c to us so that we can extract the relevant system information from
> them and add it to the "master" whitelist.c.
>
>> Using your procedure, if two users modify the script at the some time
>> and sent it, we will lost one entry, therefore we need to use diff
>> between them.
>>
>> On the other hand, probably the database can be "cleaned". Probably
>> some entries can be dupplicated.
>
> Agreed.
>
> Thanks,
> Rafael
>



-- 
Rodolfo García "kix"
EA4ERH - IN80ER

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]                         ` <3096bd910911110322w744a184cj99bf442d5baca1a2@mail.gmail.com>
@ 2009-11-11 11:32                           ` Rafael J. Wysocki
       [not found]                           ` <200911111232.27309.rjw@sisk.pl>
  1 sibling, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2009-11-11 11:32 UTC (permalink / raw)
  To: Rodolfo (kix); +Cc: suspend-devel List, kix, pm list, Stefan Seyfried

On Wednesday 11 November 2009, Rodolfo (kix) wrote:
> Hi,
> 
> I come back from my vacations. I'm so tired and many many mail (and
> dirty clothes to wash) ...
> 
> Is possible to add a new little configuration file in the suspend
> distribution to testing? If the file exists, then, read it and if the
> information is correct, apply it to suspend the machine. Else, load
> the default machine-whitelist list.
> 
> If is correct, then, we can add new machines, tested, to the whitelist database.

Yes, I think we can do that.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Suspend-devel] Help
       [not found]                           ` <200911111232.27309.rjw@sisk.pl>
@ 2009-11-11 11:33                             ` Rodolfo (kix)
  0 siblings, 0 replies; 13+ messages in thread
From: Rodolfo (kix) @ 2009-11-11 11:33 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: suspend-devel List, kix, pm list, Stefan Seyfried

Ok,

I will make a demo.

Thanks.

On Wed, Nov 11, 2009 at 12:32 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday 11 November 2009, Rodolfo (kix) wrote:
>> Hi,
>>
>> I come back from my vacations. I'm so tired and many many mail (and
>> dirty clothes to wash) ...
>>
>> Is possible to add a new little configuration file in the suspend
>> distribution to testing? If the file exists, then, read it and if the
>> information is correct, apply it to suspend the machine. Else, load
>> the default machine-whitelist list.
>>
>> If is correct, then, we can add new machines, tested, to the whitelist database.
>
> Yes, I think we can do that.
>
> Thanks,
> Rafael
>



-- 
Rodolfo García "kix"
EA4ERH - IN80ER

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2009-11-11 11:33 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <E1McOLX-0003Lq-BN@665xhf1.ch3.sourceforge.com>
     [not found] ` <200908152239.15915.rjw@sisk.pl>
     [not found]   ` <20090822073516.GD2108@elf.ucw.cz>
2009-09-22 23:33     ` Help Rafael J. Wysocki
     [not found]     ` <200909230133.28689.rjw@sisk.pl>
2009-09-23  8:34       ` [Suspend-devel] Help Rodolfo (kix)
2009-09-23 16:43       ` Help Pavel Machek
     [not found]       ` <3096bd910909230134v6ad1c5acr53b172d9472488e8@mail.gmail.com>
2009-09-23 22:28         ` [Suspend-devel] Help Rafael J. Wysocki
     [not found]         ` <200909240028.03305.rjw@sisk.pl>
2009-09-24 12:51           ` Stefan Seyfried
     [not found]           ` <20090924145128.26e758df@strolchi.home.s3e.de>
2009-09-24 17:53             ` Rafael J. Wysocki
     [not found]             ` <200909241953.46519.rjw@sisk.pl>
2009-09-24 18:20               ` Kix
     [not found]               ` <5B7CD99A-A3B3-44EC-A073-31C0A5B7286B@gmail.com>
2009-09-28 22:13                 ` Rodolfo (kix)
     [not found]                 ` <3096bd910909281513h134e505cy6631f998cd1cba5b@mail.gmail.com>
2009-09-28 22:27                   ` Rafael J. Wysocki
     [not found]                   ` <200909290027.08115.rjw@sisk.pl>
2009-09-28 22:57                     ` Kix
     [not found]                     ` <3A45B297-68FA-461E-9E31-864627534050@gmail.com>
     [not found]                       ` <200910041524.42266.rjw@sisk.pl>
2009-11-11 11:22                         ` Rodolfo (kix)
     [not found]                         ` <3096bd910911110322w744a184cj99bf442d5baca1a2@mail.gmail.com>
2009-11-11 11:32                           ` Rafael J. Wysocki
     [not found]                           ` <200911111232.27309.rjw@sisk.pl>
2009-11-11 11:33                             ` Rodolfo (kix)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.