Re: [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "Nicolau, Radu" <radu.nicolau@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>,
	"Jain, Deepak K" <deepak.k.jain@intel.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	"piotrx.t.azarewicz@intel.com" <piotrx.t.azarewicz@intel.com>
Subject: Re: [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000
Date: Wed, 5 Jul 2017 13:02:19 +0000	[thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A21C0FC@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1ab6bff3-7f84-ef00-b015-edb92ee73d40@intel.com>

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, June 27, 2017 12:36 PM
> > For 2, does the "use existing methods" include calling xstats? If so,
> > then we can just drop the requirement for 2 to have any new functions
> > implemented in the driver. Instead, have the information provided by
> > drivers in the normal xstats call, but have a new ethdev API to
> > provide that information to the app - basically hiding the xstats
> > complexity underneath.
> 
> I was thinking another dev_ops similar to xstats, but re-using xstats can be
> better idea here.
> 
> so option 2 becomes:
> [2] An eth_dev API to use existing APIs to get information from PMDs and
> wrap MIBs related xstats calls.
> 

Instead of getting information/configuration related mib attributes  in xstats_get,  we should  have new eth_dev op to get  all those mib attributes which don’t have any ethdev API. 
Then the new eth_dev API can call this new eth_dev op and other existing ethdev APIs to gather all mib information and expose that to user.

Thanks,
Reshma