From: Stephen Hemminger <stephen@networkplumber.org>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, reshma.pattan@intel.com,
michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com,
harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com
Subject: Re: [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe
Date: Tue, 27 Jun 2017 15:27:27 -0700 [thread overview]
Message-ID: <20170627152727.269f6f52@xeon-e3> (raw)
In-Reply-To: <1498469947-29496-1-git-send-email-radu.nicolau@intel.com>
On Mon, 26 Jun 2017 10:39:07 +0100
Radu Nicolau <radu.nicolau@intel.com> wrote:
> +static const struct rte_ixgbe_xstats_name_off ixgbe_if_mib_strings[] = {
> + {"ifNumber", offsetof(struct ixgbe_if_mib_stats, if_number)},
> + {"ifIndex", offsetof(struct ixgbe_if_mib_stats, if_index)},
> + {"ifType", offsetof(struct ixgbe_if_mib_stats, if_type)},
> + {"ifMtu", offsetof(struct ixgbe_if_mib_stats, if_mtu)},
> + {"ifSpeed", offsetof(struct ixgbe_if_mib_stats, if_speed)},
> + {"ifPhysAddress", offsetof(struct ixgbe_if_mib_stats, if_phys_address)},
> + {"ifOperStatus", offsetof(struct ixgbe_if_mib_stats, if_oper_status)},
> + {"ifLastChange", offsetof(struct ixgbe_if_mib_stats, if_last_change)},
> + {"ifHighSpeed", offsetof(struct ixgbe_if_mib_stats, if_high_speed)},
> + {"ifConnectorPresent", offsetof(struct ixgbe_if_mib_stats,
> + if_connector_present)},
> + {"ifCounterDiscontinuityTime", offsetof(struct ixgbe_if_mib_stats,
> + if_counter_discontinuity_time)},
Most of these should not be xstats. Things like if_index, type and MTU are available
through other API's already.
next prev parent reply other threads:[~2017-06-27 22:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 14:31 [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB Michal Jastrzebski
2017-05-22 14:32 ` [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 Michal Jastrzebski
2017-05-22 16:16 ` Pattan, Reshma
2017-05-22 16:34 ` Pattan, Reshma
2017-05-23 5:53 ` Lu, Wenzhuo
2017-06-20 11:38 ` Radu Nicolau
2017-06-26 9:42 ` [PATCH v2] " Radu Nicolau
2017-06-27 11:08 ` Ferruh Yigit
2017-06-27 11:21 ` Bruce Richardson
2017-06-27 11:36 ` Ferruh Yigit
2017-07-05 13:02 ` Pattan, Reshma
2017-06-27 22:26 ` Stephen Hemminger
2017-07-06 11:48 ` Pattan, Reshma
2017-07-19 10:40 ` Ferruh Yigit
2017-05-22 14:32 ` [PATCH 2/3] drivers/net: add support for IF-MIB and EtherLike-MIB for i40e Michal Jastrzebski
2017-05-31 5:29 ` Xing, Beilei
2017-06-26 9:41 ` [PATCH v2] " Radu Nicolau
2017-05-22 14:32 ` [PATCH 3/3] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe Michal Jastrzebski
2017-06-26 9:39 ` [PATCH v2] " Radu Nicolau
2017-06-27 22:27 ` Stephen Hemminger [this message]
2017-05-22 16:11 ` [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627152727.269f6f52@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
--cc=radu.nicolau@intel.com \
--cc=reshma.pattan@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.