All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun Sun <jsun@mvista.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-mips@oss.sgi.com, Ralf Baechle <ralf@oss.sgi.com>,
	Jeff Garzik <jgarzik@mandrakesoft.com>
Subject: Re: [2.4 PATCH] pcnet32.c - tx underflow error
Date: Fri, 12 Jul 2002 11:26:09 -0700	[thread overview]
Message-ID: <3D2F1F41.8030204@mvista.com> (raw)
In-Reply-To: Pine.LNX.4.44.0207112350440.21590-100000@freak.distro.conectiva

Marcelo Tosatti wrote:

> 
> On Thu, 11 Jul 2002, Alan Cox wrote:
> 
> 
>>>This patch fixes a tx underflow error for 79c973 chip.  It essentially delay
>>>the transmission until the whole packet is received into the on-chip sdram.
>>>
>>>The patch is already accepted by Marcelo for the 2.4 tree, I think.
>>>
>>Which slows the stuff down for people with real computers. Please apply
>>some kind of heuristic to this - eg switch to delaying if you exceed
>>50 failures in a 60 second period.
>>
> 
> I haven't applied it yet.
> 
> I'll let it come to me throught Jeff Garzik after the issues are resolved.
> 


Like I said earlier, I don't believe the benefit of run-time approach is worth 
the effort.  BTW, the heuristic method is not simple, mainly because there are 
mixed bags of chips in this family which requires different handling in this 
regard.

Since Alan seems to oppose this patch, I will fix this problem for now in the 
board code/firmware, which is not a totally unreasonable solution anyway. 
After all the firmware knows this board bus cannot handle 100Mb/s net.  If 
more people report the same problem later, that might be a better time to how 
to solve this problem.


Jun

      reply	other threads:[~2002-07-12 18:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-10 21:56 [2.4 PATCH] pcnet32.c - tx underflow error Jun Sun
2002-07-10 23:51 ` Alan Cox
2002-07-10 23:51   ` Alan Cox
2002-07-10 23:51   ` Jun Sun
2002-07-11  2:21     ` Alan Cox
2002-07-11  2:21       ` Alan Cox
2002-07-11  3:01     ` Jason Gunthorpe
2002-07-11  0:08   ` Jun Sun
2002-07-11  2:16     ` Alan Cox
2002-07-11  2:16       ` Alan Cox
2002-07-11  8:12       ` Thomas Bogendoerfer
2002-07-12  2:51   ` Marcelo Tosatti
2002-07-12  2:51     ` Marcelo Tosatti
2002-07-12 18:26     ` Jun Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D2F1F41.8030204@mvista.com \
    --to=jsun@mvista.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-mips@oss.sgi.com \
    --cc=marcelo@conectiva.com.br \
    --cc=ralf@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.