Re: [TCWG CI] Regression caused by linux: arm64: vdso32: require CROSS_COMPILE_COMPAT for gcc+bfd

* Re: [TCWG CI] Regression caused by linux: arm64: vdso32: require CROSS_COMPILE_COMPAT for gcc+bfd
       [not found] ` <810882F1-8476-435A-8B32-272F4D9D78D5@linaro.org>
@ 2021-11-03 17:07   ` Nick Desaulniers
  2021-11-03 17:13     ` Maxim Kuvyrkov
  0 siblings, 1 reply; 4+ messages in thread
From: Nick Desaulniers @ 2021-11-03 17:07 UTC (permalink / raw)
  To: Maxim Kuvyrkov; +Cc: llvm

On Wed, Nov 3, 2021 at 5:59 AM Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> wrote:
>
> Hi Nick,
>
> Is this known?

News to me. Thanks for the report. This is when building with clang?
Do you have the make invocation for this test?

>
> This was detected in linux-next a few days ago, but email notifications got lost.  Now this appears to have broken mainline.
>
> Regards,
>
> --
> Maxim Kuvyrkov
> https://www.linaro.org
>
> > On 3 Nov 2021, at 15:52, ci_notify@linaro.org wrote:
> >
> > [TCWG CI] Regression caused by linux: arm64: vdso32: require CROSS_COMPILE_COMPAT for gcc+bfd:
> > commit 3e6f8d1fa18457d54b20917bd9174d27daf09ab9
> > Author: Nick Desaulniers <ndesaulniers@google.com>
> >
> >    arm64: vdso32: require CROSS_COMPILE_COMPAT for gcc+bfd
> >
> > Results regressed to
> > # reset_artifacts:
> > -10
> > # build_abe binutils:
> > -9
> > # build_llvm:
> > -5
> > # build_abe qemu:
> > -2
> > # linux_n_obj:
> > 37
> > # First few build errors in logs:
> > # 00:01:21 error: unable to create target: 'No available targets are compatible with triple '
> > # 00:01:21 make[1]: *** [arch/arm64/kernel/vdso32/note.o] Error 1
> > # 00:01:21 error: unable to create target: 'No available targets are compatible with triple '
> > # 00:01:21 make[1]: *** [arch/arm64/kernel/vdso32/vgettimeofday.o] Error 1
> > # 00:01:21 make: *** [vdso_prepare] Error 2
> >
> > from
> > # reset_artifacts:
> > -10
> > # build_abe binutils:
> > -9
> > # build_llvm:
> > -5
> > # build_abe qemu:
> > -2
> > # linux_n_obj:
> > 7716
> > # linux build successful:
> > all
> > # linux boot successful:
> > boot
> >
> > THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
> >
> > This commit has regressed these CI configurations:
> > - tcwg_kernel/llvm-master-aarch64-next-defconfig
> > - tcwg_kernel/llvm-release-aarch64-mainline-defconfig
> > - tcwg_kernel/llvm-release-aarch64-next-defconfig
> >
> > First_bad build: https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/build-3e6f8d1fa18457d54b20917bd9174d27daf09ab9/
> > Last_good build: https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/build-14831fad73f5ac30ac61760487d95a538e6ab3cb/
> > Baseline build: https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/build-baseline/
> > Even more details: https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/
> >
> > Reproduce builds:
> > <cut>
> > mkdir investigate-linux-3e6f8d1fa18457d54b20917bd9174d27daf09ab9
> > cd investigate-linux-3e6f8d1fa18457d54b20917bd9174d27daf09ab9
> >
> > # Fetch scripts
> > git clone https://git.linaro.org/toolchain/jenkins-scripts
> >
> > # Fetch manifests and test.sh script
> > mkdir -p artifacts/manifests
> > curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/manifests/build-baseline.sh --fail
> > curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/manifests/build-parameters.sh --fail
> > curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_kernel-llvm-bisect-llvm-release-aarch64-mainline-defconfig/28/artifact/artifacts/test.sh --fail
> > chmod +x artifacts/test.sh
> >
> > # Reproduce the baseline build (build all pre-requisites)
> > ./jenkins-scripts/tcwg_kernel-build.sh @@ artifacts/manifests/build-baseline.sh
> >
> > # Save baseline build state (which is then restored in artifacts/test.sh)
> > mkdir -p ./bisect
> > rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /linux/ ./ ./bisect/baseline/
> >
> > cd linux
> >
> > # Reproduce first_bad build
> > git checkout --detach 3e6f8d1fa18457d54b20917bd9174d27daf09ab9
> > ../artifacts/test.sh
> >
> > # Reproduce last_good build
> > git checkout --detach 14831fad73f5ac30ac61760487d95a538e6ab3cb
> > ../artifacts/test.sh
> >
> > cd ..
> > </cut>
> >
> > Full commit (up to 1000 lines):
> > <cut>
> > commit 3e6f8d1fa18457d54b20917bd9174d27daf09ab9
> > Author: Nick Desaulniers <ndesaulniers@google.com>
> > Date:   Tue Oct 19 15:36:46 2021 -0700
> >
> >    arm64: vdso32: require CROSS_COMPILE_COMPAT for gcc+bfd
> >
> >    Similar to
> >    commit 231ad7f409f1 ("Makefile: infer --target from ARCH for CC=clang")
> >    There really is no point in setting --target based on
> >    $CROSS_COMPILE_COMPAT for clang when the integrated assembler is being
> >    used, since
> >    commit ef94340583ee ("arm64: vdso32: drop -no-integrated-as flag").
> >
> >    Allows COMPAT_VDSO to be selected without setting $CROSS_COMPILE_COMPAT
> >    when using clang and lld together.
> >
> >    Before:
> >    $ ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make -j72 LLVM=1 defconfig
> >    $ grep CONFIG_COMPAT_VDSO .config
> >    CONFIG_COMPAT_VDSO=y
> >    $ ARCH=arm64 make -j72 LLVM=1 defconfig
> >    $ grep CONFIG_COMPAT_VDSO .config
> >    $
> >
> >    After:
> >    $ ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make -j72 LLVM=1 defconfig
> >    $ grep CONFIG_COMPAT_VDSO .config
> >    CONFIG_COMPAT_VDSO=y
> >    $ ARCH=arm64 make -j72 LLVM=1 defconfig
> >    $ grep CONFIG_COMPAT_VDSO .config
> >    CONFIG_COMPAT_VDSO=y
> >
> >    Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> >    Suggested-by: Nathan Chancellor <nathan@kernel.org>
> >    Tested-by: Nathan Chancellor <nathan@kernel.org>
> >    Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> >    Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> >    Link: https://lore.kernel.org/r/20211019223646.1146945-5-ndesaulniers@google.com
> >    Signed-off-by: Will Deacon <will@kernel.org>
> > ---
> > arch/arm64/Kconfig                |  3 ++-
> > arch/arm64/kernel/vdso32/Makefile | 17 +++++------------
> > 2 files changed, 7 insertions(+), 13 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 5c7ae4c3954b..f0f2c95aa4c8 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -1264,7 +1264,8 @@ config KUSER_HELPERS
> >
> > config COMPAT_VDSO
> >       bool "Enable vDSO for 32-bit applications"
> > -     depends on !CPU_BIG_ENDIAN && "$(CROSS_COMPILE_COMPAT)" != ""
> > +     depends on !CPU_BIG_ENDIAN
> > +     depends on (CC_IS_CLANG && LD_IS_LLD) || "$(CROSS_COMPILE_COMPAT)" != ""
> >       select GENERIC_COMPAT_VDSO
> >       default y
> >       help
> > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
> > index e478cebb9891..c8fec493a450 100644
> > --- a/arch/arm64/kernel/vdso32/Makefile
> > +++ b/arch/arm64/kernel/vdso32/Makefile
> > @@ -10,18 +10,15 @@ include $(srctree)/lib/vdso/Makefile
> >
> > # Same as cc-*option, but using CC_COMPAT instead of CC
> > ifeq ($(CONFIG_CC_IS_CLANG), y)
> > -CC_COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%))
> > -
> > CC_COMPAT ?= $(CC)
> > -CC_COMPAT += $(CC_COMPAT_CLANG_FLAGS)
> > -
> > -ifneq ($(LLVM),)
> > -LD_COMPAT ?= $(LD)
> > +CC_COMPAT += --target=arm-linux-gnueabi
> > else
> > -LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld
> > +CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc
> > endif
> > +
> > +ifeq ($(CONFIG_LD_IS_LLD), y)
> > +LD_COMPAT ?= $(LD)
> > else
> > -CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc
> > LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld
> > endif
> >
> > @@ -45,10 +42,6 @@ VDSO_CPPFLAGS += $(LINUXINCLUDE)
> > # Common C and assembly flags
> > # From top-level Makefile
> > VDSO_CAFLAGS := $(VDSO_CPPFLAGS)
> > -ifneq ($(shell $(CC_COMPAT) --version 2>&1 | head -n 1 | grep clang),)
> > -VDSO_CAFLAGS += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%))
> > -endif
> > -
> > VDSO_CAFLAGS += $(call cc32-option,-fno-PIE)
> > ifdef CONFIG_DEBUG_INFO
> > VDSO_CAFLAGS += -g
> > </cut>
>

-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 4+ messages in thread