* [PATCH] HID: quirks: Always poll Anne Pro 2(C15) Keyboard
@ 2021-12-11 6:16 kortanzh
2022-01-06 21:33 ` Sebastian Parschauer
0 siblings, 1 reply; 2+ messages in thread
From: kortanzh @ 2021-12-11 6:16 UTC (permalink / raw)
To: jikos, benjamin.tissoires, s.parschauer; +Cc: linux-input, linux-kernel, Kortan
From: Kortan <kortanzh@gmail.com>
According to https://openannepro.github.io/ap2_revisionas, Anne Pro 2
keyboard has two hardware revisions, C15(04d9:a292) and C18(04d9:a293).
Previous patch submitted by Sebastian only fix the C18 revision. This
patch add missing C15 revision support.
Fixes: ca28aff0e1dc ("HID: quirks: Always poll Obins Anne Pro 2 keyboard")
Signed-off-by: Kortan <kortanzh@gmail.com>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-quirks.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 19da07777d62..3b1335cd19ba 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -644,6 +644,7 @@
#define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081 0xa081
#define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A0C2 0xa0c2
#define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A096 0xa096
+#define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A292 0xa292
#define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A293 0xa293
#define USB_VENDOR_ID_IMATION 0x0718
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index ee7e504e7279..2952ce3aa560 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -94,6 +94,7 @@ static const struct hid_device_id hid_quirks[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FIGHTING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FLYING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A096), HID_QUIRK_NO_INIT_REPORTS },
+ { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A292), HID_QUIRK_ALWAYS_POLL },
{ HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A293), HID_QUIRK_ALWAYS_POLL },
{ HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0A4A), HID_QUIRK_ALWAYS_POLL },
{ HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A), HID_QUIRK_ALWAYS_POLL },
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: quirks: Always poll Anne Pro 2(C15) Keyboard
2021-12-11 6:16 [PATCH] HID: quirks: Always poll Anne Pro 2(C15) Keyboard kortanzh
@ 2022-01-06 21:33 ` Sebastian Parschauer
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Parschauer @ 2022-01-06 21:33 UTC (permalink / raw)
To: kortanzh; +Cc: jikos, benjamin.tissoires, linux-input, linux-kernel
> Am 11.12.2021 um 07:16 schrieb kortanzh@gmail.com:
>
> From: Kortan <kortanzh@gmail.com>
>
> According to https://openannepro.github.io/ap2_revisionas, Anne Pro 2
> keyboard has two hardware revisions, C15(04d9:a292) and C18(04d9:a293).
>
> Previous patch submitted by Sebastian only fix the C18 revision. This
> patch add missing C15 revision support.
>
> Fixes: ca28aff0e1dc ("HID: quirks: Always poll Obins Anne Pro 2 keyboard")
> Signed-off-by: Kortan <kortanzh@gmail.com>
Thanks for the patch. I was actually the first one reporting the bug to them. They replied with something like „Why do you do a kernel patch? Nobody reported this bug before. We will fix our firmware.“ That reaction actually surprised me. Does this mean they didn’t?
They didn’t say anything about a second hardware revision which might be affected.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-06 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-11 6:16 [PATCH] HID: quirks: Always poll Anne Pro 2(C15) Keyboard kortanzh
2022-01-06 21:33 ` Sebastian Parschauer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.