Re: [PATCH 2/3] golang/xenlight: init xenlight go module

[George Dunlap <George.Dunlap@citrix.com>]

> On Apr 30, 2020, at 10:39 PM, Nick Rosbrook <rosbrookn@gmail.com> wrote:
> 
> Initialize the xenlight Go module using the xenbits git-http URL,
> xenbits.xen.org/git-http/xen.git/tools/golang/xenlight, and update the
> XEN_GOCODE_URL variable in tools/Rules.mk accordingly.
> 
> Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
> ---
> tools/Rules.mk               | 2 +-
> tools/golang/xenlight/go.mod | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
> create mode 100644 tools/golang/xenlight/go.mod
> 
> diff --git a/tools/Rules.mk b/tools/Rules.mk
> index 5b8cf748ad..ca33cc7b31 100644
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -36,7 +36,7 @@ debug ?= y
> debug_symbols ?= $(debug)
> 
> XEN_GOPATH        = $(XEN_ROOT)/tools/golang
> -XEN_GOCODE_URL    = golang.xenproject.org
> +XEN_GOCODE_URL    = xenbits.xen.org/git-http/xen.git/tools/golang

The primary effect of this will be to install the code in $PREFIX/share/gocode/xenbits.xen.org/git-http/xen.git/tools/golang/xenlight when making debballs or doing `make install`.

I don’t immediately see the advantage of that, particularly if we’re still thinking about having a “prettier” path at some point in the future.  What was your thinking here?

> ifeq ($(debug_symbols),y)
> CFLAGS += -g3
> diff --git a/tools/golang/xenlight/go.mod b/tools/golang/xenlight/go.mod
> new file mode 100644
> index 0000000000..232d102153
> --- /dev/null
> +++ b/tools/golang/xenlight/go.mod
> @@ -0,0 +1 @@
> +module xenbits.xen.org/git-http/xen.git/tools/golang/xenlight

This should probably be s/xen/xenproject/; 

If you want I could check in a version of this patch with just the go.mod, with that change.

 -George