Re: [PATCH 2/3] golang/xenlight: init xenlight go module

From: Nick Rosbrook <rosbrookn@gmail.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Wei Liu <wl@xen.org>, Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH 2/3] golang/xenlight: init xenlight go module
Date: Tue, 12 May 2020 11:06:02 -0400	[thread overview]
Message-ID: <CAEBZRSdWCJo9kBnNv6Jqt76E3fb8DDX6C4zndMtvrhngEzGHxg@mail.gmail.com> (raw)
In-Reply-To: <3ED0B49D-123C-4925-B3A0-4FA0B44DF9F0@citrix.com>

On Tue, May 12, 2020 at 10:36 AM George Dunlap <George.Dunlap@citrix.com> wrote:
>
>
>
> > On Apr 30, 2020, at 10:39 PM, Nick Rosbrook <rosbrookn@gmail.com> wrote:
> >
> > Initialize the xenlight Go module using the xenbits git-http URL,
> > xenbits.xen.org/git-http/xen.git/tools/golang/xenlight, and update the
> > XEN_GOCODE_URL variable in tools/Rules.mk accordingly.
> >
> > Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
> > ---
> > tools/Rules.mk               | 2 +-
> > tools/golang/xenlight/go.mod | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> > create mode 100644 tools/golang/xenlight/go.mod
> >
> > diff --git a/tools/Rules.mk b/tools/Rules.mk
> > index 5b8cf748ad..ca33cc7b31 100644
> > --- a/tools/Rules.mk
> > +++ b/tools/Rules.mk
> > @@ -36,7 +36,7 @@ debug ?= y
> > debug_symbols ?= $(debug)
> >
> > XEN_GOPATH        = $(XEN_ROOT)/tools/golang
> > -XEN_GOCODE_URL    = golang.xenproject.org
> > +XEN_GOCODE_URL    = xenbits.xen.org/git-http/xen.git/tools/golang
>
> The primary effect of this will be to install the code in $PREFIX/share/gocode/xenbits.xen.org/git-http/xen.git/tools/golang/xenlight when making debballs or doing `make install`.
>
> I don’t immediately see the advantage of that, particularly if we’re still thinking about having a “prettier” path at some point in the future.  What was your thinking here?

With the module being defined as `xenbits.xen.org/...`, the `build`
Make target will fail as-is for a module-aware version of go (because
it cannot find a module named `golang.xenproject.org/xenlight`). So,
the reason for this change is to preserve the existing functionality
of that Make target. Changing XEN_GOCODE_URL seemed like the correct
change, but I'm open to suggestions.

>
> > ifeq ($(debug_symbols),y)
> > CFLAGS += -g3
> > diff --git a/tools/golang/xenlight/go.mod b/tools/golang/xenlight/go.mod
> > new file mode 100644
> > index 0000000000..232d102153
> > --- /dev/null
> > +++ b/tools/golang/xenlight/go.mod
> > @@ -0,0 +1 @@
> > +module xenbits.xen.org/git-http/xen.git/tools/golang/xenlight
>
> This should probably be s/xen/xenproject/;

AFAICT, that's the correct URL, e.g. [1] and [2]. Am I missing something?

Thanks,
-NR

[1] https://pkg.go.dev/mod/xenbits.xen.org/git-http/xen.git
[2] https://xenbits.xen.org/gitweb/?p=xen.git;a=summary