Re: mpc8xx memory mapped 16550 extrenal uart driver

Re: mpc8xx memory mapped 16550 extrenal uart driver

[Steven Scholz]

Lokesh Kumar wrote:

> I got the serial.c from DENX and am using it as a module. When I start it,
> it correctly recognizes that I have a 16550A serial and at correct IRQ.
> However, when I open and send something through the port, I get garbage on
> the other side. My 16550 has a crystal of 3.6864MHz and the processor runs
> at 49MHz. I thought that this kind of garbage problem is generally due to
> baud rate not set correctly. I see the divisor correctly calculated as
> 3686400/16/9600 = 24 and being sent to 16550. What else could be wrong?

Hmm. No idea. Sorry.

Did you try this?

Send one character over and over again over you serial line and use a scope to
measure the bit time. Just to make sure that timing is correct.

Steven


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: mpc8xx memory mapped 16550 extrenal uart driver

[Steven Scholz]

Hi Lokesh,

> Does anybody know of a driver for an external 16550 memory mapped uart
> driver for an mpc855 based board? Any help is appreciated?

Have a look at linuxppc_2_4_devel at DENX CVS between LABEL_2003_03_11_2055 and
LABEL_2003_03_11_2110.

This extension (for our board called DAB4K) makes it possible to use the
standard linux serial driver with an external, memory mapped 16C752B dual uart.
This one is recocnized by linux as two ST16654:

...
Serial driver version 5.05c (2001-07-08) with no serial options enabled
ttyS00 at 0xc3071000 (irq = 6) is a ST16654
ttyS01 at 0xc3071080 (irq = 8) is a ST16654
...

We then use

~ # ls -l /dev/ttyS*e
crw-r--r--    1 root     root     204,  64 Mar 12  2003 /dev/ttyS0e
crw-rw----    1 root     root     204,  65 Sep 29 13:19 /dev/ttyS1e

to access them. Works fine. Thanks to DENX.

Hope this helps!

--
Steven Scholz

imc Measurement & Control               imc Meßsysteme GmbH
Voltastr. 5                             Voltastr. 5
13355 Berlin                            13355 Berlin
Germany                                 Deutschland
fon: +49 30 467090-0                    Tel: 030 / 467090-0
fax: +49 30 4631576                     fax: 030 / 4631576


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Lokesh Kumar]

Thanks for your reply,
I am using serial.c from denx 2.4.4 kernel, for creating a module called
serial.o for my 16550 external uart. I made the modifications suggested by
you. However, what I do not understand is -

what is TTY2_MAJOR? Why is it required?
what device node am I supposed to create? Is it TTY2_MAJOR (240)? What is
the minor number?

When I create /dev/ttySp0 (which is what I understood), and do
cat>/dev/ttySp0, the port open comes back with success, but then it says
"write: Input/Ouput error" and closes with rs_close.

What am I doing wrong??

I also remember one earlier discussion in which Wolfgang (denx) said that
they had a nonstandard driver for such purpose, but for a different chip. Is
that what I am supposed to do too?

Thanks for any help

Lokesh

-----Original Message-----
From: Rod Boyce [mailto:rod_boyce@stratexnet.com]
Sent: Sunday, October 05, 2003 3:04 PM
To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


Lokesh,

There are quite a few things you need to change to get this to work for your
board.  Firstly there is a define called SERIAL_DEV_OFFSET in
drivers/char/serial.c you need to set this to a value for your board so
TTY's for this driver are greater than your MPC855 UARTs.  We do not use
this as a loadable module so I can't comment on operation in that way.
Secondly in the file <kernel root>/include/asm/serial.h you are going to
need to define the operation mode and the address' of the serial device here
is our one:
#define STD_SERIAL_PORT_DEFNS			\
	{ 0, BASE_BAUD, 0, 14, ASYNC_BOOT_AUTOCONF, 0, 0, 0, 0, 0, 0, 0, \
	  (void*)0xf3000000, 0, 0, 0, {},{},{},SERIAL_IO_MEM },  \
	{ 0, BASE_BAUD, 0, 15, ASYNC_BOOT_AUTOCONF, 0, 0, 0, 0, 0, 0, 0, \
	  (void*)0xf4000000, 0, 0, 0, {},{},{},SERIAL_IO_MEM },
The important fields are the interrupt field, the base address field, and
the operation mode.  The interrupt on the first line is 14 and the second
line is 15.  The base address is the 0xF3000000 and 0xF4000000.  The
operation mode is the last entry in this structure note this structure has
more fields but we are not interested in these.
Next the interrupt field is very important.  Linux has the notion of virtual
hardware interrupts and physical hardware interrupts.  You have to choose a
physical interrupt for your board that is not used by anything else in your
hardware and hook that up to an unused virtual hardware interrupt.  This is
code you are going to have to write yourself it is very simple and just a
matter of unpeeling the layers.  I will list the files I changed to hook
this up for our hardware. (NOTE there may be an easier way to do this but
this works for us)
         <kernel root>/include/asm/irq.h
         <kernel root>/arch/ppc/kernel/irq.c
         <kernel root>/arch/ppc/kernel/ppx8xx_pic.c
         <kernel root>/arch/ppc/8xx_io/commproc.c
         <kernel root>/drivers/char/serial.c
         <kernel root>/include/asm/serial.h
         <kernel root>/include/asm/[board specific defines file].h


Hope this helps as I have said above I do not use this driver as a module so
I have no idea how that is going to impact your work.  This is what I did
and it took me about 1 1/2 days to figure it out and make it work.  We have
a DUART on our hardware.

Good luck,
Rod Boyce

> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Saturday, 4 October 2003 5:46 a.m.
> To: 'Steven Blakeslee'; Lokesh Kumar; 'linuxppc-
> embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> HI Steven,
> Let me tell few more details of the board I have. I am using SMC1 and 2 as
> serial and SCC1 as serial as well. Then there is the fourth serial  which
> is
> 16550 memory mapped. I want to load the driver for the 16550 as module,
> and
> do all the mapping and chip select setup in the module itself.
>
> Now, if I use serial.c as the module for 16550, are there any things I
> need
> to do i.e. tty names, minor and major numbers etc?
>
> Lokesh
>
> -----Original Message-----
> From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
> Sent: Friday, October 03, 2003 9:49 AM
> To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> You can do the mapping anywhere you want, anywhere you do specific board
> initialization is a good spot.  Check out
> arch/ppc/platforms/sandpoint_setup.c
> arch/ppc/platforms/sandpoint_serial.h
> for an example on setting up the serial device.
>
>
> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Friday, October 03, 2003 9:26 AM
> To: 'Steven Blakeslee'; Lokesh Kumar;
> 'linuxppc-embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> Hi Steven,
> Thanks for the quick reply. I did look at serial.c, however, i did not
> find
> where do we map the device to the memory i.e. where are we doing chip
> select
> setting and stuff. I saw that being done for CONFIG_SERIAL_TTTECH. Is that
> what you are referring to or I am missing the point completely?
>
> Lokesh
>
> -----Original Message-----
> From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
> Sent: Friday, October 03, 2003 9:16 AM
> To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> It's already in there.  drivers/char/serial.c
>
> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Friday, October 03, 2003 9:02 AM
> To: 'linuxppc-embedded@lists.linuxppc.org'
> Subject: mpc8xx memory mapped 16550 extrenal uart driver
>
>
>
> Hi gurus,
>
> Does anybody know of a driver for an external 16550 memory mapped uart
> driver for an mpc855 based board? Any help is appreciated?
>
>
> Lokesh Kumar
> Wireless Matrix USA Inc.
> 703-262-4032
>
>

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Rod Boyce]

Lokesh,

There are quite a few things you need to change to get this to work for your
board.  Firstly there is a define called SERIAL_DEV_OFFSET in
drivers/char/serial.c you need to set this to a value for your board so
TTY's for this driver are greater than your MPC855 UARTs.  We do not use
this as a loadable module so I can't comment on operation in that way.
Secondly in the file <kernel root>/include/asm/serial.h you are going to
need to define the operation mode and the address' of the serial device here
is our one:
#define STD_SERIAL_PORT_DEFNS			\
	{ 0, BASE_BAUD, 0, 14, ASYNC_BOOT_AUTOCONF, 0, 0, 0, 0, 0, 0, 0, \
	  (void*)0xf3000000, 0, 0, 0, {},{},{},SERIAL_IO_MEM },  \
	{ 0, BASE_BAUD, 0, 15, ASYNC_BOOT_AUTOCONF, 0, 0, 0, 0, 0, 0, 0, \
	  (void*)0xf4000000, 0, 0, 0, {},{},{},SERIAL_IO_MEM },
The important fields are the interrupt field, the base address field, and
the operation mode.  The interrupt on the first line is 14 and the second
line is 15.  The base address is the 0xF3000000 and 0xF4000000.  The
operation mode is the last entry in this structure note this structure has
more fields but we are not interested in these.
Next the interrupt field is very important.  Linux has the notion of virtual
hardware interrupts and physical hardware interrupts.  You have to choose a
physical interrupt for your board that is not used by anything else in your
hardware and hook that up to an unused virtual hardware interrupt.  This is
code you are going to have to write yourself it is very simple and just a
matter of unpeeling the layers.  I will list the files I changed to hook
this up for our hardware. (NOTE there may be an easier way to do this but
this works for us)
         <kernel root>/include/asm/irq.h
         <kernel root>/arch/ppc/kernel/irq.c
         <kernel root>/arch/ppc/kernel/ppx8xx_pic.c
         <kernel root>/arch/ppc/8xx_io/commproc.c
         <kernel root>/drivers/char/serial.c
         <kernel root>/include/asm/serial.h
         <kernel root>/include/asm/[board specific defines file].h


Hope this helps as I have said above I do not use this driver as a module so
I have no idea how that is going to impact your work.  This is what I did
and it took me about 1 1/2 days to figure it out and make it work.  We have
a DUART on our hardware.

Good luck,
Rod Boyce

> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Saturday, 4 October 2003 5:46 a.m.
> To: 'Steven Blakeslee'; Lokesh Kumar; 'linuxppc-
> embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> HI Steven,
> Let me tell few more details of the board I have. I am using SMC1 and 2 as
> serial and SCC1 as serial as well. Then there is the fourth serial  which
> is
> 16550 memory mapped. I want to load the driver for the 16550 as module,
> and
> do all the mapping and chip select setup in the module itself.
>
> Now, if I use serial.c as the module for 16550, are there any things I
> need
> to do i.e. tty names, minor and major numbers etc?
>
> Lokesh
>
> -----Original Message-----
> From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
> Sent: Friday, October 03, 2003 9:49 AM
> To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> You can do the mapping anywhere you want, anywhere you do specific board
> initialization is a good spot.  Check out
> arch/ppc/platforms/sandpoint_setup.c
> arch/ppc/platforms/sandpoint_serial.h
> for an example on setting up the serial device.
>
>
> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Friday, October 03, 2003 9:26 AM
> To: 'Steven Blakeslee'; Lokesh Kumar;
> 'linuxppc-embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> Hi Steven,
> Thanks for the quick reply. I did look at serial.c, however, i did not
> find
> where do we map the device to the memory i.e. where are we doing chip
> select
> setting and stuff. I saw that being done for CONFIG_SERIAL_TTTECH. Is that
> what you are referring to or I am missing the point completely?
>
> Lokesh
>
> -----Original Message-----
> From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
> Sent: Friday, October 03, 2003 9:16 AM
> To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
> Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> It's already in there.  drivers/char/serial.c
>
> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Friday, October 03, 2003 9:02 AM
> To: 'linuxppc-embedded@lists.linuxppc.org'
> Subject: mpc8xx memory mapped 16550 extrenal uart driver
>
>
>
> Hi gurus,
>
> Does anybody know of a driver for an external 16550 memory mapped uart
> driver for an mpc855 based board? Any help is appreciated?
>
>
> Lokesh Kumar
> Wireless Matrix USA Inc.
> 703-262-4032
>
>

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Rod Boyce]

The standard serial driver will work in this mode without modification.
This is how we are using it on our MPC860 board.


Rod

> -----Original Message-----
> From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
> Sent: Saturday, 4 October 2003 1:02 a.m.
> To: 'linuxppc-embedded@lists.linuxppc.org'
> Subject: mpc8xx memory mapped 16550 extrenal uart driver
>
>
> Hi gurus,
>
> Does anybody know of a driver for an external 16550 memory mapped uart
> driver for an mpc855 based board? Any help is appreciated?
>
>
> Lokesh Kumar
> Wireless Matrix USA Inc.
> 703-262-4032
>
>

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Lokesh Kumar]

HI Steven,
Let me tell few more details of the board I have. I am using SMC1 and 2 as
serial and SCC1 as serial as well. Then there is the fourth serial  which is
16550 memory mapped. I want to load the driver for the 16550 as module, and
do all the mapping and chip select setup in the module itself.

Now, if I use serial.c as the module for 16550, are there any things I need
to do i.e. tty names, minor and major numbers etc?

Lokesh

-----Original Message-----
From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
Sent: Friday, October 03, 2003 9:49 AM
To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


You can do the mapping anywhere you want, anywhere you do specific board
initialization is a good spot.  Check out
arch/ppc/platforms/sandpoint_setup.c
arch/ppc/platforms/sandpoint_serial.h
for an example on setting up the serial device.


-----Original Message-----
From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
Sent: Friday, October 03, 2003 9:26 AM
To: 'Steven Blakeslee'; Lokesh Kumar;
'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


Hi Steven,
Thanks for the quick reply. I did look at serial.c, however, i did not find
where do we map the device to the memory i.e. where are we doing chip select
setting and stuff. I saw that being done for CONFIG_SERIAL_TTTECH. Is that
what you are referring to or I am missing the point completely?

Lokesh

-----Original Message-----
From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
Sent: Friday, October 03, 2003 9:16 AM
To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


It's already in there.  drivers/char/serial.c

-----Original Message-----
From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
Sent: Friday, October 03, 2003 9:02 AM
To: 'linuxppc-embedded@lists.linuxppc.org'
Subject: mpc8xx memory mapped 16550 extrenal uart driver



Hi gurus,

Does anybody know of a driver for an external 16550 memory mapped uart
driver for an mpc855 based board? Any help is appreciated?


Lokesh Kumar
Wireless Matrix USA Inc.
703-262-4032


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Steven Blakeslee]

You can do the mapping anywhere you want, anywhere you do specific board
initialization is a good spot.  Check out
arch/ppc/platforms/sandpoint_setup.c
arch/ppc/platforms/sandpoint_serial.h
for an example on setting up the serial device.


-----Original Message-----
From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
Sent: Friday, October 03, 2003 9:26 AM
To: 'Steven Blakeslee'; Lokesh Kumar;
'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


Hi Steven,
Thanks for the quick reply. I did look at serial.c, however, i did not find
where do we map the device to the memory i.e. where are we doing chip select
setting and stuff. I saw that being done for CONFIG_SERIAL_TTTECH. Is that
what you are referring to or I am missing the point completely?

Lokesh

-----Original Message-----
From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
Sent: Friday, October 03, 2003 9:16 AM
To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


It's already in there.  drivers/char/serial.c

-----Original Message-----
From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
Sent: Friday, October 03, 2003 9:02 AM
To: 'linuxppc-embedded@lists.linuxppc.org'
Subject: mpc8xx memory mapped 16550 extrenal uart driver



Hi gurus,

Does anybody know of a driver for an external 16550 memory mapped uart
driver for an mpc855 based board? Any help is appreciated?


Lokesh Kumar
Wireless Matrix USA Inc.
703-262-4032


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Lokesh Kumar]

Hi Steven,
Thanks for the quick reply. I did look at serial.c, however, i did not find
where do we map the device to the memory i.e. where are we doing chip select
setting and stuff. I saw that being done for CONFIG_SERIAL_TTTECH. Is that
what you are referring to or I am missing the point completely?

Lokesh

-----Original Message-----
From: Steven Blakeslee [mailto:BlakesleeS@embeddedplanet.com]
Sent: Friday, October 03, 2003 9:16 AM
To: 'Lokesh Kumar'; 'linuxppc-embedded@lists.linuxppc.org'
Subject: RE: mpc8xx memory mapped 16550 extrenal uart driver


It's already in there.  drivers/char/serial.c

-----Original Message-----
From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
Sent: Friday, October 03, 2003 9:02 AM
To: 'linuxppc-embedded@lists.linuxppc.org'
Subject: mpc8xx memory mapped 16550 extrenal uart driver



Hi gurus,

Does anybody know of a driver for an external 16550 memory mapped uart
driver for an mpc855 based board? Any help is appreciated?


Lokesh Kumar
Wireless Matrix USA Inc.
703-262-4032


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: mpc8xx memory mapped 16550 extrenal uart driver

[Steven Blakeslee]

It's already in there.  drivers/char/serial.c

-----Original Message-----
From: Lokesh Kumar [mailto:kumar.lokesh@wrx-us.com]
Sent: Friday, October 03, 2003 9:02 AM
To: 'linuxppc-embedded@lists.linuxppc.org'
Subject: mpc8xx memory mapped 16550 extrenal uart driver



Hi gurus,

Does anybody know of a driver for an external 16550 memory mapped uart
driver for an mpc855 based board? Any help is appreciated?


Lokesh Kumar
Wireless Matrix USA Inc.
703-262-4032


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

mpc8xx memory mapped 16550 extrenal uart driver

[Lokesh Kumar]

Hi gurus,

Does anybody know of a driver for an external 16550 memory mapped uart
driver for an mpc855 based board? Any help is appreciated?


Lokesh Kumar
Wireless Matrix USA Inc.
703-262-4032


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/