All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Network Development <netdev@vger.kernel.org>
Subject: Re: reset value of MV88E6XXX_G1_IEEE_PRI
Date: Mon, 3 Jun 2019 11:14:39 +0000	[thread overview]
Message-ID: <3a016cd4-ee15-7365-347e-69dfc20c04de@prevas.dk> (raw)
In-Reply-To: <20190527102037.GB31320@t480s.localdomain>

On 27/05/2019 16.20, Vivien Didelot wrote:
> Hi Rasmus,
> 
>>
>> Based on the very systematic description [ieee tags 7 and 6 are mapped
>> to 3, 5 and 4 to 2, 3 and 2 to 1, and 1 and 0 to 0], I strongly believe
>> that 0xfa50 is also the reset value for the 6085, so this is most likely
>> wrong for all the current chips - though I don't have a 6085 data sheet.
>>
>> I can certainly add a 6250 variant that does the right thing for the
>> 6250, and I probably will - this is more a question about the current code.
> 
> Good catch, I double checked 88E6085 and 88E6352 and both describe
> a reset value of 0xFA50. Fixing mv88e6085_g1_ieee_pri_map should
> be enough.

Urgh, yes, but now that I got access to other data sheets I also checked
88e6095, and that actually does describe a reset value of 0xfa41. So
that value is not taken out of thin air, though it does not apply to the
chip variant that the current mv88e6085_g1_ieee_pri_map helper is named
after :(

So I think I'll add a mv88e6250_g1_ieee_pri_map for the chip I'm working
on, then other chips that have 0xfa50 as the reset value can be switched
over to use that one by one, double-checking the data sheet (and ideally
also the actual hardware...) for each one.

Rasmus



      reply	other threads:[~2019-06-03 11:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:36 reset value of MV88E6XXX_G1_IEEE_PRI Rasmus Villemoes
2019-05-27 12:32 ` Vivien Didelot
2019-05-27 13:02   ` Rasmus Villemoes
2019-05-27 14:20     ` Vivien Didelot
2019-06-03 11:14       ` Rasmus Villemoes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a016cd4-ee15-7365-347e-69dfc20c04de@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.