From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Network Development <netdev@vger.kernel.org>
Subject: reset value of MV88E6XXX_G1_IEEE_PRI
Date: Mon, 27 May 2019 09:36:13 +0000 [thread overview]
Message-ID: <4e5592a2-bce3-127b-99e1-7fab00dc0511@prevas.dk> (raw)
Hi,
Looking through the data sheets comparing the mv88e6240 and 6250, I
noticed that they have the exact same description of the G1_IEEE_PRI
register (global1, offset 0x18). However, the current code used by 6240 does
int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip)
{
/* Reset the IEEE Tag priorities to defaults */
return mv88e6xxx_g1_write(chip, MV88E6XXX_G1_IEEE_PRI, 0xfa41);
}
while if my reading of the data sheet is correct, the reset value is
really 0xfa50 (fields 7:6 and 5:4 are RWS to 0x1, field 3:2 and 1:0 are
RWR) - and this is also the value I read from the 6250 on our old BSP
with an out-of-tree driver that doesn't touch that register. This seems
to go way back (at least 3b1588593097). Should this be left alone for
not risking breaking existing setups (just updating the comment), or can
we make the code match the comment? Or am I just reading this all wrong?
Rasmus
next reply other threads:[~2019-05-27 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 9:36 Rasmus Villemoes [this message]
2019-05-27 12:32 ` reset value of MV88E6XXX_G1_IEEE_PRI Vivien Didelot
2019-05-27 13:02 ` Rasmus Villemoes
2019-05-27 14:20 ` Vivien Didelot
2019-06-03 11:14 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e5592a2-bce3-127b-99e1-7fab00dc0511@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.