All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com
Subject: Re: [PATCH] checkpatch: fix typo and remove duplicate word
Date: Fri, 13 Nov 2020 07:00:50 -0800	[thread overview]
Message-ID: <3a0455c93dfd6749cf2050dd973c5bee1cc9f237.camel@perches.com> (raw)
In-Reply-To: <20201113135739.46776-1-dwaipayanray1@gmail.com>

On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
> 
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---

style: this should have subject prefix:

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get
used the proper patch resubmission form but thanks.

>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..041b82f6669e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2841,7 +2841,7 @@ sub process {
>  
> 
>  
> 
>  				# stable@vger.kernel.org or stable@kernel.org shouldn't
> -				# have an email name. In addition commments should strictly
> +				# have an email name. In addition comments should strictly
>  				# begin with a #
>  				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
>  					if (($comment ne "" && $comment !~ /^#.+/) ||
> @@ -5000,7 +5000,7 @@ sub process {
>  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
>  ##
>  ## 			# Remove any bracketed sections to ensure we do not
> -## 			# falsly report the parameters of functions.
> +## 			# falsely report the parameters of functions.
>  ## 			my $ln = $line;
>  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
>  ## 			}
> @@ -7109,7 +7109,7 @@ sub process {
>  		exit(0);
>  	}
>  
> 
> -	# This is not a patch, and we are are in 'no-patch' mode so
> +	# This is not a patch, and we are in 'no-patch' mode so
>  	# just keep quiet.
>  	if (!$chk_patch && !$is_patch) {
>  		exit(0);



WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: fix typo and remove duplicate word
Date: Fri, 13 Nov 2020 07:00:50 -0800	[thread overview]
Message-ID: <3a0455c93dfd6749cf2050dd973c5bee1cc9f237.camel@perches.com> (raw)
In-Reply-To: <20201113135739.46776-1-dwaipayanray1@gmail.com>

On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
> 
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---

style: this should have subject prefix:

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get
used the proper patch resubmission form but thanks.

>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..041b82f6669e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2841,7 +2841,7 @@ sub process {
>  
> 
>  
> 
>  				# stable@vger.kernel.org or stable@kernel.org shouldn't
> -				# have an email name. In addition commments should strictly
> +				# have an email name. In addition comments should strictly
>  				# begin with a #
>  				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
>  					if (($comment ne "" && $comment !~ /^#.+/) ||
> @@ -5000,7 +5000,7 @@ sub process {
>  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
>  ##
>  ## 			# Remove any bracketed sections to ensure we do not
> -## 			# falsly report the parameters of functions.
> +## 			# falsely report the parameters of functions.
>  ## 			my $ln = $line;
>  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
>  ## 			}
> @@ -7109,7 +7109,7 @@ sub process {
>  		exit(0);
>  	}
>  
> 
> -	# This is not a patch, and we are are in 'no-patch' mode so
> +	# This is not a patch, and we are in 'no-patch' mode so
>  	# just keep quiet.
>  	if (!$chk_patch && !$is_patch) {
>  		exit(0);


_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-11-13 15:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 13:57 [PATCH] checkpatch: fix typo and remove duplicate word Dwaipayan Ray
2020-11-13 13:57 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-11-13 15:00 ` Joe Perches [this message]
2020-11-13 15:00   ` Joe Perches
2020-11-13 15:08   ` Dwaipayan Ray
2020-11-13 15:08     ` [Linux-kernel-mentees] " Dwaipayan Ray
  -- strict thread matches above, loose matches on Subject: below --
2020-11-13 13:10 Dwaipayan Ray
2020-11-13 13:34 ` Lukas Bulwahn
2020-11-13 13:48   ` Dwaipayan Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a0455c93dfd6749cf2050dd973c5bee1cc9f237.camel@perches.com \
    --to=joe@perches.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.