[PATCH] platform/mips: Adjust Kconfig to keep consistency

[PATCH] platform/mips: Adjust Kconfig to keep consistency

[Huacai Chen]

Drop the "if MIPS" and "endif" drivers/platform/Kconfig. Instead add
a "depends on MIPS" to "menuconfig MIPS_PLATFORM_DEVICES" in drivers/
platform/mips/Kconfig, like all the other subdirs are doing.

Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 drivers/platform/Kconfig      | 2 --
 drivers/platform/mips/Kconfig | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig
index b437847b6237..8ddfe5ce153f 100644
--- a/drivers/platform/Kconfig
+++ b/drivers/platform/Kconfig
@@ -1,7 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
-if MIPS
 source "drivers/platform/mips/Kconfig"
-endif
 
 source "drivers/platform/goldfish/Kconfig"
 
diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
index 6b51ad01f791..fb4ac4b08e89 100644
--- a/drivers/platform/mips/Kconfig
+++ b/drivers/platform/mips/Kconfig
@@ -6,6 +6,7 @@
 menuconfig MIPS_PLATFORM_DEVICES
 	bool "MIPS Platform Specific Device Drivers"
 	default y
+	depends on MIPS
 	help
 	  Say Y here to get to see options for device drivers of various
 	  MIPS platforms, including vendor-specific netbook/laptop/desktop
-- 
2.31.1

Re: [PATCH] platform/mips: Adjust Kconfig to keep consistency

[Philippe Mathieu-Daudé]

On 18/9/22 12:12, Huacai Chen wrote:
> Drop the "if MIPS" and "endif" drivers/platform/Kconfig. Instead add
> a "depends on MIPS" to "menuconfig MIPS_PLATFORM_DEVICES" in drivers/
> platform/mips/Kconfig, like all the other subdirs are doing.
> 
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>   drivers/platform/Kconfig      | 2 --
>   drivers/platform/mips/Kconfig | 1 +
>   2 files changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] platform/mips: Adjust Kconfig to keep consistency

[Thomas Bogendoerfer]

On Sun, Sep 18, 2022 at 06:12:06PM +0800, Huacai Chen wrote:
> Drop the "if MIPS" and "endif" drivers/platform/Kconfig. Instead add
> a "depends on MIPS" to "menuconfig MIPS_PLATFORM_DEVICES" in drivers/
> platform/mips/Kconfig, like all the other subdirs are doing.
> 
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>  drivers/platform/Kconfig      | 2 --
>  drivers/platform/mips/Kconfig | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig
> index b437847b6237..8ddfe5ce153f 100644
> --- a/drivers/platform/Kconfig
> +++ b/drivers/platform/Kconfig
> @@ -1,7 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> -if MIPS
>  source "drivers/platform/mips/Kconfig"
> -endif
>  
>  source "drivers/platform/goldfish/Kconfig"
>  
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index 6b51ad01f791..fb4ac4b08e89 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -6,6 +6,7 @@
>  menuconfig MIPS_PLATFORM_DEVICES
>  	bool "MIPS Platform Specific Device Drivers"
>  	default y
> +	depends on MIPS
>  	help
>  	  Say Y here to get to see options for device drivers of various
>  	  MIPS platforms, including vendor-specific netbook/laptop/desktop
> -- 
> 2.31.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]