All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Chanwoo Choi <cwchoi00@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
Date: Tue, 12 Jul 2022 22:01:15 -0500	[thread overview]
Message-ID: <3a57d278-295a-313e-ed22-7cc482e9921f@sholland.org> (raw)
In-Reply-To: <59e565e3-8930-9010-7642-2b13607cba61@gmail.com>

On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
> 
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>>
>>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>>    compatible:
>>      enum:
>>        - allwinner,sun5i-a13-mbus
>> +      - allwinner,sun8i-a33-mbus
>> +      - allwinner,sun8i-a50-mbus
>> +      - allwinner,sun8i-a83t-mbus
>>        - allwinner,sun8i-h3-mbus
>>        - allwinner,sun8i-r40-mbus
>> +      - allwinner,sun8i-v3s-mbus
>> +      - allwinner,sun8i-v536-mbus
>> +      - allwinner,sun20i-d1-mbus
>>        - allwinner,sun50i-a64-mbus
>> +      - allwinner,sun50i-a100-mbus
>>        - allwinner,sun50i-h5-mbus
>> +      - allwinner,sun50i-h6-mbus
>> +      - allwinner,sun50i-h616-mbus
>> +      - allwinner,sun50i-r329-mbus
>>  
>>    reg:
>>      minItems: 1
> 
> I have a question. 
> Are there the device drivers for the newly added compatible?

There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.

Regards,
Samuel

WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org>
To: Chanwoo Choi <cwchoi00@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
Date: Tue, 12 Jul 2022 22:01:15 -0500	[thread overview]
Message-ID: <3a57d278-295a-313e-ed22-7cc482e9921f@sholland.org> (raw)
In-Reply-To: <59e565e3-8930-9010-7642-2b13607cba61@gmail.com>

On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
> 
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>>
>>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>>    compatible:
>>      enum:
>>        - allwinner,sun5i-a13-mbus
>> +      - allwinner,sun8i-a33-mbus
>> +      - allwinner,sun8i-a50-mbus
>> +      - allwinner,sun8i-a83t-mbus
>>        - allwinner,sun8i-h3-mbus
>>        - allwinner,sun8i-r40-mbus
>> +      - allwinner,sun8i-v3s-mbus
>> +      - allwinner,sun8i-v536-mbus
>> +      - allwinner,sun20i-d1-mbus
>>        - allwinner,sun50i-a64-mbus
>> +      - allwinner,sun50i-a100-mbus
>>        - allwinner,sun50i-h5-mbus
>> +      - allwinner,sun50i-h6-mbus
>> +      - allwinner,sun50i-h616-mbus
>> +      - allwinner,sun50i-r329-mbus
>>  
>>    reg:
>>      minItems: 1
> 
> I have a question. 
> Are there the device drivers for the newly added compatible?

There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.

Regards,
Samuel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-13  3:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-02  4:24 [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding Samuel Holland
2022-07-02  4:24 ` Samuel Holland
2022-07-02  4:24 ` [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles Samuel Holland
2022-07-02  4:24   ` Samuel Holland
2022-07-02 19:46   ` Jernej Škrabec
2022-07-02 19:46     ` Jernej Škrabec
2022-07-05 20:29   ` Rob Herring
2022-07-05 20:29     ` Rob Herring
2022-07-07 20:06   ` Chanwoo Choi
2022-07-07 20:06     ` Chanwoo Choi
2022-07-13  3:01     ` Samuel Holland [this message]
2022-07-13  3:01       ` Samuel Holland
2022-07-12  5:52   ` Icenowy Zheng
2022-07-12  5:52     ` Icenowy Zheng
2022-07-02 19:41 ` [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding Jernej Škrabec
2022-07-02 19:41   ` Jernej Škrabec
2022-07-05 20:29 ` Rob Herring
2022-07-05 20:29   ` Rob Herring
2022-07-08 16:50 ` Jernej Škrabec
2022-07-08 16:50   ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a57d278-295a-313e-ed22-7cc482e9921f@sholland.org \
    --to=samuel@sholland.org \
    --cc=cw00.choi@samsung.com \
    --cc=cwchoi00@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.