From: Daniel Jeong <gshark.jeong@gmail.com>
To: Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
m.chehab@samsung.com, sakari.ailus@iki.fi,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: i2c: lm3560: use conservative defaults
Date: Sat, 11 Aug 2018 15:10:14 +0900 [thread overview]
Message-ID: <3a9ece34-baad-a19d-c3bd-96aa458ea70b@gmail.com> (raw)
In-Reply-To: <20180716090814.GA4505@amd>
Hi Pavel,
I think if there is not exist pdata, it should be set to the value of power on reset (POR) to sync with the chip.
According to the LM3560 datasheet, Flash Timeout is 512ms, Flash current is 875mA and Torch Current is 93.75mA.
Daniel Jeong.
On 07/016/2018 18:08 PM, Pavel Machek wrote:
> If no pdata is found, we should use lowest current settings, not highest.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> ---
>
> v2: I got notification from patchwork that patch no longer applies, so
> I'm rediffing the patch.
>
> diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
> index b600e03a..c4e5ed5 100644
> --- a/drivers/media/i2c/lm3560.c
> +++ b/drivers/media/i2c/lm3560.c
> @@ -420,14 +434,14 @@ static int lm3560_probe(struct i2c_client *client,
> pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
> if (pdata == NULL)
> return -ENODEV;
> - pdata->peak = LM3560_PEAK_3600mA;
> - pdata->max_flash_timeout = LM3560_FLASH_TOUT_MAX;
> + pdata->peak = LM3560_PEAK_1600mA;
> + pdata->max_flash_timeout = LM3560_FLASH_TOUT_MIN;
> /* led 1 */
> - pdata->max_flash_brt[LM3560_LED0] = LM3560_FLASH_BRT_MAX;
> - pdata->max_torch_brt[LM3560_LED0] = LM3560_TORCH_BRT_MAX;
> + pdata->max_flash_brt[LM3560_LED0] = LM3560_FLASH_BRT_MIN;
> + pdata->max_torch_brt[LM3560_LED0] = LM3560_TORCH_BRT_MIN;
> /* led 2 */
> - pdata->max_flash_brt[LM3560_LED1] = LM3560_FLASH_BRT_MAX;
> - pdata->max_torch_brt[LM3560_LED1] = LM3560_TORCH_BRT_MAX;
> + pdata->max_flash_brt[LM3560_LED1] = LM3560_FLASH_BRT_MIN;
> + pdata->max_torch_brt[LM3560_LED1] = LM3560_TORCH_BRT_MIN;
> }
> flash->pdata = pdata;
> flash->dev = &client->dev;
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: gshark.jeong@gmail.com (Daniel Jeong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] media: i2c: lm3560: use conservative defaults
Date: Sat, 11 Aug 2018 15:10:14 +0900 [thread overview]
Message-ID: <3a9ece34-baad-a19d-c3bd-96aa458ea70b@gmail.com> (raw)
In-Reply-To: <20180716090814.GA4505@amd>
Hi Pavel,
I think if there is not exist pdata, it should be set to the value of power on reset (POR) to sync with the chip.
According to the LM3560 datasheet, Flash Timeout is 512ms, Flash current is 875mA and Torch Current is 93.75mA.
Daniel Jeong.
On 07/016/2018 18:08 PM, Pavel Machek wrote:
> If no pdata is found, we should use lowest current settings, not highest.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> ---
>
> v2: I got notification from patchwork that patch no longer applies, so
> I'm rediffing the patch.
>
> diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
> index b600e03a..c4e5ed5 100644
> --- a/drivers/media/i2c/lm3560.c
> +++ b/drivers/media/i2c/lm3560.c
> @@ -420,14 +434,14 @@ static int lm3560_probe(struct i2c_client *client,
> pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
> if (pdata == NULL)
> return -ENODEV;
> - pdata->peak = LM3560_PEAK_3600mA;
> - pdata->max_flash_timeout = LM3560_FLASH_TOUT_MAX;
> + pdata->peak = LM3560_PEAK_1600mA;
> + pdata->max_flash_timeout = LM3560_FLASH_TOUT_MIN;
> /* led 1 */
> - pdata->max_flash_brt[LM3560_LED0] = LM3560_FLASH_BRT_MAX;
> - pdata->max_torch_brt[LM3560_LED0] = LM3560_TORCH_BRT_MAX;
> + pdata->max_flash_brt[LM3560_LED0] = LM3560_FLASH_BRT_MIN;
> + pdata->max_torch_brt[LM3560_LED0] = LM3560_TORCH_BRT_MIN;
> /* led 2 */
> - pdata->max_flash_brt[LM3560_LED1] = LM3560_FLASH_BRT_MAX;
> - pdata->max_torch_brt[LM3560_LED1] = LM3560_TORCH_BRT_MAX;
> + pdata->max_flash_brt[LM3560_LED1] = LM3560_FLASH_BRT_MIN;
> + pdata->max_torch_brt[LM3560_LED1] = LM3560_TORCH_BRT_MIN;
> }
> flash->pdata = pdata;
> flash->dev = &client->dev;
>
>
>
next prev parent reply other threads:[~2018-08-11 6:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 8:02 [PATCH] media: i2c: lm3560: use conservative defaults Pavel Machek
2018-05-06 8:02 ` Pavel Machek
2018-07-16 9:08 ` [PATCH v2] " Pavel Machek
2018-07-16 9:08 ` Pavel Machek
2018-08-11 6:10 ` Daniel Jeong [this message]
2018-08-11 6:10 ` Daniel Jeong
2018-08-11 9:44 ` Andy Shevchenko
2018-08-11 9:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9ece34-baad-a19d-c3bd-96aa458ea70b@gmail.com \
--to=gshark.jeong@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.